Re: master e6aab30 1/2: Handle encrypting mime parts

Re: master e6aab30 1/2: Handle encrypting mime parts

[Robert Pluim]

>>>>> On Wed, 14 Oct 2020 19:11:45 -0400 (EDT), rms@gnu.org (Richard M. Stallman) said:


    Richard> diff --git a/lisp/epa-mail.el b/lisp/epa-mail.el
    Richard> index 3ad4da1..dd171ab 100644
    Richard> --- a/lisp/epa-mail.el
    Richard> +++ b/lisp/epa-mail.el
    Richard> @@ -243,6 +243,11 @@ If no one is selected, symmetric encryption will be performed.  "
    Richard>        (setq epa-last-coding-system-specified
    Richard>  	    (or coding-system-for-write
    Richard>  		(select-safe-coding-system (point) (point-max)))))
    Richard> + 
Ick           ^
    Richard> +    ;; Insert contents of requested attachments, if any.
    Richard> +    (when (and (eq major-mode 'mail-mode) mail-encode-mml)
    Richard> +      (mml-to-mime)
    Richard> +      (setq mail-encode-mml nil))
 
Why only in mail-mode? Is this not necessary in message-mode?

Robert
-- 

Re: master e6aab30 1/2: Handle encrypting mime parts

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

I never used Message mode, and I never read its code.
So I can't try to maintain it.  I don't know whether it has
a command comparable to rmail-retry-failure.

Would you like to study its code and see whether it could use a
similar change?

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: master e6aab30 1/2: Handle encrypting mime parts

[Robert Pluim]

>>>>> On Fri, 16 Oct 2020 00:11:57 -0400, Richard Stallman <rms@gnu.org> said:

    Richard> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
    Richard> [[[ whether defending the US Constitution against all enemies,     ]]]
    Richard> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]

    Richard> I never used Message mode, and I never read its code.
    Richard> So I can't try to maintain it.  I don't know whether it has
    Richard> a command comparable to rmail-retry-failure.

Iʼm missing context here: what's the relation to rmail-retry-failure?
The change you made is in epa-mail-encrypt.

    Richard> Would you like to study its code and see whether it could use a
    Richard> similar change?

I can, if I understand why the change was made in the first place
(although reading through 'rmail-forward' it appears that message.el
already does the mml->MIME conversion).

Robert
-- 

Re: master e6aab30 1/2: Handle encrypting mime parts

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Iʼm missing context here: what's the relation to rmail-retry-failure?
  > The change you made is in epa-mail-encrypt.

Sorry, I made two changes and confused which one this was about.

With the burdensome amount of mail being sent now to emacs-devel
I have to rush through everything, no time to think twice.

But it is still the case that I know nothing about Mail mode
and can't maintain it.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: master e6aab30 1/2: Handle encrypting mime parts

[Robert Pluim]

>>>>> On Sat, 17 Oct 2020 00:22:39 -0400, Richard Stallman <rms@gnu.org> said:

    Richard> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
    Richard> [[[ whether defending the US Constitution against all enemies,     ]]]
    Richard> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]

    >> Iʼm missing context here: what's the relation to rmail-retry-failure?
    >> The change you made is in epa-mail-encrypt.

    Richard> Sorry, I made two changes and confused which one this was about.

    Richard> With the burdensome amount of mail being sent now to emacs-devel
    Richard> I have to rush through everything, no time to think twice.

    Richard> But it is still the case that I know nothing about Mail mode
    Richard> and can't maintain it.

OK. We'll just have to see if this causes issues for anyone using
message-mode, and fix it when that happens.

Robert
--