From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: 66738@debbugs.gnu.org
Subject: bug#66738: 30.0.50; Gud LLDB regressions
Date: Wed, 25 Oct 2023 06:24:11 +0200 [thread overview]
Message-ID: <m27cnb2utw.fsf@Pro.fritz.box> (raw)
This is with b36e2b1772680b8fce067c6ea2cdf582af982aaa on master.
1. M-x lldb RET leads to errors. *Messages* contains:
error in process filter: gud-marker-filter: Text is read-only
error in process filter: Text is read-only
This seems to come from this code snippet in gud-lldb-marker-filter:
(let ((bol (pos-bol)))
(when (> (point) bol)
;; Move the current line to the string, so that control sequences
;; can delete parts of it.
(setq string (concat (buffer-substring-no-properties bol (point))
string))
(delete-region bol (point))))
The comment sounds like this code is making wrong assumptions about what
the process buffer contains when it runs. I think this can also be seen
when binding inhibit-read-only around the delete-region. Anyway, I don't
really know what it assumes.
(I'd also find it "cleaner" if the code handling the control sequences
could be moved to a function of its own.)
2. Nitpick: when extracting the file name in the filter function, with
(group (+ (not (in "\n\r")))) ; 3: file
this means that file names cannot contain LF and CR, which they actually
can. I guess the only thing a file name definitely cannot contain is
'/'. Don't care about Windows, TBH :-).
next reply other threads:[~2023-10-25 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 4:24 Gerd Möllmann [this message]
2023-10-25 8:32 ` bug#66738: 30.0.50; Gud LLDB regressions Mattias Engdegård
2023-10-25 9:06 ` Gerd Möllmann
2023-10-25 9:40 ` Mattias Engdegård
2023-10-25 14:02 ` Gerd Möllmann
2023-10-25 14:23 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27cnb2utw.fsf@Pro.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=66738@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.