From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Al Haji-Ali Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Fri, 07 Jun 2024 19:44:45 +0100 Message-ID: References: <86ikymipzx.fsf@gnu.org> <7269c7c4-86a1-44bf-8d5d-378c3584027a@gmx.at> <86zfrx8ec0.fsf@mail.linkov.net> <8561a63a-66d3-44cd-872f-73d26af7edbe@gmx.at> <86msnw4qm4.fsf@mail.linkov.net> <86y17gej2x.fsf@gnu.org> <86y17gmxdg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 71386@debbugs.gnu.org To: Juri Linkov , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 08 01:55:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFjQD-0005rQ-Cw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jun 2024 01:55:01 +0200 Original-Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFekf-00058q-GT; Fri, 07 Jun 2024 14:55:49 -0400 Original-Received: from [2001:470:142:3::10] (helo=eggs.gnu.org) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFekc-0004o1-PD for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 14:55:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFekc-0007MT-H7 for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 14:55:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFekr-0007kp-Jl for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 14:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Al Haji-Ali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2024 18:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.171778653929742 (code B ref 71386); Fri, 07 Jun 2024 18:56:01 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 7 Jun 2024 18:55:39 +0000 Original-Received: from localhost ([127.0.0.1]:52041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFekV-0007je-9Y for submit@debbugs.gnu.org; Fri, 07 Jun 2024 14:55:39 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:46431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFekT-0007jH-Gs for 71386@debbugs.gnu.org; Fri, 07 Jun 2024 14:55:38 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4216724ced1so10518365e9.1 for <71386@debbugs.gnu.org>; Fri, 07 Jun 2024 11:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717786456; x=1718391256; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=R320gO8Zjg4tljSyOnJDKcc9DCf2UBHXaYyQIJFXBsM=; b=VPD9Ix0a3FN2RVt25W2UoiDPU1OqB2krv89noKPMogrl+F3tfDOIqhOoQgbwH3Xy6f IedJcYvvgc116N9D4aKPlmzmYgYp9l3uCAy4ZDn6nhTOtGQnmyT5iaXqW8TvPNC21PW3 plI3ki7P30Rl23MnmXijORJqTfug3c0lAn96hC60DBsXX8oHrvfhM+/UVNsY6NHnE28K yB9L3C04fOMvZ7E/xnOug1VnhRG9Qu8SVLuusTNQne3A/EqfldM/vFXM+gJsDx0GJKJU PCsrVrBDbql06pY7PmzWcoOE3ilfJ2Lp/CQXtLbhT7LhJA6QmRiWPtUoWb8ztv3DjU/E h6yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717786456; x=1718391256; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R320gO8Zjg4tljSyOnJDKcc9DCf2UBHXaYyQIJFXBsM=; b=sCytv1QZ7zjCdEcjezS+wa3yZL53BDrJrF1ER/uXQfjLz56LkM9Yx1czP7epP0ZVOx O/FMAYJ/Smqabp5/r5qzNGhyYtKM7Y+CaSFYFl/hMwnr/dGvZUaj8r3szuL+TPRfL/Zc GKfPcSEkwKNaTvzufr8qOXf5H/PxjVF9fzaLqUoZSb0BLqxG6807t1WLueutjrku4L/s 2mN6nTLIP7dcTP9X3/f5LtPuSEJWGTJmA1+x+dszCrb3ChggW68Kess2yGgdRxmazHTU QLa9Ab4aCb+XQdP3RBI1Bnea0lu5WfJriegLKZ8x5hu8pI3Jwf4zSEKyaeVegUhwVJ1r /7Tw== X-Forwarded-Encrypted: i=1; AJvYcCWlCQW2Dm0jUyveC3jPFsg3id2H6K/PADw9q3WTyM1eFpGeH9Yoo+VU6SX8hxFf3+qfeZLCBBxquOV1ur1TYbL4ztD8w38= X-Gm-Message-State: AOJu0YwYLVSdfrCXH994Qvb2IPhwnSyiLkbjoEePaI3NG5PaYS6iBEe7 /AMQnoQFJ5kikVbqKyHNl5joUJWiL0+birHJyLQVY/Mhib7LFKD0tjKlPQ== X-Google-Smtp-Source: AGHT+IFe/oFJzSxIs40eqNnU9CE9hDlcpSWFO2Ov2XhYnesTzX+nKr0lgSSGViwo+k+Y7lAmdJkZCg== X-Received: by 2002:a05:600c:a382:b0:417:fbc2:caf8 with SMTP id 5b1f17b1804b1-42164a03077mr28549445e9.23.1717785895542; Fri, 07 Jun 2024 11:44:55 -0700 (PDT) Original-Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c2c7dafsm60966225e9.35.2024.06.07.11.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 11:44:54 -0700 (PDT) In-Reply-To: <86y17gmxdg.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286794 Archived-At: On 07/06/2024, Juri Linkov wrote: > Ok, here is a better patch: Hello Juri, If I may interject a bit, I think it would be better if the tab is closed (i.e., tab-bar-close-tab is called) and another tab is displayed when the dedicated buffer is killed if its the only one in a window. For example, I changed `window--delete` on my machine to have this (if (and tab-bar-mode (> (length (tab-bar-tabs)) 1)) (tab-bar-close-tab) (delete-frame frame)) In your patch, `tab-bar-window-delete-frame-p` doesn't do that, nor should it as it is a predicate. Maybe `window-delete-frame-predicate-functions` should be renamed to `window-delete-frame-actions` or something and `tab-bar-close-tab` should be called in `tab-bar-window-delete-frame-p` (removing `-p` probably) -- in fact, the `delete-frame` code itself could be added as such an action, if we are not averse to changes to the interface. Also, just FYI, your patch doesn't allow the branches with `auto-hide-function` and `frame-auto-hide-function` to be called when `kill` is nil. I don't know the side-effects of not calling these functions in such cases, but might be worth checking. -- Al