version 4.56 different in emacs

version 4.56 different in emacs

[Leo]

Hi all,

This is just my curiosity. I diff org.el (from emacs) and the one from
Carsten's website. Although they have same version number, I see the
following differences:

--- /tmp/org-emacs.el	2006-11-22 19:39:22.000000000 +0000
+++ /home/kky/org.el	2006-11-17 07:53:16.000000000 +0000
@@ -6112,7 +6112,6 @@
 	 (with-hm (and (nth 1 t1) (nth 2 t1)))
 	 (inactive (= (char-before (1- beg)) ?\[))
 	 (tf (funcall (if with-hm 'cdr 'car) org-time-stamp-custom-formats))
-	 (time (org-fix-decoded-time t1))
 	 (time (mapcar (lambda (x) (or x 0)) t1))
 	 (str (org-add-props
 		  (format-time-string
@@ -6128,12 +6127,6 @@
 	  (put-text-property beg end 'end-glyph (make-glyph str)))
       (put-text-property beg end 'display str))))
 
-(defun org-fix-decoded-time (time)
-  "Set 0 instead of nil for the first 6 elements of time.
-Don't touch the rest."
-  (let ((n 0))
-    (mapcar (lambda (x) (if (< (setq n (1+ n)) 7) (or x 0) x)) time)))
-
 (defun org-days-to-time (timestamp-string)
   "Difference between TIMESTAMP-STRING and now in days."
   (- (time-to-days (org-time-string-to-time timestamp-string))

-- 
Leo

Re: version 4.56 different in emacs

[Carsten Dominik]

On Nov 22, 2006, at 20:48, Leo wrote:

> Hi all,
>
> This is just my curiosity. I diff org.el (from emacs) and the one from
> Carsten's website. Although they have same version number, I see the
> following differences:


While I am not installing new features into the Emacs CVS version 
currently,
I still do fix significant bugs.  I guess it is sloppy to not change the
version number in Emacs to, say, 4.56a.  This specific bug could cause
the overlayed custom time format to differ by several hours (depending 
on your time zone) from the actual value given in the time stamp.

- Carsten

>
> --- /tmp/org-emacs.el	2006-11-22 19:39:22.000000000 +0000
> +++ /home/kky/org.el	2006-11-17 07:53:16.000000000 +0000
> @@ -6112,7 +6112,6 @@
>  	 (with-hm (and (nth 1 t1) (nth 2 t1)))
>  	 (inactive (= (char-before (1- beg)) ?\[))
>  	 (tf (funcall (if with-hm 'cdr 'car) org-time-stamp-custom-formats))
> -	 (time (org-fix-decoded-time t1))
>  	 (time (mapcar (lambda (x) (or x 0)) t1))
>  	 (str (org-add-props
>  		  (format-time-string
> @@ -6128,12 +6127,6 @@
>  	  (put-text-property beg end 'end-glyph (make-glyph str)))
>        (put-text-property beg end 'display str))))
>
> -(defun org-fix-decoded-time (time)
> -  "Set 0 instead of nil for the first 6 elements of time.
> -Don't touch the rest."
> -  (let ((n 0))
> -    (mapcar (lambda (x) (if (< (setq n (1+ n)) 7) (or x 0) x)) time)))
> -
>  (defun org-days-to-time (timestamp-string)
>    "Difference between TIMESTAMP-STRING and now in days."
>    (- (time-to-days (org-time-string-to-time timestamp-string))
>
> -- 
> Leo
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

Re: version 4.56 different in emacs

[Leo]

On Tuesday, 28 Nov 2006, Carsten Dominik wrote:

> On Nov 22, 2006, at 20:48, Leo wrote:
>
>> Hi all,
>>
>> This is just my curiosity. I diff org.el (from emacs) and the one from
>> Carsten's website. Although they have same version number, I see the
>> following differences:
>
>
> While I am not installing new features into the Emacs CVS version
> currently,
> I still do fix significant bugs.  I guess it is sloppy to not change the
> version number in Emacs to, say, 4.56a.  This specific bug could cause
> the overlayed custom time format to differ by several hours (depending
> on your time zone) from the actual value given in the time stamp.
>
> - Carsten
>

Thanks.

I like the pace of org development and I think most of the users are
using the latest version anyway.

-- 
Leo

Re: Re: version 4.56 different in emacs

[Carsten Dominik]

On Nov 28, 2006, at 15:11, Leo wrote:

> On Tuesday, 28 Nov 2006, Carsten Dominik wrote:
>
>> On Nov 22, 2006, at 20:48, Leo wrote:
>>
>>> Hi all,
>>>
>>> This is just my curiosity. I diff org.el (from emacs) and the one 
>>> from
>>> Carsten's website. Although they have same version number, I see the
>>> following differences:
>>
>>
>> While I am not installing new features into the Emacs CVS version
>> currently,
>> I still do fix significant bugs.  I guess it is sloppy to not change 
>> the
>> version number in Emacs to, say, 4.56a.  This specific bug could cause
>> the overlayed custom time format to differ by several hours (depending
>> on your time zone) from the actual value given in the time stamp.
>>
>> - Carsten
>>
>
> Thanks.
>
> I like the pace of org development and I think most of the users are
> using the latest version anyway.

Yes, most current users certainly.  However, once Emacs 22 hits the 
street,
a huge amount of new users will have a version of org-mode available,
and many of those will not go and get the newest.

- Carsten