From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#18575: package-test-signed should use skip-unless, not expected-result Date: Tue, 30 Sep 2014 09:18:28 -0400 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1412084735 17925 80.91.229.3 (30 Sep 2014 13:45:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Sep 2014 13:45:35 +0000 (UTC) Cc: 18575@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 30 15:45:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYxk5-0004BZ-JT for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 15:45:25 +0200 Original-Received: from localhost ([::1]:43462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxk2-0000d5-7J for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 09:45:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxjt-0000cP-WC for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 09:45:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYxjp-0007b4-2U for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 09:45:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxjo-0007Wa-TP for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 09:45:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYxji-0002Lt-TW for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 09:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Sep 2014 13:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18575-submit@debbugs.gnu.org id=B18575.14120846608969 (code B ref 18575); Tue, 30 Sep 2014 13:45:02 +0000 Original-Received: (at 18575) by debbugs.gnu.org; 30 Sep 2014 13:44:20 +0000 Original-Received: from localhost ([127.0.0.1]:55947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYxj1-0002Ka-QN for submit@debbugs.gnu.org; Tue, 30 Sep 2014 09:44:20 -0400 Original-Received: from mail-qa0-f43.google.com ([209.85.216.43]:61191) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYxiz-0002KR-Np for 18575@debbugs.gnu.org; Tue, 30 Sep 2014 09:44:18 -0400 Original-Received: by mail-qa0-f43.google.com with SMTP id cm18so455618qab.16 for <18575@debbugs.gnu.org>; Tue, 30 Sep 2014 06:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=YVFqBWS8HOT5WMyE1jobeGs3Ktkq83ibZzqzxkxLhio=; b=o5yLvUIS+du7aXUWBNEYn0l6b/sODg7JdwaLyuUcJk8dM3sloyAdC1K0gvwUbYPX5Q 0dX4mMyqucQIEiOR9GoFxRTdIwcl7Gri5gKW2/T9QCAUluzoDpzKi+D9Q1VEFaOR9ond oECth3Bu5xZpPkm5lrd0xX8j0jOUfx1+cCy8w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=YVFqBWS8HOT5WMyE1jobeGs3Ktkq83ibZzqzxkxLhio=; b=eYI65aHXGF91nVqiMW5Yh+hYk+z1vYqsBWUD0vAfnsR+45+aLSBVhKXfIN4K/JgCpu aM4ZZTHpjHAmftpE1j8o5dR3uvBLdU86vUS8505kibOomQ0EwcCRt7uJNV2klVFMBHDq ZBUZefm/ecIYhQNCW+R1ychjEsla6FpUadPTbOg0GYe6/KiChqH8sUR8L1guxXmwesus DE890n0fz+FRH554qOk/lv+5QEw5fl9jWOS35gEZXpB0UdavcSuM08SEHwCbduvqjDX2 CzLXbMfFzjBvwNVOiblOgwmjfAqu7QJs361eWIl/LP9q295dCAvtZC89lK88nhhDBqQa YHbg== X-Gm-Message-State: ALoCoQk940FawwVk+Tbp7+oIgOR/a4zDiGBi29UtsbCIf2oDTZSc3TfAc5q00Ow28t87LESoJXnv X-Received: by 10.224.166.200 with SMTP id n8mr1260085qay.50.1412083113270; Tue, 30 Sep 2014 06:18:33 -0700 (PDT) Original-Received: from bug.local ([198.0.146.153]) by mx.google.com with ESMTPSA id k10sm13803603qaj.7.2014.09.30.06.18.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Sep 2014 06:18:32 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Glenn Morris's message of "Sat, 27 Sep 2014 18:01:42 -0400") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (darwin) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93909 Archived-At: On Sat, 27 Sep 2014 18:01:42 -0400 Glenn Morris wrote: GM> Glenn Morris wrote: >> package-test-signed should use skip-unless rather than expected-result. >> The latter can lead to false "failures" when the test succeeds, eg >> >> https://hydra.nixos.org/build/14915239/log/raw GM> The fact that the test can pass even when epg-check-configuration fails GM> probably indicates that is the wrong thing to test anyway. The cause on GM> hydra is probably that HOME does not exist, which causes gpg GM> --list-config to fail: GM> HOME=/tmp/foo/bar gpg --with-colons --list-config GM> gpg: fatal: can't create directory `/tmp/foo/bar/.gnupg': No such file or directory GM> Perhaps tests should bind epg-gpg-home-directory to a suitable value. `package-refresh-contents` should create this directory and set it as the EPG context's homedir. That does not depend, in theory, on `epg-gpg-home-directory` because `package-refresh-contents` calls `package-import-keyring` which does: (let ((context (epg-make-context 'OpenPGP)) (homedir (expand-file-name "gnupg" package-user-dir))) (make-directory homedir t) (epg-context-set-home-directory context homedir) ... Ted