From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history Date: Thu, 28 Sep 2017 10:24:30 -0700 Message-ID: References: <83h8vxfobt.fsf@gnu.org> <6ab17adb-c05e-628d-6b53-666c8bf26a75@yandex.ru> <83o9q4dshj.fsf@gnu.org> <75512192-de23-07dd-2492-ec8ec0888161@yandex.ru> <1506597095.2715104.1121128328.5F777197@webmail.messagingengine.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506619493 23917 195.159.176.226 (28 Sep 2017 17:24:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 28 Sep 2017 17:24:53 +0000 (UTC) User-Agent: Gnus/5.130016 (Ma Gnus v0.16) Emacs/26.0 (darwin) Cc: Eli Zaretskii , jostein@kjonigsen.net, Emacs developers To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 28 19:24:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxcYG-0005Xf-8y for ged-emacs-devel@m.gmane.org; Thu, 28 Sep 2017 19:24:44 +0200 Original-Received: from localhost ([::1]:60169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxcYN-0003wm-7b for ged-emacs-devel@m.gmane.org; Thu, 28 Sep 2017 13:24:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxcYB-0003uj-Pc for emacs-devel@gnu.org; Thu, 28 Sep 2017 13:24:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxcYA-0001RX-SP for emacs-devel@gnu.org; Thu, 28 Sep 2017 13:24:39 -0400 Original-Received: from mail-pg0-x22a.google.com ([2607:f8b0:400e:c05::22a]:52126) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxcY7-0001Pp-5u; Thu, 28 Sep 2017 13:24:35 -0400 Original-Received: by mail-pg0-x22a.google.com with SMTP id k193so1297819pgc.8; Thu, 28 Sep 2017 10:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version; bh=X3LfMxoDmF2KAn+bnDUjrkST/VzFO83s0sPzWPL8/LE=; b=JdBxHISYMLt3dxM29fdtaM8tUKgshoYBZ01iuPWKKK6+JUihxJreU+R3O6zfSTEbV3 sVfOh3gdYOKkjhWZ99dvtToqrVXHqiZ23NF04lI4SkgsmDppKxkEV/iFJOKMI+U8kGPE pJBhqQPRLCf/Dbx1sEdn54HGcRu/oeCvXN9ZeQQdspo+oUIs4tcRv8EKTcilbYvlJRxA 0v2nRDr4YVFHrxaUKJ7GYfPlEVt70V1RyhiOGWhdTGpcFxpHhrMFmdyeQnj9U9W81w+l AwEl0vbOm028hfFCEGZNjWNd2uVtIPf0GBYWcZ9Z6/lVuUz7qSs2W2UzgN9rMVWS3UAQ //Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mail-followup-to:mime-version; bh=X3LfMxoDmF2KAn+bnDUjrkST/VzFO83s0sPzWPL8/LE=; b=BeHw+/i2XWfXCSMsA3jVbiHp627vFoZkMhRmN0h9CasYBE8uIr301GrdW8GBKGuHPI WaVC7tiV34bW4MX8lNxlNklStHz/FhAcA2CwATU0zYpa0mki+lPlMUXUjXmL0TL+KZAU EtkVXlKzzF1ieFMHc5N+gG/a5hMv5CO3sGsQPbeLeGD+Hb8idCwL0F8xmOiY7wrrNvkn lA/v7TDexxgaFBGVRsH+S9gwftrdl3BDEcdqUC75y92aCxIgdZjRY/65czcKgScZwnux Ty7t8mDDKNcjNmnifL0ElRT5IbZaGM2sFQVeOq+Bz1wmsbNLSEY/ixLKCjHg5pXD0Z71 ntCA== X-Gm-Message-State: AHPjjUgIbfsiKx9rXgupeeX98DeB8bMr1GtfMRXpZCIfEBpAhlAv/5OX 5O1fDDFW/6QrKcY311T9O4M= X-Google-Smtp-Source: AOwi7QCgJvZcFyZ5AMy3b2ELn1rKxR23WM1IGq5aclewyPgiMBb91ZenNOrf71O7b4lIic4mG7nZhw== X-Received: by 10.101.93.65 with SMTP id e1mr4935199pgt.150.1506619474204; Thu, 28 Sep 2017 10:24:34 -0700 (PDT) Original-Received: from Vulcan.local (76-234-69-149.lightspeed.frokca.sbcglobal.net. [76.234.69.149]) by smtp.gmail.com with ESMTPSA id s62sm4490119pfe.91.2017.09.28.10.24.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Sep 2017 10:24:33 -0700 (PDT) X-Google-Original-From: John Wiegley Original-Received: by Vulcan.local (Postfix, from userid 501) id BC65D9456FB9; Thu, 28 Sep 2017 10:24:31 -0700 (PDT) In-Reply-To: (Kaushal Modi's message of "Thu, 28 Sep 2017 17:22:04 +0000") Mail-Followup-To: Kaushal Modi , jostein@kjonigsen.net, Emacs developers , Eli Zaretskii X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218854 Archived-At: >>>>> Kaushal Modi writes: > So far there has been no opposition to binding C-x v h with > vc-region-history. > I am basically proposing to bind the super-useful vc-region-history to > "something" in "C-x v" map. I offered C-x v H. But based on the above > discussion C-x v h makes more sense. > I would be great to get a clear "yes" or "no" as this issue seems to have > lingered too long. > I'd put this very concisely as: > (let ((res (binding--vc-region-history--resolution))) > (cond ((string= "yes, C-x v h" res) > "best option") > ((string= "yes, C-x v H" res) > "good option") > ((string= "no, don't bind vc-region-history" res) > "bad option, but I'll accept") > (t > (error "invalid")))) Hah, I love it. :) I'm all for making it C-x v h, and having C-x v H insert headers. The former is by far the more common operation, and in this case I'm willing to break with tradition for better convenience. Please give this a good notice in the NEWS file, so people notice. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2