From: John Wiegley <jwiegley@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
jostein@kjonigsen.net, Emacs developers <emacs-devel@gnu.org>
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 28 Sep 2017 10:24:30 -0700 [thread overview]
Message-ID: <m260c2rb1t.fsf@newartisans.com> (raw)
In-Reply-To: <CAFyQvY2jArXL5sVca+kAJ-U5OLbtZMABnZ_b_yZ6QDPmarapiQ@mail.gmail.com> (Kaushal Modi's message of "Thu, 28 Sep 2017 17:22:04 +0000")
>>>>> Kaushal Modi <kaushal.modi@gmail.com> writes:
> So far there has been no opposition to binding C-x v h with
> vc-region-history.
> I am basically proposing to bind the super-useful vc-region-history to
> "something" in "C-x v" map. I offered C-x v H. But based on the above
> discussion C-x v h makes more sense.
> I would be great to get a clear "yes" or "no" as this issue seems to have
> lingered too long.
> I'd put this very concisely as:
> (let ((res (binding--vc-region-history--resolution)))
> (cond ((string= "yes, C-x v h" res)
> "best option")
> ((string= "yes, C-x v H" res)
> "good option")
> ((string= "no, don't bind vc-region-history" res)
> "bad option, but I'll accept")
> (t
> (error "invalid"))))
Hah, I love it. :)
I'm all for making it C-x v h, and having C-x v H insert headers. The former
is by far the more common operation, and in this case I'm willing to break
with tradition for better convenience. Please give this a good notice in the
NEWS file, so people notice.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
next prev parent reply other threads:[~2017-09-28 17:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 18:43 bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history Kaushal Modi
2017-09-20 14:03 ` Kaushal Modi
2017-09-20 14:15 ` Eli Zaretskii
2017-09-21 3:01 ` Kaushal Modi
2017-09-28 18:23 ` Kaushal Modi
2017-09-29 11:54 ` Dmitry Gutov
2017-09-29 11:59 ` Kaushal Modi
2017-09-29 16:43 ` Kaushal Modi
2017-09-29 17:31 ` John Wiegley
2017-09-29 17:22 ` Eli Zaretskii
2017-09-29 17:39 ` Stefan Monnier
2017-09-29 18:16 ` Eli Zaretskii
2017-09-29 18:32 ` Kaushal Modi
2017-09-30 14:03 ` Dmitry Gutov
2017-09-30 14:12 ` Kaushal Modi
2017-09-21 14:22 ` Dmitry Gutov
2017-09-21 14:41 ` Eli Zaretskii
2017-09-21 15:29 ` Dmitry Gutov
2017-09-21 20:39 ` Kaushal Modi
2017-09-22 3:15 ` Stefan Monnier
2017-09-22 13:51 ` Dmitry Gutov
2017-09-22 14:06 ` Kaushal Modi
2017-09-22 14:03 ` Kaushal Modi
2017-09-23 8:06 ` Clément Pit-Claudel
2017-09-28 11:11 ` Jostein Kjønigsen
2017-09-28 11:19 ` Kaushal Modi
2017-09-28 16:59 ` John Wiegley
2017-09-28 17:22 ` Kaushal Modi
2017-09-28 17:24 ` John Wiegley [this message]
2017-09-28 18:26 ` Kaushal Modi
2017-09-28 19:59 ` Stefan Monnier
2017-09-28 19:55 ` Stefan Monnier
2017-09-29 9:37 ` Robert Pluim
2017-09-29 19:50 ` Paul Eggert
2017-09-29 19:55 ` Kaushal Modi
2017-09-28 21:11 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m260c2rb1t.fsf@newartisans.com \
--to=jwiegley@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jostein@kjonigsen.net \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.