From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Fri, 08 Feb 2019 12:46:32 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <837eg8dpd6.fsf@gnu.org> <83zhr6pqmr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109710"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 12:48:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gs4eN-000SPz-EG for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 12:48:55 +0100 Original-Received: from localhost ([127.0.0.1]:55235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs4eM-000658-Ek for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 06:48:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs4dA-00064d-Lx for emacs-devel@gnu.org; Fri, 08 Feb 2019 06:47:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs4cx-0006sZ-8x for emacs-devel@gnu.org; Fri, 08 Feb 2019 06:47:31 -0500 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:39660) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gs4cF-0006XZ-5x; Fri, 08 Feb 2019 06:47:18 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id t27so3226307wra.6; Fri, 08 Feb 2019 03:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=EC8jjH9y3sLP3pF1qHgNWTTRsvZtfM01fMEJJKhje64=; b=nZN063sdEOt2m5YzlwfLTDlO6+VUdnKO469rg2dDSYynEWNn6nnpZGN81yKTpqwOK3 7QAKU4oErHYHsYYf0TXrHy4t6efTU5xQcs5pY4HcQRhP82RRStnirO58jATF6E6ITJJX 6+4yaZT6mBvW7DCg2cdh+6Xu4nrhfrwm3F948eL/FNkmfiNmsxDTZCV/vbnhubusIYaw I18JHh66ROe+OEb+xdL1FJtgaJoG4PB8ZvWCN8vG9+2ayW0zqzGzZLYpdOJND46G+74o smLj+yLqNW2tO92ZBOVxR6dn8UGia5+UV7nDrgc/a2BBmmTN2VSb/sWIY7CXqmPDs2sg zK9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=EC8jjH9y3sLP3pF1qHgNWTTRsvZtfM01fMEJJKhje64=; b=MF7dgsyGvkeVutyKZYMz8vG/ObXe7rBVSghCtBkOLZY04ny6b3uA2Hl1YWQaXI59z2 6eE6u6JQUqQ9IOX/Zr4goYURD63QPzrXzjUjo7oljqX/q6LHNMxNaADPJHa+Sf6OSn3V mQm89827m+gSVkx1ZVBlQi8k4lYoJT0mJQ9VsOdbO1olic1G6Q9X9KOoBAjEyeJkZWKN 1d1TvW3w0aEn1Bh6V2LM5NJYN9RPpKYWXfHV19SCfrvRa3QnXTia84Tvkmk4/OK2tZwf X//9p0UtDXxcutQjXVyy6yLllj2y7mDM1HWv1TgEZaX/CCELLgvyX/p8PTFGjnV5V02H B6mw== X-Gm-Message-State: AHQUAubN7S5ep0uI4FBWvZrrk51Y0KPir5lzrATbqjHC0o6M6SZdslet XQovfdhsDLKnDAB2hr7o3WLKdTi3h28= X-Google-Smtp-Source: AHgI3Ib3zolxJZ0l48YxEPpkjxCczq5+T03YStB2hbZ6PNm90umw3B8UiH+gEolW1o7vSE98OIpe9w== X-Received: by 2002:adf:ea81:: with SMTP id s1mr15820477wrm.309.1549626395049; Fri, 08 Feb 2019 03:46:35 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:508e:f5c1:5162:8e85]) by smtp.gmail.com with ESMTPSA id b129sm1650133wmd.24.2019.02.08.03.46.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 08 Feb 2019 03:46:33 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83zhr6pqmr.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Feb 2019 11:37:48 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233116 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: ari.roponen@gmail.com, emacs-devel@gnu.org >> Date: Fri, 08 Feb 2019 09:01:22 +0100 >>=20 >> Eli Zaretskii writes: >> > >> > Thanks, this LGTM, and is a significant improvement, IMO. If no one >> > objects in a few days, please push. >>=20 >> I built this on GNU/Linux with the following configs: >>=20 >> ./configure # This builds xfont.o ftfont.o xftfont.o ftxf= ont.o > > I wonder why we build both xftfont.o and ftxfont.o, when we only use > one of them, if my reading of the code is correct. > I did suggest removing ftxfont.o, but you said we had to deprecate it first. It=CA=BCs easy enough to not build in the HAVE_XFT config. >> I can cherry-pick this to the harfbuzz branch if you want. > > Thanks, please do. Will do. Robert