From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39133: 28.0.50; Emacs slowdown on special char Date: Wed, 15 Jan 2020 09:25:43 +0100 Message-ID: References: <83lfqa5aa2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao:159.69.161.202"; logging-data="72523"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Evgeny Zajcev , 39133@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 15 15:54:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irhgc-0001p1-SG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 13:22:14 +0100 Original-Received: from localhost ([::1]:50950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ire2w-0005O5-CT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 03:29:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45834) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ire14-0004kg-QG for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:27:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ire10-0004d2-Nd for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:27:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56502) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ire10-0004cN-Jt for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ire10-00021b-H5 for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:27:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2020 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39133 X-GNU-PR-Package: emacs Original-Received: via spool by 39133-submit@debbugs.gnu.org id=B39133.15790767627692 (code B ref 39133); Wed, 15 Jan 2020 08:27:02 +0000 Original-Received: (at 39133) by debbugs.gnu.org; 15 Jan 2020 08:26:02 +0000 Original-Received: from localhost ([127.0.0.1]:34242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irdzx-0001zm-GQ for submit@debbugs.gnu.org; Wed, 15 Jan 2020 03:26:02 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:40919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irdzr-0001zR-Rg for 39133@debbugs.gnu.org; Wed, 15 Jan 2020 03:25:56 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id t14so16750814wmi.5 for <39133@debbugs.gnu.org>; Wed, 15 Jan 2020 00:25:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:mime-version :content-transfer-encoding; bh=CjcGgCoYhDWKc1GQ6nNS3oK9wP4g6HuVYSycC2wpx5s=; b=mZd76WI9tMOPqrtWJwXyiYuqOfJmgBkuAM4x6IvX36g+EijPjB+mtpltQINIp0dg2N 1M9t6uEL+FURz8kWMIBvfYcQ2DVqjl3X3Bw4j1yax1+kgFTY77x/iJzThUURoVz9iPtS QmXXG7lL9z6uBZ0se2wz4koy8zSPhZBYrdkmu71u3TWu+6d4IIrLCs5cgGW+R3j8PhqS WkK9j8FSWF63QK7LLI4sIW7rPwzDewRPchkgfuDDm0ICqVAILMZ/zZ7W3AAsae4CdShN /1yPlhVjH3+cvJnmG/uGhwss4O/BSqK+O1z2fuIePpdLh7/0Zy04xHU0B1LqPZBYi536 rmig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version:content-transfer-encoding; bh=CjcGgCoYhDWKc1GQ6nNS3oK9wP4g6HuVYSycC2wpx5s=; b=cSGCMzOrAYiC3ZS9e5j29Ig0RYkl4RXgclRLtgQBacjMMvLbapBGCqfI7xtc+3u/Tq KAlzYnBllmgGZStpcbxjNgWa9Baa8iBMncRy99Chx3tNE3gMFueV5Jb0w3tGPdwCSsDv dxjRdKCzQCuK4bGsYVzOEP1iZR/HDbQTNuOq4arEisfGx9gtH5auAzTNz3QrtU4yHTL8 bYN5v3gbGgBfZQB6oa8zrBldF8Xbkcl0DoDJuazeP+XeZiNSDqXifQ8g7EZARQDfoi3p nWBesTah0fnBACIFytCmvRQDVoZZw5ai6qtieRrwHvmQb7W9hMn7mNPEnOFFpMZP4OBX W5TQ== X-Gm-Message-State: APjAAAXaGcVNqS+cQksbiT6/sc0gNBoKpg+AqPyiPDzpf19KMfyQWrtz cBihubv59s59c6yhlkUdCbk= X-Google-Smtp-Source: APXvYqwOs3Dm7xVF+ZlMoqYx9X8wNVpMZmnMwcgAa8/GQLXcS7zsHNsisfp4ZRyRaJz9qwYA74geVQ== X-Received: by 2002:a05:600c:20e:: with SMTP id 14mr24440859wmi.104.1579076745821; Wed, 15 Jan 2020 00:25:45 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id n189sm22877703wme.33.2020.01.15.00.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2020 00:25:45 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174623 Archived-At: >>>>> On Wed, 15 Jan 2020 13:26:11 +0900, YAMAMOTO Mitsuharu said: YAMAMOTO> 0xFFFFFFFF comes from FONT_INVALID_CODE. font->driver->text_e= xtents YAMAMOTO> shouldn't be called if font->font->driver->encode_char return= s it. YAMAMOTO> diff --git a/src/font.c b/src/font.c YAMAMOTO> index 2b90903c90..03e6176220 100644 YAMAMOTO> --- a/src/font.c YAMAMOTO> +++ b/src/font.c YAMAMOTO> @@ -4420,15 +4420,19 @@ font_fill_lglyph_metrics (Lisp_Object= glyph, Lisp_Object font_object) YAMAMOTO> { YAMAMOTO> struct font *font =3D XFONT_OBJECT (font_object); YAMAMOTO> unsigned code =3D font->driver->encode_char (font, LGLYPH_= CHAR (glyph)); YAMAMOTO> - struct font_metrics metrics; YAMAMOTO> - YAMAMOTO> - LGLYPH_SET_CODE (glyph, code); YAMAMOTO> - font->driver->text_extents (font, &code, 1, &metrics); YAMAMOTO> - LGLYPH_SET_LBEARING (glyph, metrics.lbearing); YAMAMOTO> - LGLYPH_SET_RBEARING (glyph, metrics.rbearing); YAMAMOTO> - LGLYPH_SET_WIDTH (glyph, metrics.width); YAMAMOTO> - LGLYPH_SET_ASCENT (glyph, metrics.ascent); YAMAMOTO> - LGLYPH_SET_DESCENT (glyph, metrics.descent); YAMAMOTO> + YAMAMOTO> + if (code !=3D FONT_INVALID_CODE) YAMAMOTO> + { YAMAMOTO> + struct font_metrics metrics; YAMAMOTO> + YAMAMOTO> + LGLYPH_SET_CODE (glyph, code); YAMAMOTO> + font->driver->text_extents (font, &code, 1, &metrics); YAMAMOTO> + LGLYPH_SET_LBEARING (glyph, metrics.lbearing); YAMAMOTO> + LGLYPH_SET_RBEARING (glyph, metrics.rbearing); YAMAMOTO> + LGLYPH_SET_WIDTH (glyph, metrics.width); YAMAMOTO> + LGLYPH_SET_ASCENT (glyph, metrics.ascent); YAMAMOTO> + LGLYPH_SET_DESCENT (glyph, metrics.descent); YAMAMOTO> + } YAMAMOTO> } =20 =20 YAMAMOTO> But I'm not sure if it is ok to leave the code and metrics-re= lated YAMAMOTO> fields nil when encode_char returns FONT_INVALID_CODE. Handa= -san? I don=CA=BCt know either, but your patch fixes the slowdown and I=CA=BCve s= een no negative effects yet. Robert