From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: master f92520d009e 1/2: Don't pause display for pending input Date: Thu, 19 Dec 2024 14:06:03 +0100 Message-ID: References: <173460276132.331083.7195719813421951970@vcs3.savannah.gnu.org> <20241219100603.94BA7C031EB@vcs3.savannah.gnu.org> <86a5crlu4t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11278"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: acorallo@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 19 14:08:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOGGo-0002jm-R5 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Dec 2024 14:08:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOGG7-0000Nm-2X; Thu, 19 Dec 2024 08:08:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOGEC-0000IL-Jv for emacs-devel@gnu.org; Thu, 19 Dec 2024 08:06:08 -0500 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOGEB-00029y-1G; Thu, 19 Dec 2024 08:06:08 -0500 Original-Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-aa67ac42819so115487766b.0; Thu, 19 Dec 2024 05:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734613564; x=1735218364; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8PEP524wduz1k1ZWSsVfsXx39XcD42FZm0jdnHUkQD0=; b=KH1Y0H0DQB8+R5NkYUm5RtZGb+hZETHffoHUPTQmzaAsJgC6manUi73/CEc8qSbHCP k/4RLr52ipnxehIGl2FUhIQf9zgHomxm16AihhPJxK4GvcTwI4FpkbSFkY5LMCahD0GB RNZkeGm6csaF848CJpPVOmtFTzVDVjPjGQaPFsppE3WJ+m/hrFR8BFjsgKA2m2lUFCrl pPLewjFW0gTS0pq0EqJAGndir6IFqp9Bb7YQihEr3qbJSbu8tfs/FkSZs/wJ2b5DVwho vQHYvqc6P1oC3kHkggPnIgsRCQaKiKL7vENWph2bHimrsNIrL1FLGIa5J1VUZfa1sZqc T4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734613564; x=1735218364; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8PEP524wduz1k1ZWSsVfsXx39XcD42FZm0jdnHUkQD0=; b=xDg7rCpN8+x9hFlrNV5YAQOCvGtN5Ur6o1OFYliZ5Tah13mCppVJ6QXaDCI69cHQ8m gEwjk5sGKGTqCk7jj+f+qLxcEpPw+LernLxxs1nXGyl+5e9eYLSMHDuHKasEIAjfwxr/ KwxzaxTnx9eD5Rzs8CgIqEOt+kL3y0Uf2irDky4uAvuocUnHzUGULnkWzJf/sNZdyj4z OwRd66odqXMLCY/Q0p0GnR/T9a+6JzN/jGH92/i5shYQ54PKp6h5N8WR8PEKrZUAr4/g Z3WZhzPkzc9lWr70xPTJTzsz0lPyrJwSjuKrXxTrsqlNaVQ1TpVWvatxhPKa2Gcsfpfd OTzw== X-Forwarded-Encrypted: i=1; AJvYcCULgUs0r2Yu8BXZM85AKkNIQjo00A0KIGpheCaiFBkgLeWyAscesy2HiItHAF19dUHhvtKAD0zVHdUG4A==@gnu.org X-Gm-Message-State: AOJu0YzAHqX23MWCEW2Dqcpa/J/8ks8faZ6o7UUM6RFBFidahwMMon2d rybR49RvoW9z506SSaAdm0+4NbJUW8NlNC+xd+bmGs6dkDp3p0sGk8jrng== X-Gm-Gg: ASbGnctTaLDNQHMQcSWoEJx1EQ/PfBf8/gQT/S248PsxUkkv092OjP1VRpo3mR4Y529 1uhvtO5ZsRqApNxQxomL+Nz8g+8ZHZDA/bxa+GBUzSlhVZHG3Jpw5Up1w0Q8ZBnFFB3f1rg8rDH o9zFv2s1l+SsHJDjHqC/XzCJPCcPukUygUkaJ3w860FvOPFV9pY1b7DPIp+MNuJ1NNToneMi1EN /plHXS0G6x9GieJ0kz2DjnpBbtPIt3T8bqPF0xRnYnRB8K+gTVfj7015sOLWxLO+FljQThNhKby t/SGo/AMkz86Ba+7yo0G3L53yQ+6goS/H5mZTGVw0i3KQLzjPL5DDFpKrf4uEes61g== X-Google-Smtp-Source: AGHT+IEYCrEvOPFHNX56o0oI4ZdqJqwKS5QmC7lojEnf0rZqj1HnP7T8LZ0y+YWhWSHD0IyzRlcDBw== X-Received: by 2002:a17:906:329a:b0:aa6:9eac:4b8e with SMTP id a640c23a62f3a-aabf4907614mr657494566b.41.1734613564182; Thu, 19 Dec 2024 05:06:04 -0800 (PST) Original-Received: from pro2 (p200300e0b73f530035e1461ed45ebc64.dip0.t-ipconnect.de. [2003:e0:b73f:5300:35e1:461e:d45e:bc64]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e892bb7sm63374366b.43.2024.12.19.05.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 05:06:03 -0800 (PST) In-Reply-To: <86a5crlu4t.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Dec 2024 14:44:34 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326739 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: emacs-devel@gnu.org, Gerd M=C3=B6llmann >> Date: Thu, 19 Dec 2024 13:24:41 +0100 >>=20 >> Andrea Corallo writes: >>=20 >> > And with --enable-checking=3Dall --enable-check-lisp-object-type --wit= h-native-compilation=3Dyes >> > >> > =3D=3D=3D=3D=3D=3D=3D >> > In file included from dispnew.c:27: >> > In function =E2=80=98PSEUDOVECTORP=E2=80=99, >> > inlined from =E2=80=98FRAMEP=E2=80=99 at lisp.h:3343:10, >> > inlined from =E2=80=98FRAME_PARENT_FRAME=E2=80=99 at frame.h:1236:= 42, >> > inlined from =E2=80=98root_frame=E2=80=99 at dispnew.c:3340:10, >> > inlined from =E2=80=98is_in_matrix=E2=80=99 at dispnew.c:3877:24, >> > inlined from =E2=80=98is_cursor_obscured=E2=80=99 at dispnew.c:389= 8:8, >> > inlined from =E2=80=98terminal_cursor_magic=E2=80=99 at dispnew.c:= 3917:7, >> > inlined from =E2=80=98combine_updates_for_frame=E2=80=99 at dispne= w.c:3970:5: >> > lisp.h:1096:68: warning: null pointer dereference [-Wnull-dereference] >> > 1096 | && ((XUNTAG (a, Lisp_Vectorlike, union vectorlike_he= ader)->size >> > | = ^ >> > =3D=3D=3D=3D=3D=3D=3D >> > >> This one I don't see here, with clang 19. And I must admit I don't >> understand it what it is complaining about. The function root_frame >> is pretty simple: >>=20 >> struct frame * >> root_frame (struct frame *f) >> { >> while (FRAME_PARENT_FRAME (f)) >> f =3D FRAME_PARENT_FRAME (f); >> return f; >> } >>=20 >> and FRAME_PARENT_FFAME is >>=20 >> INLINE struct frame * >> FRAME_PARENT_FRAME (struct frame *f) >> { >> return NILP (f->parent_frame) ? NULL : XFRAME (f->parent_frame); >> } >>=20 >> Any idea? > > I think it wants to tell you that the argument F of FRAME_PARENT_FRAME > could be NULL. The only explanation I can find is that GCC seems this #define SELECTED_FRAME() \ ((FRAMEP (selected_frame) \ && FRAME_LIVE_P (XFRAME (selected_frame))) \ ? XFRAME (selected_frame) \ : (emacs_abort (), (struct frame *) 0)) and doesn't realize that it actually never returns NULL. That's from up the stack in is_cursor_obscured. Beats me, sorry.