bug#18683: Patch for wish-list item: 560

bug#18683: Patch for wish-list item: 560

[Matthew Leach]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hello,

Attached is a simple patch that adds {+-}90 degree rotation to image
mode as requested in [1].

Any comments welcome.

[1]: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=560

2014-10-10  Matthew Leach  <matthew@mattleach.net>

	* image-mode.el (image-mode-map): map 'r' and 'l' to rotation
	functions.
	(image-rotate-90-right): New method.
	(image-rotate-90-left):


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: img-90-rotation.patch --]
[-- Type: text/x-diff, Size: 1222 bytes --]

diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index b94162d..de75f4a 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -375,6 +375,8 @@ call."
     (define-key map "f" 'image-next-frame)
     (define-key map "b" 'image-previous-frame)
     (define-key map "n" 'image-next-file)
+    (define-key map "r" 'image-rotate-90-right)
+    (define-key map "l" 'image-rotate-90-left)
     (define-key map "p" 'image-previous-file)
     (define-key map "a+" 'image-increase-speed)
     (define-key map "a-" 'image-decrease-speed)
@@ -1106,6 +1108,16 @@ Emacs is compiled with ImageMagick support."
   (setq image-transform-rotation (float (mod rotation 360)))
   (image-toggle-display-image))
 
+(defun image-rotate-90-right ()
+  "Increase the rotation of the current image by 90 degrees."
+  (interactive)
+  (image-transform-set-rotation (+ image-transform-rotation 90)))
+
+(defun image-rotate-90-left ()
+  "Decrease the rotation of the current image by 90 degrees."
+  (interactive)
+  (image-transform-set-rotation (- image-transform-rotation 90)))
+
 (defun image-transform-reset ()
   "Display the current image with the default size and rotation.
 This command has no effect unless Emacs is compiled with

[-- Attachment #3: Type: text/plain, Size: 10 bytes --]


-- 
Matt

bug#18683: Patch for wish-list item: 560

[Glenn Morris]

Matthew Leach wrote:

> Attached is a simple patch that adds {+-}90 degree rotation to image
> mode as requested in [1].

Thanks. It would have better to send this to the existing report, rather
than creating a new one, but no worries.

Anyway, see also unfinished (as far as I know?) patch to do this and
more at:

http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00610.html
http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00264.html

bug#18683: Patch for wish-list item: 560

[Matthew Leach]

Glenn Morris <rgm@gnu.org> writes:

> Matthew Leach wrote:
>
>> Attached is a simple patch that adds {+-}90 degree rotation to image
>> mode as requested in [1].
>
> Thanks. It would have better to send this to the existing report, rather
> than creating a new one, but no worries.

Oops, sorry.

>
>
> Anyway, see also unfinished (as far as I know?) patch to do this and
> more at:
>
> http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00610.html
> http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00264.html

Ah, I didn't know there were already candidate patches written,
apologies for that.

-- 
Matt

bug#18683: Patch for wish-list item: 560

[Vitalie Spinu]

The work is here https://github.com/vitoshka/image-transform/

It's an uniform and extensible interface to internal imagemagic and
convert backends. Virtually any type of transformation could be done
from inside of emacs and multiple transformation can be stacked.

The reason I got stuck back then is that I wanted to implement
interactive cropping with the mouse. I have looked into that but
couldn't figure a good way to do so. In hindsight, I should have
finished that I had and pushed to emacs and only then think about the
rest.

Within a week or two I will have loads of free time again so I will be
finishing it for sure this time.


  Vitalie


 >>> Matthew Leach on Sat, 11 Oct 2014 10:52:08 +0100 wrote:

 > Glenn Morris <rgm@gnu.org> writes:
 >> Matthew Leach wrote:
 >> 
 >>> Attached is a simple patch that adds {+-}90 degree rotation to image
 >>> mode as requested in [1].
 >> 
 >> Thanks. It would have better to send this to the existing report, rather
 >> than creating a new one, but no worries.

 > Oops, sorry.

 >> 
 >> 
 >> Anyway, see also unfinished (as far as I know?) patch to do this and
 >> more at:
 >> 
 >> http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00610.html> http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00264.html

 > Ah, I didn't know there were already candidate patches written,
 > apologies for that.