From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Scott Wheeler Newsgroups: gmane.emacs.bugs Subject: bug#18876: 24.4; ns-antialias-text broken in 24.4 Date: Tue, 28 Oct 2014 17:27:55 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1414515981 2287 80.91.229.3 (28 Oct 2014 17:06:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 28 Oct 2014 17:06:21 +0000 (UTC) To: 18876@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 28 18:06:15 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XjADm-0005Eg-Ko for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Oct 2014 18:06:14 +0100 Original-Received: from localhost ([::1]:40482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjADm-0005KE-4k for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Oct 2014 13:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjADf-0005Js-9l for bug-gnu-emacs@gnu.org; Tue, 28 Oct 2014 13:06:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjADa-0001Ud-EK for bug-gnu-emacs@gnu.org; Tue, 28 Oct 2014 13:06:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjADa-0001UZ-B5 for bug-gnu-emacs@gnu.org; Tue, 28 Oct 2014 13:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XjADZ-0001T6-Tv for bug-gnu-emacs@gnu.org; Tue, 28 Oct 2014 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Scott Wheeler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Oct 2014 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18876 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14145159355606 (code B ref -1); Tue, 28 Oct 2014 17:06:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Oct 2014 17:05:35 +0000 Original-Received: from localhost ([127.0.0.1]:37961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XjAD7-0001SK-D0 for submit@debbugs.gnu.org; Tue, 28 Oct 2014 13:05:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56832) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xj9d6-0007bh-P0 for submit@debbugs.gnu.org; Tue, 28 Oct 2014 12:28:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj9cw-0004oJ-O0 for submit@debbugs.gnu.org; Tue, 28 Oct 2014 12:28:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj9cw-0004oC-K7 for submit@debbugs.gnu.org; Tue, 28 Oct 2014 12:28:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj9cr-0001J3-S9 for bug-gnu-emacs@gnu.org; Tue, 28 Oct 2014 12:28:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj9cn-0004me-6r for bug-gnu-emacs@gnu.org; Tue, 28 Oct 2014 12:28:05 -0400 Original-Received: from smtp88.iad3a.emailsrvr.com ([173.203.187.88]:53895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj9cm-0004mT-Ro for bug-gnu-emacs@gnu.org; Tue, 28 Oct 2014 12:28:00 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp20.relay.iad3a.emailsrvr.com (SMTP Server) with ESMTP id 291281802AC for ; Tue, 28 Oct 2014 12:28:00 -0400 (EDT) X-Virus-Scanned: OK Original-Received: by smtp20.relay.iad3a.emailsrvr.com (Authenticated sender: scott-AT-directededge.com) with ESMTPSA id 48571180366 for ; Tue, 28 Oct 2014 12:27:59 -0400 (EDT) X-Sender-Id: scott@directededge.com Original-Received: from Erik (ip5b400622.dynamic.kabel-deutschland.de [91.64.6.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:465 (trex/5.3.2); Tue, 28 Oct 2014 16:28:00 GMT X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Tue, 28 Oct 2014 13:05:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95209 --=-=-= Content-Type: text/plain In previous emacs versions evaluating the following line would disable antialiased fonts: (setq ns-antialias-text nil) That was broken in 24.4. I'm attaching a patch that both fixes the behavior and disables "synthetic bold", which looks pretty terrible with antialiasing disabled. I reported this on the emacs-devel list, but didn't receive any replies: http://lists.gnu.org/archive/html/emacs-devel/2014-10/msg00833.html --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=emacs-fix-ns-antialias-text-mac-os.patch commit c735f7e4af9375bba17e133a0d7b69a79ef604f1 Author: Scott Wheeler Date: Thu Oct 23 15:32:32 2014 +0200 Disable synthetic bold when antialiased fonts are disabled diff --git a/src/macfont.m b/src/macfont.m index ee86d9b..cb2d0be 100644 --- a/src/macfont.m +++ b/src/macfont.m @@ -2517,6 +2517,7 @@ macfont_open (struct frame * f, Lisp_Object entity, int pixel_size) && FONT_SLANT_NUMERIC (entity) == FONT_SLANT_SYNTHETIC_ITALIC) macfont_info->synthetic_italic_p = 1; if (!(sym_traits & MAC_FONT_TRAIT_BOLD) + && !NILP (ns_antialias_text) && FONT_WEIGHT_NUMERIC (entity) == FONT_WEIGHT_SYNTHETIC_BOLD) macfont_info->synthetic_bold_p = 1; if (sym_traits & MAC_FONT_TRAIT_MONO_SPACE) commit aded58804f19f286a15b46f87f7835919f9c2efc Author: Scott Wheeler Date: Thu Oct 23 03:13:14 2014 +0200 Check to see if the user has explicitly disabled anti-aliasing diff --git a/src/macfont.m b/src/macfont.m index 69bde9f..ee86d9b 100644 --- a/src/macfont.m +++ b/src/macfont.m @@ -2768,7 +2768,8 @@ macfont_draw (struct glyph_string *s, int from, int to, int x, int y, CGFloat advance_delta = 0; int y_draw = -s->ybase; int no_antialias_p = - (macfont_info->antialias == MACFONT_ANTIALIAS_OFF + (NILP (ns_antialias_text) + || macfont_info->antialias == MACFONT_ANTIALIAS_OFF || (macfont_info->antialias == MACFONT_ANTIALIAS_DEFAULT && font_size <= macfont_antialias_threshold)); --=-=-= Content-Type: text/plain In GNU Emacs 24.4.1 (x86_64-apple-darwin14.0.0, NS apple-appkit-1343.14) of 2014-10-25 on Erik Windowing system distributor `Apple', version 10.3.1343 Configured using: `configure --prefix=/usr/local/Cellar/emacs/24.4 --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/24.4/share/info/emacs --without-dbus --without-gnutls --with-ns --disable-ns-self-contained' Important settings: value of $LC_ALL: en_US.UTF-8 value of $LC_COLLATE: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: global-git-gutter+-mode: t git-gutter+-mode: t shell-dirtrack-mode: t projectile-global-mode: t projectile-mode: t yas-global-mode: t yas-minor-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-mode: t global-auto-complete-mode: t auto-complete-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: t t @ g r u n g e - n o u v e a u . n e t I SPC l i k e SPC c h e e s e D o SPC y o u SPC w a n t SPC t o SPC t o u c h m SPC m y SPC m o n k e y ? - S c o t t C-c C-c s-b b s-z C-x b m a i l s-k s-b p e r s-p p e r s o n a l C-x C-f p e r s o n s-v C-a s c o t t @ d i r e c t d i r e c t e d e d g e . c o m C-x C-s C-a s-x s-v C-x C-s C-x C-s s-a x e v a l b u f x m a i l s c o t t @ g r u n g e - n o u v e a u n . n e t t e s t C-a t e s t C-c C-c s-k s-k x e m b u g e m a c b u r e p o r t Recent messages: Sending... Opening TLS connection to `secure.emailsrvr.com'... Opening TLS connection with `gnutls-cli --insecure -p 465 secure.emailsrvr.com'...failed Opening TLS connection with `gnutls-cli --insecure -p 465 secure.emailsrvr.com --protocols ssl3'...failed Opening TLS connection with `openssl s_client -connect secure.emailsrvr.com:465 -no_ssl2 -ign_eof'...done Opening TLS connection to `secure.emailsrvr.com'...done Sending email Sending email done Sending...done Making completion list... [2 times] Load-path shadows: /Users/scott/.emacs.d/.cask/24.4.1/elpa/magit-90141016/magit hides /usr/local/share/emacs/site-lisp/magit Features: (shadow sort emacsbug network-stream starttls tls mail-extr smtpmail sendmail vc-git flymake git-gutter+ git-commit-mode server log-edit easy-mmode message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log tramp tramp-compat auth-source eieio byte-opt bytecomp byte-compile cconv eieio-core gnus-util mm-util mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete format-spec projectile ibuf-ext ibuffer pkg-info find-func grep compile comint ansi-color ring grizzl grizzl-read grizzl-core highlight-indentation yasnippet help-mode cl smartparens-ruby smartparens-config smartparens thingatpt rvm auto-complete-config auto-complete popup maxframe edmacro kmacro kde-emacs kde-emacs-bindings dirvars kde-emacs-utils imenu klaralv kdab-qstring kde-emacs-general sourcepair kde-emacs-core kde-emacs-compat kde-emacs-vars cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs pallet advice cask help-fns cl-macs gv cask-bootstrap package-build json lisp-mnt shut-up epl git commander cl-loaddefs cl-lib f dash s ucs-normalize package epg-config time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 365198 51386) (symbols 48 33333 33) (miscs 40 62 418) (strings 32 59615 23186) (string-bytes 1 1730922) (vectors 16 49616) (vector-slots 8 923815 19812) (floats 8 427 674) (intervals 56 762 15) (buffers 960 15)) --=-=-=--