From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Mankoff Newsgroups: gmane.emacs.bugs Subject: bug#19145: 24.4; prettify-symbols-mode inconsistent behavior Date: Fri, 21 Nov 2014 14:22:53 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1416597869 8542 80.91.229.3 (21 Nov 2014 19:24:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2014 19:24:29 +0000 (UTC) Cc: 19145@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 21 20:24:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xrtob-0003A3-Oz for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 20:24:21 +0100 Original-Received: from localhost ([::1]:42164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrtob-00034m-5a for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 14:24:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrtoQ-00034Q-HS for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 14:24:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrtoI-0005jI-Nm for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 14:24:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrtoI-0005j9-LA for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 14:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XrtoI-0004lV-A7 for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 14:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Mankoff Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Nov 2014 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19145 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19145-submit@debbugs.gnu.org id=B19145.141659778218183 (code B ref 19145); Fri, 21 Nov 2014 19:24:02 +0000 Original-Received: (at 19145) by debbugs.gnu.org; 21 Nov 2014 19:23:02 +0000 Original-Received: from localhost ([127.0.0.1]:41208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrtnJ-0004j6-R1 for submit@debbugs.gnu.org; Fri, 21 Nov 2014 14:23:02 -0500 Original-Received: from mail-qg0-f43.google.com ([209.85.192.43]:45280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrtnH-0004ir-S2 for 19145@debbugs.gnu.org; Fri, 21 Nov 2014 14:23:00 -0500 Original-Received: by mail-qg0-f43.google.com with SMTP id q108so4186625qgd.16 for <19145@debbugs.gnu.org>; Fri, 21 Nov 2014 11:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type:content-transfer-encoding; bh=eoPslBTlDSlA4q7mDP8d4cMQg/6e2yjEBogRIk4AHqs=; b=T2WSz7XMCQT5f43i53GuO7o9jPWSJ8wL4aNFVTtyuG5LH49RT0KUYQzIc2vw64/s8D +B0i3MPMq+/fGVWOL00qX1JHS4R75CBouMvPbW8NWnptSZO2zsg0ynakgxQ3pqAgY1f9 CVgsf1uNWd42chmOVgUsofeeL+zD9lxjeQcPfXd3YkPpffQ79WeBlNbZBlaFZJ/BVIp1 vXXiwysd0E89DVGYNlw/z+/YALCA+6ztpMczn4qbow8d9QbOGfbKzgRPil+s0HiG61bc gvlyf+nU+jfVlMlUZpMWey/IUIf70YY9jxalbCG0r2ozibbFdqJDzjr9ewdfpk2VOBL/ 1mgA== X-Received: by 10.224.45.65 with SMTP id d1mr8824853qaf.43.1416597779177; Fri, 21 Nov 2014 11:22:59 -0800 (PST) Original-Received: from gorgonzola.whoi.edu (c-71-58-77-153.hsd1.pa.comcast.net. [71.58.77.153]) by mx.google.com with ESMTPSA id b17sm3677659qah.35.2014.11.21.11.22.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Nov 2014 11:22:58 -0800 (PST) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96400 * On 2014-11-21 at 13:15, Stefan Monnier wrote: >> Some symbols are sometimes not being treated correctly depending on >> what characters follow. For example, I have the following setup for >> coding Python: > >> (prettify-symbols-mode t) >> (global-prettify-symbols-mode t) >> (add-hook 'python-mode-hook >> (lambda () >> (push '("**2" . ?²) prettify-symbols-alist) >> (push '("_x" . ?ᵪ) prettify-symbols-alist) >> (push '("delta" . ?δ) prettify-symbols-alist))) > > Can you try the patch below and see if it does what you want? > > > diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el > index 5037020..475dd32 100644 > --- a/lisp/progmodes/prog-mode.el > +++ b/lisp/progmodes/prog-mode.el > @@ -73,11 +73,13 @@ Regexp match data 0 points to the chars." > ;; Check that the chars should really be composed into a symbol. > (let* ((start (match-beginning 0)) > (end (match-end 0)) > - (syntaxes (if (eq (char-syntax (char-after start)) ?w) > - '(?w ?_) '(?. ?\\))) > + (syntax-beg (if (eq (char-syntax (char-after start)) ?w) > + '(?w ?_) '(?. ?\\))) > + (syntax-end (if (eq (char-syntax (char-before end)) ?w) > + '(?w ?_) '(?. ?\\))) > match) > - (if (or (memq (char-syntax (or (char-before start) ?\s)) syntaxes) > - (memq (char-syntax (or (char-after end) ?\s)) syntaxes) > + (if (or (memq (char-syntax (or (char-before start) ?\s)) syntax-beg) > + (memq (char-syntax (or (char-after end) ?\s)) syntax-end) > ;; syntax-ppss could modify the match data (bug#14595) > (progn (setq match (match-string 0)) (nth 8 (syntax-ppss)))) > ;; No composition for you. Let's actually remove any composition Much improved! Of my examples, only one case no longer works which is delta_x or foo_x_x_x_x, for example. -k.