From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#19449: 25.0.50; `auto-revert-tail-mode' tries to revert remote files even if `auto-revert-remote-files' is nil Date: Fri, 26 Dec 2014 23:24:43 +0300 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1419625518 1989 80.91.229.3 (26 Dec 2014 20:25:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Dec 2014 20:25:18 +0000 (UTC) To: 19449@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 26 21:25:12 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y4bRe-0004db-PR for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Dec 2014 21:25:11 +0100 Original-Received: from localhost ([::1]:54312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRd-00066W-Ts for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Dec 2014 15:25:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRa-00064w-GJ for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:25:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4bRX-0004tO-9k for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:25:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRX-0004sx-6T for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y4bRW-0004uy-NT for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:25:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Dec 2014 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19449 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.141962549818889 (code B ref -1); Fri, 26 Dec 2014 20:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Dec 2014 20:24:58 +0000 Original-Received: from localhost ([127.0.0.1]:58424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4bRR-0004ub-IE for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4bRP-0004uT-WF for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4bRO-0004jv-ML for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:55 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:55306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRO-0004jq-JP for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRN-00062h-JE for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:24:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4bRK-0004jE-Bn for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:24:53 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRK-0004in-8P for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:24:50 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3048020579 for ; Fri, 26 Dec 2014 15:24:48 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 26 Dec 2014 15:24:48 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type; s=mesmtp; bh=692cvaRKH/PrhL488myLeTSgJxA=; b=XlOz T1qRlleiFp43uC6q0BcaWkmxTR+kzEAc2bbm2L/w7lc/fElYjMoFiN/r8Z7GayJp 39bU1iDM7GC4rh6zEnbMOjRNXBd9WXIU72xijilB2zS0E25FKGEbPzzvJpY6d/Ur 9T5YCH6SC3f6Yg3J0Fi+X8wrlQsGb34r7w4o7p8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type; s=smtpout; bh=692cvaRKH/P rhL488myLeTSgJxA=; b=KmaMBKOxVL6yfR62TL40TXuXMaErNwND0Y7i+ydX/QH HvsykpcNYAXe4wVOa70g/X8TYD+WbJ9HOYKkCWn7eN0TT7PhgKteO7gnSkFB5qpN nSths0N+yptHJdwKyWGkSjqBgmA58CuEHLNWiIzSCn0By5TwkpcJyjkV7AwY0QOo = X-Sasl-enc: NiHo0h6NvYPO8qcN9yVgbRSgCp+hg4gvJhm/8jhuONf/ 1419625487 Original-Received: from fgunbin.local (unknown [94.25.218.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 6A63AC00283 for ; Fri, 26 Dec 2014 15:24:47 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97740 Archived-At: Below is the suggested patch. Analysis: When the `auto-revert-tail-mode' is called it temporarily enables auto-revert-mode: (or auto-revert-mode (let ((auto-revert-tail-mode t)) (auto-revert-mode 1))) `auto-revert-mode' then calls `auto-revert-buffers' which in turn calls `auto-revert-handler' (fixed by the patch). Then, this code yielded t: + (and (or auto-revert-mode + global-auto-revert-non-file-buffers) which resulted as `revert' set to t. In the end, `(auto-revert-tail-handler size)' was evaluted with nil size. This produces error: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) auto-revert-tail-handler(nil) Fix: In `revert' value calculation, `or' is changed to `if'. The "then" clause applies to file-visiting buffers, this is where the result of `file-remote-p' is analyzed. The "else" clause case applies to non-file buffers. Ok to apply? Filipp diff --git a/lisp/autorevert.el b/lisp/autorevert.el index f1074e2..514dc2b 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -589,8 +589,8 @@ This is an internal function used by Auto-Revert Mode." ;; the values. (remote-file-name-inhibit-cache t) (revert - (or (and buffer-file-name - (or auto-revert-remote-files + (if buffer-file-name + (and (or auto-revert-remote-files (not (file-remote-p buffer-file-name))) (or (not auto-revert-use-notify) auto-revert-notify-modified-p) @@ -603,11 +603,11 @@ This is an internal function used by Auto-Revert Mode." (funcall (or buffer-stale-function #'buffer-stale--default-function) t))) - (and (or auto-revert-mode - global-auto-revert-non-file-buffers) - (funcall (or buffer-stale-function - #'buffer-stale--default-function) - t)))) + (and (or auto-revert-mode + global-auto-revert-non-file-buffers) + (funcall (or buffer-stale-function + #'buffer-stale--default-function) + t)))) eob eoblist) (setq auto-revert-notify-modified-p nil) (when revert