From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: A cleaning-up patch for parse-time.el Date: Sat, 19 Mar 2016 16:21:15 -0700 Message-ID: References: <87a8lveya2.fsf@mbork.pl> <878u1egb4y.fsf@mbork.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458429708 23279 80.91.229.3 (19 Mar 2016 23:21:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Mar 2016 23:21:48 +0000 (UTC) Cc: Emacs Developers To: Marcin Borkowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 20 00:21:41 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahQBg-00086N-Bz for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 00:21:40 +0100 Original-Received: from localhost ([::1]:50867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahQBf-0004hN-RI for ged-emacs-devel@m.gmane.org; Sat, 19 Mar 2016 19:21:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahQBQ-0004cU-9S for emacs-devel@gnu.org; Sat, 19 Mar 2016 19:21:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahQBN-0003my-2a for emacs-devel@gnu.org; Sat, 19 Mar 2016 19:21:24 -0400 Original-Received: from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:34933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahQBM-0003mF-S9 for emacs-devel@gnu.org; Sat, 19 Mar 2016 19:21:21 -0400 Original-Received: by mail-pf0-x22d.google.com with SMTP id n5so216794791pfn.2 for ; Sat, 19 Mar 2016 16:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version; bh=GB+aUdmHux4RPecIhkdLlPg9NBLfCjhXpHV+BAf7C50=; b=s8Lq9U15JVDBpXNxaGpxqbPmiOt6YbQ48YSjvrciEZIIlee66aKYukGFUIXStJuWJq idNpe/L3SpIyz8ZfSV21x49JzdV3/3g6nNpT5p6N9L6hOsBC/UoOXy167rvmECitTOH1 rZLoMrS3CogTD18WZGjPWUnXC5kVQwG2GweqC1ON17UxY4fCsFpAlLJRN9db0oRKFdZU BD6OZNhkvwCa8+x6W7rmtqARPkdh8cY5Ic2fO+3kY+KNThetD6jp676tGW33iYtLNYET /vXCMKGAdLooYMR5jnDQkClgjn8UjutWctn98Y6nEH59sebYdjvgCoJT+N0WS1C8svuk 9BBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mail-followup-to:mime-version; bh=GB+aUdmHux4RPecIhkdLlPg9NBLfCjhXpHV+BAf7C50=; b=NbYU3Dapq6NkG/PpTQonX5zWs7xwmG7h20696QJ8nFX2uGLWftVNPpDhc4/qC0FdAy 2ojw0eUNRhzk1Ue+z+e3f1vcUPDCag3BArjdOfBsei4hn0xnSu6PtS4pqEiVidok4shN y9KBr1FRNmf5K57c3NgVgnBZYvTVYsCEZxXYXs5+P/+BxvqwZlybV7jOk1JOrHdGrZ6m V9aB/S2xmDcX4rJ1BM3O1sizAa0g/75RoxvruxiPreA5Fzinjuto6+8o9tKOoEKfCLSU FJ0mIM0b3auuAaM2m6cdCT7G/WBe+PHibJUk6lDp0ISOKMY77Twni429eVWDTUSu7FRs /WDQ== X-Gm-Message-State: AD7BkJJuhtPNkrPQRUkjNSRFfjyJ8nGGih8MKejIeFXkzIZESR3d99aondI1b60DyTQyFA== X-Received: by 10.98.14.68 with SMTP id w65mr34370878pfi.144.1458429680198; Sat, 19 Mar 2016 16:21:20 -0700 (PDT) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id r203sm30265658pfr.22.2016.03.19.16.21.19 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 19 Mar 2016 16:21:19 -0700 (PDT) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id E7763138D1E89; Sat, 19 Mar 2016 16:21:18 -0700 (PDT) In-Reply-To: <878u1egb4y.fsf@mbork.pl> (Marcin Borkowski's message of "Sat, 19 Mar 2016 08:49:49 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.92 (darwin) Mail-Followup-To: Marcin Borkowski , Emacs Developers X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201910 Archived-At: >>>>> Marcin Borkowski writes: > I think that the changes in this particular case are so cosmetic that > testing them would be overkill. (Of course, I meant it to be applied to > master!) OTOH, I expect to submit more complicated things in the future, so > I'll have to learn how to write tests for Emacs code, too. Is there any > documented policy on that or should I just look at the tests already there? > (I can't see anything about testing in admin/notes.) Do I use ERT for > testing? Where do I put tests? Please search for "test" in the CONTRIBUTE file within the repository you checked out. It should lay out all the details you need. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2