bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil.

[Keith David Bershatsky <esq@lawlist.com>]

In all four (4) cases tested this evening with the current emacs-25 branch (April 8, 2016), the `splash.svg` image is used and it has the same dimensions in all four situations tested:  (41.625 . 15.533333333333333).

I have not experimented with removing svg support while trying to maintain support for other possible image types -- e.g., splash.pbm, splash.png or splash.xpm.

Emacs 25:  --with-x --with-x-toolkit=no
  (frame-height) = 36
  splash.svg:  (41.625 . 15.533333333333333)

Emacs 25:  --with-x --with-x-toolkit=gtk3
  (frame-height) = 36
  splash.svg:  (41.625 . 15.533333333333333)

Emacs 25:  --with-x --with-x-toolkit=motif
  (frame-height) = 35
  splash.svg:  (41.625 . 15.533333333333333)

Emacs 25:  --with-x --with-x-toolkit=athena
  (frame-height) = 35
  splash.svg:  (41.625 . 15.533333333333333)

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Fri, 08 Apr 2016 11:30:28 +0300,
Eli Zaretskii wrote:
> 
>  X11: `use-fancy-splash-screens-p` erroneously returns nil.
> 
> > Date:  Sat, 26 Mar 2016 21:04:27 -0700
> > From:  Keith David Bershatsky <esq@lawlist.com>
> > Cc:  23074@debbugs.gnu.org
> > 
> > Here are four (4) X11 configuration options (built on an OSX box) and corresponding frame-height values.
> > 
> > None of the four (4) options tested display the Emacs logo splash image.
> > 
> > 
> > Emacs 25:  --with-x [no toolkit configuration] = the default is `gtk3`
> >   (frame-height) = 36
> > 
> > Emacs 25:  --with-x --with-x-toolkit=athena
> >   (frame-height) = 35
> > 
> > Emacs 25:  --with-x --with-x-toolkit=motif
> >   (frame-height) = 35
> > 
> > Emacs 25:  --with-x --with-x-toolkit=no
> >   (frame-height) = 36
> 
> I asked what does image-size return for the splash image in each case.
> Could you please provide that information?  TIA.