From: Nick Helm <nick@tenpoint.co.nz>
To: Alan Third <alan@idiocy.org>
Cc: George Plymale II <georgedp@orbitalimpact.com>,
monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Should this package be included into the NS port?
Date: Wed, 23 May 2018 16:55:50 +1200 [thread overview]
Message-ID: <m24lizhsx5.fsf@tenpoint.co.nz> (raw)
In-Reply-To: 20180519103329.GB31853@breton.holly.idiocy.org
On Sat, 19 May 2018 at 22:33:29 +1200, Alan Third wrote:
> On Sat, May 19, 2018 at 04:42:54PM +1200, Nick Helm wrote:
>>
>> This is interesting. I think we could tweak the EmacsMenu side of things
>> to do this, even with the current code. We'd want to make sure to
>> include some kind of new frame command somewhere.
>>
>> These menus are derived dynamically from Lisp though, and it might be
>> difficult to convince it to provide valid entries when no frame is
>> selected.
>
> I’m not sure if the ‘Emacs’ menu is derived from lisp. If you turn off
> menus completely it still exists.
Sorry, I meant to say the mainMenu, which holds all the Lisp menu stuff.
Yes, the menu named 'Emacs' (the appMenu) is defined in nsterm.m and
doesn't change as far as I know.
>> One way around that might be to create a new menu containing
>> static NSMenu versions of File and Help, much like we do for the appMenu
>> now. When no frame is selected and there are no Lisp menu entries, we
>> switch mainMenu to this new menu. When a frame is created, we switch
>> back.
>
> Perhaps we could modify ns_update_menubar to handle the case where
> there’s no frame?
Maybe, I'm not sure. At the moment, as soon as ns_update_menubar sees
that it's not acting on the selected frame it gives up. I tried a quick
hack that sets f (the frame) to nil, bypasses the Lisp menu update code
and switches in a different static menu, but I couldn't get it to work
at all.
BTW, if you toggle the menu display off with (menu-bar-mode -1), you can
switch between frames/windows without the Lisp menus updating. This
prevents set_frame_menubar (and ns_update_menubar) from being called at
all.
As soon as you click in the menu-bar though, x_activate_menubar is
called, which does an ns_update_menubar, which inserts the menus for the
selected frame/window. Not sure why this happens, maybe Lisp assumes the
menu-bar is un-clickable if it's not supposed to be displayed? (mac
always shows a menu-bar, however)
I only mention this because I wonder if there might be a way to handle
the no-frame case with set_frame_menubar and x_activate_menubar, and
avoid messing with ns_update_menubar at all?
next prev parent reply other threads:[~2018-05-23 4:55 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 5:19 Should this package be included into the NS port? George Plymale II
2018-05-15 18:25 ` Stefan Monnier
2018-05-15 18:36 ` Alan Third
2018-05-16 2:48 ` George Plymale II
2018-05-18 19:36 ` Alan Third
2018-05-18 21:21 ` George Plymale II
2018-05-19 4:57 ` Nick Helm
2018-05-19 15:49 ` George Plymale II
2018-05-23 5:22 ` Nick Helm
2018-05-23 19:29 ` George Plymale II
2018-05-19 9:50 ` Alan Third
2018-05-19 16:06 ` George Plymale II
2018-05-19 18:33 ` Stefan Monnier
2018-05-22 1:42 ` George Plymale II
2018-05-22 1:48 ` Van L
2018-05-22 19:04 ` Alan Third
2018-05-23 2:30 ` Off Topic (was: Should this package be included into the NS port?) Van L
2018-05-23 20:43 ` Alan Third
2018-05-24 1:27 ` emacs-26.1-rc1: ./configure (was: Off Topic) Van L
2018-05-24 8:55 ` emacs-26.1-rc1: ./configure Robert Pluim
2018-05-24 10:51 ` Van L
2018-05-24 11:51 ` Robert Pluim
2018-05-24 11:57 ` Van L
2018-05-24 23:47 ` Van L
2018-05-22 19:15 ` Should this package be included into the NS port? Alan Third
2018-05-22 20:09 ` George Plymale II
2018-05-19 4:42 ` Nick Helm
2018-05-19 10:33 ` Alan Third
2018-05-19 11:51 ` Philipp Stephani
2018-05-19 16:52 ` George Plymale II
2018-05-23 4:55 ` Nick Helm [this message]
2018-05-23 5:11 ` Nick Helm
2018-05-23 15:26 ` Eli Zaretskii
2018-05-23 16:37 ` Stefan Monnier
2018-05-23 17:23 ` Eli Zaretskii
2018-05-23 21:21 ` Alan Third
2018-05-24 16:37 ` Eli Zaretskii
2018-05-24 17:46 ` Philipp Stephani
2018-05-24 17:51 ` Philipp Stephani
2018-05-24 18:14 ` Eli Zaretskii
2018-05-16 2:44 ` George Plymale II
2018-05-17 22:13 ` George Plymale II
2018-05-18 18:50 ` Alan Third
2018-05-18 20:40 ` George Plymale II
2018-05-19 8:31 ` Michael Albinus
2018-05-19 4:29 ` Nick Helm
2018-05-19 15:38 ` George Plymale II
2018-05-29 21:29 ` George Plymale II
2018-05-29 21:42 ` Alan Third
2018-05-29 23:40 ` George Plymale II
2018-05-31 20:40 ` Alan Third
2018-06-01 1:58 ` Stefan Monnier
2018-06-02 18:31 ` George Plymale II
2018-06-02 19:39 ` Stefan Monnier
2018-06-02 20:11 ` Alan Third
2018-06-03 2:25 ` Stefan Monnier
2018-06-02 18:26 ` George Plymale II
2018-06-02 16:45 ` Ryan Thompson
2018-06-02 17:22 ` Stefan Monnier
2018-06-02 18:56 ` George Plymale II
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24lizhsx5.fsf@tenpoint.co.nz \
--to=nick@tenpoint.co.nz \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=georgedp@orbitalimpact.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.