From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Identifying the face between STRETCH and right fringe. Date: Tue, 27 Nov 2018 12:02:51 +0100 Message-ID: References: <83h8gbis2d.fsf@gnu.org> <83zhu0f6tt.fsf@gnu.org> <83sgzrgb1f.fsf@gnu.org> <83r2fbg5bq.fsf@gnu.org> <83lg5jfs9o.fsf@gnu.org> <83a7luhnid.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1543316463 761 195.159.176.226 (27 Nov 2018 11:01:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Nov 2018 11:01:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 27 12:00:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRb6w-0008V1-LF for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 12:00:58 +0100 Original-Received: from localhost ([::1]:41388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRb92-0000d8-Tr for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 06:03:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRb8u-0000cp-Hh for emacs-devel@gnu.org; Tue, 27 Nov 2018 06:03:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRb8p-0000YB-2R for emacs-devel@gnu.org; Tue, 27 Nov 2018 06:03:00 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:42689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRb8o-0000XT-Sm; Tue, 27 Nov 2018 06:02:55 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id q18so22196493wrx.9; Tue, 27 Nov 2018 03:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=M/HB48W6RvL0aNBKEb2A8cmdGGswt64f1j97yKkQWh8=; b=bY+K9SDENZYAMZXq9qtXqW5ofVVBjmCq6i8AsZYTbKKHMHC9L58sdBggaK5Xukzcil W+ZH3as4BjDvNmNVb0JHq3JiKIeaHcWNEHRkQWnVoSFi5LBmK5yWkVevi54cE85nlOue jwSTO1DrYNey3EwbbnYKZUXZwx/ie98TqKWfPDmUSGM5gL5BdLD0XM9Ky5qA31RVWzi2 0Cc4VLCm8cUgcvG8otQfwhKEH/RUVANMX4S8iHdyFIxrXyKVmvdO87Y/m7ARVCkw9BS5 Vk7c0935Fq+Wk0QgTMoEba9ukZras4FNOLhMRZukxHpd+Hfk/872LAjAPdIDIr0FbD49 tsTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=M/HB48W6RvL0aNBKEb2A8cmdGGswt64f1j97yKkQWh8=; b=neCF/thqs6rU5MN0FtI1VtuAVbkYfoI6dTv07pBxXJKZkQh12X2jloajEYFAS5Fi21 ge1AHwFX6QnXPfRATq1Fe3bwFa3zqjgtkDdIOAFoRD+aFJA0NpYA5hMuk6BP2KyC621l N1jlAo/AXFHHWdRo1kuk+GGsZ9XU4Iy0LsbpJAjR+dpu2M0vRdQ9DRXf/PbDPKPKT1Pm K9RGInMX/qJ93I3E3A1baP1XNaqLYLW/TYUYrgfU+E/c/BV+3JH637xYyQIyYGUR1UYp WWC/OO8/XscbQWM12ZMlAFuxeDGsL2B6jvTSJQmbceTgktcTQap/o1F/H3QVpPEOKjBX wuhA== X-Gm-Message-State: AA+aEWahjdPrl/zVMohlePa5AHgvj53axZ8ZwZBGNkTxzDppKnOAe4uG zNFaEnPfgH9mzmexvhrL0r5wnBEf X-Google-Smtp-Source: AFSGD/VugYjBFnN4iwha57u2O7EZNT248+UvQt2ChA3kSyRQpVwehwWGDHHvDevw6RiZBQOOBHbn6Q== X-Received: by 2002:a5d:6105:: with SMTP id v5mr26619358wrt.63.1543316573193; Tue, 27 Nov 2018 03:02:53 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id d5sm2642994wrx.22.2018.11.27.03.02.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 03:02:52 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83a7luhnid.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Nov 2018 11:34:50 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231440 Archived-At: Eli Zaretskii writes: > > On a GUI frame, extend_face_to_end_of_line is supposed to return > almost immediately, here: > > if (FRAME_WINDOW_P (f) > && MATRIX_ROW_DISPLAYS_TEXT_P (it->glyph_row) > && face->box =3D=3D FACE_NO_BOX > && face->background =3D=3D FRAME_BACKGROUND_PIXEL (f) > #ifdef HAVE_WINDOW_SYSTEM > && !face->stipple > #endif > && !it->glyph_row->reversed_p) > return; <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< > When we get here, face->background =3D=3D 1, and FRAME_BACKGROUND_PIXEL =3D= =3D 0xfffeffff Looking through nsfns.m, the problem becomes obvious: the NS port uses indices into a color table to specify the background colour of faces, and FRAME_BACKGROUND_PIXEL is an RGBA value. I=CA=BCm not sure how best to fix this. There=CA=BCs f->output_data.ns->background_color, but that would still need to be converted to RGBA. Robert