all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 35389@debbugs.gnu.org
Subject: bug#35389: 27.0.50; [PATCH] Emacs on macOS sets mouse-wheel variables directly
Date: Fri, 10 May 2019 17:29:46 +0200	[thread overview]
Message-ID: <m24l6249at.fsf@gmail.com> (raw)
In-Reply-To: <m2a7ght0h8.fsf@gmail.com> (Robert Pluim's message of "Tue, 23 Apr 2019 13:38:59 +0200")

>>>>> On Tue, 23 Apr 2019 13:38:59 +0200, Robert Pluim <rpluim@gmail.com> said:

>>>>> On Tue, 23 Apr 2019 07:17:24 -0400, Noam Postavsky <npostavs@gmail.com> said:
    Noam> I think it should work to change customized-value to
    Noam> standard-value.

    Robert> That works, thanks. Iʼll run with for a while then push to
    Robert> master.

Having thought about this some more, does it make more sense to put
the value for macOS in the defcustoms for mouse-wheel-scroll-amount
and mouse-wheel-progressive-speed instead? (and discarding the test for
macOS < 10.7 at the same time) i.e.

diff --git a/lisp/mwheel.el b/lisp/mwheel.el
index 23f491db0f..4bed5b981d 100644
--- a/lisp/mwheel.el
+++ b/lisp/mwheel.el
@@ -85,7 +85,10 @@ mouse-wheel-inhibit-click-time
   :group 'mouse
   :type 'number)
 
-(defcustom mouse-wheel-scroll-amount '(5 ((shift) . 1) ((control) . nil))
+(defcustom mouse-wheel-scroll-amount
+  (if (featurep 'cocoa)
+      '(1 ((shift) . 5) ((control)))
+    '(5 ((shift) . 1) ((control) . nil)))
   "Amount to scroll windows by when spinning the mouse wheel.
 This is an alist mapping the modifier key to the amount to scroll when
 the wheel is moved with the modifier key depressed.
@@ -119,15 +122,20 @@ mouse-wheel-scroll-amount
                     (const :tag "Full screen" :value nil)
                     (integer :tag "Specific # of lines")
                     (float :tag "Fraction of window")))))
-  :set 'mouse-wheel-change-button)
+  :set 'mouse-wheel-change-button
+  :version "27.1")
 
-(defcustom mouse-wheel-progressive-speed t
+(defcustom mouse-wheel-progressive-speed
+  (if (featurep 'cocoa)
+      nil
+    t)
   "If non-nil, the faster the user moves the wheel, the faster the scrolling.
 Note that this has no effect when `mouse-wheel-scroll-amount' specifies
 a \"near full screen\" scroll or when the mouse wheel sends key instead
 of button events."
   :group 'mouse
-  :type 'boolean)
+  :type 'boolean
+  :version "27.1")
 
 (defcustom mouse-wheel-follow-mouse t
   "Whether the mouse wheel should scroll the window that the mouse is over.





  reply	other threads:[~2019-05-10 15:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23  9:47 bug#35389: 27.0.50; [PATCH] Emacs on macOS sets mouse-wheel variables directly Robert Pluim
2019-04-23 11:17 ` Noam Postavsky
2019-04-23 11:38   ` Robert Pluim
2019-05-10 15:29     ` Robert Pluim [this message]
2019-05-10 19:53       ` Eli Zaretskii
2019-05-10 21:25         ` Alan Third
2019-05-11  6:12           ` Eli Zaretskii
2019-05-11  9:54             ` Robert Pluim
2019-05-11 10:58               ` Eli Zaretskii
2019-05-11 22:50                 ` Alan Third
2019-05-12  4:58                   ` Eli Zaretskii
2019-05-12 11:05                     ` Alan Third
2019-05-12 14:36                       ` Eli Zaretskii
2019-05-19 12:41                         ` Alan Third
2019-05-12 23:29                       ` Tak Kunihiro
2019-05-13 14:26                         ` Eli Zaretskii
2019-05-16  9:00                           ` Tak Kunihiro
2019-05-16 13:55                             ` Eli Zaretskii
2019-05-16 23:24                               ` Tak Kunihiro
2019-05-17  5:39                                 ` Eli Zaretskii
2019-05-18  8:50                                   ` Tak Kunihiro
2019-05-18  9:16                                     ` Eli Zaretskii
2019-05-19 12:32                                       ` Alan Third
2019-05-22  6:22                                         ` Eli Zaretskii
2019-05-23  4:24                                           ` Tak Kunihiro
2019-05-23  4:55                                             ` Eli Zaretskii
2019-06-06  2:21                                           ` Tak Kunihiro
2019-06-07 18:31                                             ` Alan Third
2020-08-10 11:32                                               ` Lars Ingebrigtsen
2020-08-10 13:04                                                 ` Robert Pluim
2020-08-10 13:19                                                   ` Lars Ingebrigtsen
2019-05-11 22:53               ` Alan Third
2019-05-11 23:06             ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24l6249at.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=35389@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.