From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus Date: Tue, 31 Mar 2020 13:09:14 +0200 Message-ID: References: <86bloi1zrj.fsf@csic.es> <83lfnm8b30.fsf@gnu.org> <83ftdt9b1d.fsf@gnu.org> <86sght3h1s.fsf@csic.es> <834ku89anf.fsf@gnu.org> <87a740ub2r.fsf@gnus.org> <83tv287s9j.fsf@gnu.org> <874ku7txho.fsf@gnus.org> <83imin5l0w.fsf@gnu.org> <87blocrgtb.fsf@igel.home> <877dz0rf2v.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="40672"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Lars Ingebrigtsen , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 31 13:10:07 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJEmU-000ARa-C6 for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 13:10:06 +0200 Original-Received: from localhost ([::1]:36021 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJEmT-0000QW-Ep for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 07:10:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55059) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJElo-0008Gf-Pd for emacs-devel@gnu.org; Tue, 31 Mar 2020 07:09:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJElj-0003FK-B7 for emacs-devel@gnu.org; Tue, 31 Mar 2020 07:09:20 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:51624) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJEli-0003EO-56; Tue, 31 Mar 2020 07:09:19 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id z7so21646wmk.1; Tue, 31 Mar 2020 04:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=y+A4UAtJ+aweH1FwOuqJX3yaGO5X4yin/PzJJOFIGB0=; b=ivnkebxZr75RCox/dZxfF7NxEHvYf1q1qtfYc1GP6L2btFGS43wZ6pkHBzIMJ8r34g O8vzP3aKtDvn3wWK4cW7hpGXH7SsvYqB4mDyDh6uJHbqBsJYA17S7k4RYm49Kf/zpXcq meMi7WCvbRtgyGUVfOTEk7HYA24X2tkh2AAQ+cDh2MxqoEujXRnN8Br1qbQW7tl/19eE +nUr/dSop6nY1gYSQ0vPXc8kh3FIYreAIrQq98/DNEiRSK+afJ7HyUhgVvCOC/PyqaV4 e4HZa2m7rWIsyQoVEQKNe+EKqQtdh6xkc+L26M8/homWuOd+d5PRiaQV1nFqd9PE0PRn WObw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=y+A4UAtJ+aweH1FwOuqJX3yaGO5X4yin/PzJJOFIGB0=; b=hL/sNr0FA+hVHy1LNckjaN3dsSwNcJcVQiapISl2NmC23dPLkCqg//4jOpL3qQexYK bC4TuqwqHr9DPl7BQPuc4sV9oZ4pFmpoCIDOtgsfyzvPB4yn5gMCtAbxZSZS3KNHJJN+ RrGTXZtTIQ1VJPibVgedpAaIwXfUt27+aw6jCPVwBNyLWEkbfxvey0KUeaGgNzMJHk/Y CpM+ym0wvzvoNvj06e92+5jFWL8yGhXRhkM4/oH4EltM6URMn96Mjrt/lw+EsHzvB3DH RVUM0tl4iyTmtH9W6dARaYEN5iabx2kAWDSKMvoe6ERBTe9VGtWBBJTvqiHkYjVb96g2 puag== X-Gm-Message-State: ANhLgQ0gKdMVxEDfN/DoqRgZIP+vCvhtQnWVwXr1hpArHFDpp7ancJMS Dq/CnMI0Kxs9gKKYX3T1MUxcq76s X-Google-Smtp-Source: ADFU+vtVAFv9+82A7wUcLaYKS+SYuhsFNJ01s399OBsnLl0RS3HRDAT0rnJ3hezWjoNSkFcZKI5upQ== X-Received: by 2002:a7b:c448:: with SMTP id l8mr3099862wmi.128.1585652956621; Tue, 31 Mar 2020 04:09:16 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:65f2:9a92:2c96:9204]) by smtp.gmail.com with ESMTPSA id f12sm22668610wrm.94.2020.03.31.04.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 04:09:15 -0700 (PDT) In-Reply-To: <877dz0rf2v.fsf@igel.home> (Andreas Schwab's message of "Tue, 31 Mar 2020 12:31:04 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::330 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246086 Archived-At: >>>>> On Tue, 31 Mar 2020 12:31:04 +0200, Andreas Schwab said: Andreas> On M=C3=A4r 31 2020, Robert Pluim wrote: >> My reading of set_network_socket_coding_system is that having a plist >> in make-network-process with :coding nil overrides a non-nil >> coding-system-for-{read-write}, which I don=CA=BCt think we want. Andreas> You are right, make-network-process and make-serial-process ha= ndle that Andreas> differently than make-process and make-pipe-process. I think = this is a Andreas> bug, they should all handle :coding nil the same (same as abse= nce). I think I agree with that. Basically this, initially (and the same for make-serial-process) diff --git a/src/process.c b/src/process.c index e18a5aa538..b00d8e1cfe 100644 --- a/src/process.c +++ b/src/process.c @@ -3261,9 +3262,7 @@ set_network_socket_coding_system (Lisp_Object proc, L= isp_Object host, Lisp_Object coding_systems =3D Qt; Lisp_Object val; =20 - tem =3D Fplist_member (contact, QCcoding); - if (!NILP (tem) && (!CONSP (tem) || !CONSP (XCDR (tem)))) - tem =3D Qnil; /* No error message (too late!). */ + tem =3D Fplist_get (contact, QCcoding); =20 /* Setup coding systems for communicating with the network stream. */ /* Qt denotes we have not yet called Ffind_operation_coding_system. */ Andreas> But in any case, your patch can be simplyfied: Andreas> --- a/lisp/net/network-stream.el Andreas> +++ b/lisp/net/network-stream.el Andreas> @@ -246,10 +246,12 @@ gnutls-boot (as returned by `gnutls-boot= -parameters')." =20 Andreas> (defun network-stream-open-plain (name buffer host service pa= rameters) Andreas> (let ((start (with-current-buffer buffer (point))) Andreas> - (stream (make-network-process :name name :buffer buffer Andreas> - :host (puny-encode-domain host) Andreas> - :service service Andreas> - :nowait (plist-get parameters :nowait)))) Andreas> + (stream (apply #'make-network-process :name name :buffer buf= fer Andreas> + :host (puny-encode-domain host) Andreas> + :service service Andreas> + :nowait (plist-get parameters :nowait) Andreas> + (if (plist-member parameters :coding) Andreas> + (list :coding (plist-get parameter= s :coding)))))) Andreas> (when (plist-get parameters :warn-unless-encrypted) Andreas> (setq stream (nsm-verify-connection stream host service= nil t))) Andreas> (list stream Sure. Robert