From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#40200: [PATCH v3] Fix NS frame resizing issues (bug#40200, bug#28872) Date: Mon, 06 Apr 2020 09:57:16 +0300 Message-ID: References: <20200328015657.GA66478@breton.holly.idiocy.org> <20200404141749.GA10895@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99470"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 40200@debbugs.gnu.org, 28872@debbugs.gnu.org, aaronjensen@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 06 08:58:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLLiB-000PlU-6R for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Apr 2020 08:58:23 +0200 Original-Received: from localhost ([::1]:55458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLLiA-0003if-7H for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Apr 2020 02:58:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52852) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLLhs-0003Zl-0O for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 02:58:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLLhq-0000iQ-V6 for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 02:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLLhq-0000iK-Sb for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 02:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jLLhq-0006Ah-Rx for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 02:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Apr 2020 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40200 X-GNU-PR-Package: emacs Original-Received: via spool by 40200-submit@debbugs.gnu.org id=B40200.158615624823638 (code B ref 40200); Mon, 06 Apr 2020 06:58:02 +0000 Original-Received: (at 40200) by debbugs.gnu.org; 6 Apr 2020 06:57:28 +0000 Original-Received: from localhost ([127.0.0.1]:47083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLLhH-000696-Ul for submit@debbugs.gnu.org; Mon, 06 Apr 2020 02:57:28 -0400 Original-Received: from mail-lf1-f65.google.com ([209.85.167.65]:32910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLLhE-00068S-TN; Mon, 06 Apr 2020 02:57:25 -0400 Original-Received: by mail-lf1-f65.google.com with SMTP id h6so6369911lfc.0; Sun, 05 Apr 2020 23:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cEMuEGAkt0vuV7pFCBDRJdj41ZutSyV7SizRNIfNaak=; b=cdgCt3CgbTi2f2nxaMrPJQjQ36lWSo87A6pcsPD6/6GWmi3qniN5KRDZ10gMFCANcJ CWLS2+4vpNsi/WKTaPVrJXtWAJSH4Wd6a3rycRJUNumujNoSk9DEC8KbvZEBgnyWS4Bs qEL76VH45yMYYDhFlBVu0GaYB+Gfbr2+TgHMmGE9BPzF00W9fJTAKenK41HQZJm/nvRw KKhzmzo05530PNWslzgSgvzomXFvZi8+3u/MCWc9FLPtxCPV5+xOHkukw7XznXgFBWGp 0CMg9Fn7OROjS7C3D7fEnQ7bCYIRz2iz/gSPoLXON8BbRqt7oblwBhaorWgWf5sZUPvH yjLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cEMuEGAkt0vuV7pFCBDRJdj41ZutSyV7SizRNIfNaak=; b=hQJuDesTXVGphhFT6E9jA5SxRL4Wsqb+OhLO8EacTnvki/UV5nt9CWYtYVLi5jW3m2 uGozYwNH7TAQaPH1k+WZc3tDVHW1kAoBduHQVzCBJmt/6HUwjHOu+16wvlizFyfXrgHn VDBCL35Xkq42sudW0qNu8T9EWL+ruL4DiVJUDN/u+fMIu82vMIW2dMzLyUJvmDN1IRX1 OOOjzWWrEZdqP9d6WKddSSf2P0s6atIYtGEgsV6m8CNlmXJDYE149L6PtT0aTrytGFVI S9Hb9B6O0TVTzcqqOK/cRIGfVp985IGVJO1viHSXAkVIgc/M8LNuKcXnXIx/SfwPgXNh phuA== X-Gm-Message-State: AGi0PuaNQrt66tmtRqjX0UsZnq7oTRqRlGDs2aS37PmRrFMvyE4xZxtv qxUYWaCFHs7snZzZCiZc1UU= X-Google-Smtp-Source: APiQypKLhmODMX/2DXx6yOZrtmbGJNFXbIRWdIRWfFzrS92UZcW0qdA/uyru8WdK4cj9umixSHycaQ== X-Received: by 2002:a19:3857:: with SMTP id d23mr6398247lfj.214.1586156238596; Sun, 05 Apr 2020 23:57:18 -0700 (PDT) Original-Received: from muffinmac.local ([91.206.110.145]) by smtp.gmail.com with ESMTPSA id j22sm11189507lfg.96.2020.04.05.23.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2020 23:57:17 -0700 (PDT) In-Reply-To: <20200404141749.GA10895@breton.holly.idiocy.org> (Alan Third's message of "Sat, 4 Apr 2020 15:17:49 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178073 Archived-At: Alan Third writes: > Once again, I think this is right. Please test and let me know how you > get on. This code works differently in the patched version: (progn (tool-bar-mode -1) (let ((child-frame (make-frame `((parent-frame . ,(selected-frame)) (top . 0) (left . 0) (width . 1.0) (height . 1)))) (new-frame (make-frame))) (set-frame-width new-frame (+ 20 (frame-parameter new-frame 'width))) (modify-frame-parameters child-frame `((parent-frame . ,new-frame))) (modify-frame-parameters child-frame '((top . 0) (left . 0) (width . 1.0) (height . 1))))) Child frame doesn't occupy full width of the parent frame. > + ns_clear_frame (emacsframe); Can this line be removed from the patch? I've described reasons to remove it in another letter: https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-03/msg01060.html Thanks!