all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrii Kolomoiets <andreyk.mad@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: 40200@debbugs.gnu.org, 28872@debbugs.gnu.org, aaronjensen@gmail.com
Subject: bug#40200: [PATCH v3] Fix NS frame resizing issues (bug#40200, bug#28872)
Date: Mon, 06 Apr 2020 09:57:16 +0300	[thread overview]
Message-ID: <m24ktx9k4z.fsf@gmail.com> (raw)
In-Reply-To: <20200404141749.GA10895@breton.holly.idiocy.org> (Alan Third's message of "Sat, 4 Apr 2020 15:17:49 +0100")

Alan Third <alan@idiocy.org> writes:

> Once again, I think this is right. Please test and let me know how you
> get on.

This code works differently in the patched version:

(progn
  (tool-bar-mode -1)
  (let ((child-frame (make-frame `((parent-frame . ,(selected-frame))
                                   (top . 0)
                                   (left . 0)
                                   (width . 1.0)
                                   (height . 1))))
        (new-frame (make-frame)))
    (set-frame-width new-frame (+ 20 (frame-parameter new-frame 'width)))
    (modify-frame-parameters child-frame `((parent-frame . ,new-frame)))
    (modify-frame-parameters child-frame '((top . 0)
                                           (left . 0)
                                           (width . 1.0)
                                           (height . 1)))))

Child frame doesn't occupy full width of the parent frame.

> +  ns_clear_frame (emacsframe);

Can this line be removed from the patch? I've described reasons to
remove it in another letter:
https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-03/msg01060.html

Thanks!





  reply	other threads:[~2020-04-06  6:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 18:13 bug#40200: 28.0.50; NS: text drawing glitches in maximized frame with frame-inhibit-implied-resize Andrii Kolomoiets
2020-03-23 19:22 ` Eli Zaretskii
2020-03-23 19:47   ` Andrii Kolomoiets
2020-03-23 23:54 ` Alan Third
2020-03-25 22:28   ` bug#40200: [PATCH] Fix NS frame resizing issues (bug#40200, bug#28872) Alan Third
2020-03-26 17:35     ` bug#28872: " Andrii Kolomoiets
2020-03-26 21:21       ` bug#28872: [PATCH v2] " Alan Third
2020-03-27  9:45         ` Andrii Kolomoiets
2020-03-27 13:22         ` Andrii Kolomoiets
2020-03-28  1:56           ` Alan Third
2020-04-04 14:17             ` bug#40200: [PATCH v3] " Alan Third
2020-04-06  6:57               ` Andrii Kolomoiets [this message]
2020-04-06 18:44                 ` bug#28872: [PATCH v4] " Alan Third
2020-04-07  8:14                   ` bug#40200: " Andrii Kolomoiets
2020-04-16 18:24                     ` bug#28872: " Alan Third
2020-04-18  1:52                       ` bug#40200: " HaiJun Zhang
2020-04-18 12:07                         ` Alan Third
2020-04-18 14:12                           ` HaiJun Zhang
2020-04-18 15:26                             ` Alan Third
2020-04-19  1:49                               ` HaiJun Zhang
2020-05-03 16:26                                 ` Alan Third
2020-05-03 17:13                                   ` Filipp Gunbin
2020-05-03 18:41                                     ` Alan Third
2020-05-03 19:49                                       ` Filipp Gunbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24ktx9k4z.fsf@gmail.com \
    --to=andreyk.mad@gmail.com \
    --cc=28872@debbugs.gnu.org \
    --cc=40200@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=alan@idiocy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.