From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#65516: 30.0.50; Edebug behavior of signaling errors in &or Date: Mon, 28 Aug 2023 07:44:16 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , 65516@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 28 07:45:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qaV3q-0004Hs-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Aug 2023 07:45:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaV3Z-0004xP-Kt; Mon, 28 Aug 2023 01:44:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaV3Y-0004wp-9W for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 01:44:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qaV3Y-0001Wo-1O for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 01:44:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qaV3d-00076o-UY for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 01:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 05:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65516 X-GNU-PR-Package: emacs Original-Received: via spool by 65516-submit@debbugs.gnu.org id=B65516.169320147627281 (code B ref 65516); Mon, 28 Aug 2023 05:45:01 +0000 Original-Received: (at 65516) by debbugs.gnu.org; 28 Aug 2023 05:44:36 +0000 Original-Received: from localhost ([127.0.0.1]:46727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaV3E-00075w-4F for submit@debbugs.gnu.org; Mon, 28 Aug 2023 01:44:36 -0400 Original-Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:49656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaV38-00075f-HD for 65516@debbugs.gnu.org; Mon, 28 Aug 2023 01:44:34 -0400 Original-Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-99cce6f7de2so353478766b.3 for <65516@debbugs.gnu.org>; Sun, 27 Aug 2023 22:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693201458; x=1693806258; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4ZlpHEugcX2IlfAaNROIpHzHGoaZWqJceQA0jLkUe40=; b=q8yUJRKyH+IhboRABvGnU4da57mT5FKeWNK69B0NyccLhPE3+D83/bVMZcHQMO3M8d NjOA+HaEHGEg+jBtqGOwwNhCq2buug7pxacMjZmb/cIxeQRLClqHz+IBC1d7YOq+pAjS k0eSmzNm6XfApnTD9/tzNyEIsJgeyHbM18M4Vq7j2iHtFKD6YV3+v14oyj/fpvdt/a9w mftcGEnSo1uLwdAYrvkDnIuJQIeYLqMWNvqxNlY8jiWm+RNC+GFdyzWR1nnTpY1QHCd2 LyaQbI7FwziFz6mbkG38aJdkZZz/MIyImweiscfWVMwyn6PhO7SXJyCVP++1Njku6KsB eVKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693201458; x=1693806258; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4ZlpHEugcX2IlfAaNROIpHzHGoaZWqJceQA0jLkUe40=; b=X8Q5sTGTT/H/E85O6RV9N6CwtK/QxQmJ0zWoAj2mSZsMAl6NM06CqrXAR0kziFPQUM rmOzZAqwSrjO0pkzm74Oc6GGoOvxiPPVAPYdnkn8h/4Y+XuD5ZmvGSBHJ2Ze4q7BNRkp tmZwvhyTJFCRH529b6LISamx3HtyaclJSJkyXSJn3ei7ct2JsvQm+Ow7nh/2dXHnP99D 3fcJHyWlP/+DzldJRA+dIT5VSbodNttuYz95sUfve3eaeM72o08w3LCtJbdODWKVgeSq 6vjH+AiuhO7hiH+NCd5ye+6G8pcrEapD8DcXswTkqyfQO/3phsiXZnMIHmEgSlQqJcyN kmJw== X-Gm-Message-State: AOJu0YzVUd4NS0bV550hsSRfMdfqIxuX40bkaE4e+0Hxv53zTZJHUfLc ag72rYTmecbGXhUeqNxgQyg= X-Google-Smtp-Source: AGHT+IECck3Vtv7ekG35k1RjKkC6FzCiVPDPsfqUBGPqGno0GXIkii8U/q8X24FTS8O1pqEgkE+91A== X-Received: by 2002:a17:906:53d6:b0:9a5:81cf:57bb with SMTP id p22-20020a17090653d600b009a581cf57bbmr5801103ejo.41.1693201458006; Sun, 27 Aug 2023 22:44:18 -0700 (PDT) Original-Received: from Mini.fritz.box (pd9e36867.dip0.t-ipconnect.de. [217.227.104.103]) by smtp.gmail.com with ESMTPSA id bn24-20020a170906c0d800b00997d7aa59fasm4308470ejb.14.2023.08.27.22.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 22:44:17 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 27 Aug 2023 11:30:11 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268602 Archived-At: Stefan Monnier writes: >>> See bug#41988 for a case where we didn't want a failure in one >>> "definition form" to be allowed to continue matching in a second branch >>> of an `&or` (tho this was arguably because some of the code executed >>> along the way had side-effects that can't be undone). >> >> Hurrah! :-) Yes, that's it! Thank you so much, that made my day! >> >> As a fix, I'd like to propose to remove 'gate' as a debug spec entirely. > > It's worth a try but: > > - We should come up with a better fix for bug#41988/bug#41853 first. > - We need to check the impact on current users of that gate mechanism. > > For the second, `grep -C9 debug **/*.el | grep '\'` > finds only one direct user of `gate` inside Emacs or (Non)GNU ELPA, > i.e. `cl-macs.el` > > lisp/emacs-lisp/cl-macs.el:1224:;; '(&or (loop-var . [&or nil loop-var]) [gate symbolp])) > lisp/emacs-lisp/cl-macs.el:2858: (gate gv-place &optional form)]) > lisp/emacs-lisp/cl-macs.el:2989: (gate ;; FIXME: Why? > > but there might be users elsewhere. And more importantly it's used > within > > - strings > - `&define` > - quoted symbols? > > The last one seems to be an old deprecated mechanism (a comment suggests > it should be replaced by a string) that just has never been actively > deprecated, so maybe we can disregard it. > But the first two are used in a lot of places, so it might be more problematic. I'd change all these, but I can understand if that's too radical for your taste :-).