From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.bugs Subject: bug#69187: 29.2; Poor compatibility in align.el Date: Sat, 06 Apr 2024 22:14:46 +0200 Message-ID: References: <55489.1708171413@localhost> <2214.1708282932@localhost> <2125.1712336273@localhost> <861q7j57vl.fsf@gnu.org> <2364.1712395849@localhost> <86h6ge3g8u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2072"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69187@debbugs.gnu.org, Ikumi Keita , johnw@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 06 22:16:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtCSk-0000Iy-38 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Apr 2024 22:16:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtCSG-0006gU-2T; Sat, 06 Apr 2024 16:16:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtCSD-0006fz-Ls for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 16:15:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtCSD-0006fp-DV for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 16:15:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtCSJ-0004GP-EY for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 16:16:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Arash Esbati Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2024 20:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69187 X-GNU-PR-Package: emacs Original-Received: via spool by 69187-submit@debbugs.gnu.org id=B69187.171243451116105 (code B ref 69187); Sat, 06 Apr 2024 20:16:03 +0000 Original-Received: (at 69187) by debbugs.gnu.org; 6 Apr 2024 20:15:11 +0000 Original-Received: from localhost ([127.0.0.1]:41024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtCRR-0004BV-Jw for submit@debbugs.gnu.org; Sat, 06 Apr 2024 16:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtCRM-0004AY-SQ for 69187@debbugs.gnu.org; Sat, 06 Apr 2024 16:15:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtCR8-0006Dy-U6; Sat, 06 Apr 2024 16:14:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=g1Bri7onaK2XSXWNsk4CkVbZf1vf6hjb0bVnqsNpnIQ=; b=kl47od2KSfX08jKzpX1L nQvO+6vGEd0lM25HJ2vxnG+Ro+imwnpf4wxgECNS3V0ADejmFJlAQQEWWkb8hDPeQ/DQz2yZpj2wC YW1yleQrp7uTX2dVAQGJQWPmBqs/3pptIv3O5Dgwf/G4TnbSZrYqeJdlRsZqg+Av4C2LuUMeccyPS bs6T7sjjCeLlxcT2wAwl05e9ia4sU6D1iD/wkGLlL4YDroi3AfPa67BiMnoPBXYo98A6aRUYLLBly yufOd6+/ZRoZ/CoSyepup1TiMhHvKayotPcgZlt/UKWOEr0pdijNXR9tyUxb6pWTlVgAps/bFK3Wj Yg9H439RQ195VQ==; In-Reply-To: <86h6ge3g8u.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Apr 2024 14:03:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282823 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Ikumi Keita >> >> > . what is the rationale for not using align-tex-modes here, only >> > latex-mode? >> >> Because the current `tex-tabbing-separator' entry in `align-rules-list' >> excludes other modes by `run-if' form. Which is correct, in general. The tabbing environment looks like this and is only available in LaTeX and not in other formats (AFAICT): \begin{tabbing} Zero \=One \=Two \=Three\\ \>First tab stop\\ \>A\>\>B\\ \>\>Second tab stop \end{tabbing} And the rule is designed to match these separators. > Then I'm okay with installing the proposed change. Thanks, the change is attached; I can push it myself, or you can do it in case you want to change the commit message etc. I will close the report once the change is installed. @Keita: Thanks for the report and answering Eli's questions. Best, Arash --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-tex-tabbing-separator-alignment-rule.patch >From 76f30b873a0e358606ad92e2df799e5c0cea474d Mon Sep 17 00:00:00 2001 From: Arash Esbati Date: Sat, 6 Apr 2024 21:58:03 +0200 Subject: [PATCH] Fix tex-tabbing-separator alignment rule * lisp/align.el (align-rules-list): Remove the check of `latex-mode' with `eq' which doesn't work with newer AUCTeX mode names and modes defined by user with `define-derived-mode'. (bug#69187) --- lisp/align.el | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lisp/align.el b/lisp/align.el index 81ccc4b5e2d..0e77a857585 100644 --- a/lisp/align.el +++ b/lisp/align.el @@ -537,10 +537,8 @@ align-rules-list (regexp . ,(lambda (end reverse) (align-match-tex-pattern "\\\\[=>]" end reverse))) (group . (1 2)) - (modes . align-tex-modes) - (repeat . t) - (run-if . ,(lambda () - (eq major-mode 'latex-mode)))) + (modes . '(latex-mode)) + (repeat . t)) (tex-record-break (regexp . "\\(\\s-*\\)\\\\\\\\") -- 2.44.0 --=-=-=--