From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Al Haji-Ali Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Mon, 17 Jun 2024 17:08:34 +0100 Message-ID: References: <86msnw4qm4.fsf@mail.linkov.net> <86y17gej2x.fsf@gnu.org> <86y17gmxdg.fsf@mail.linkov.net> <868qzehxie.fsf@mail.linkov.net> <86msnu9fhg.fsf@gnu.org> <86zfruc7qh.fsf@mail.linkov.net> <86ikyi9e2l.fsf@gnu.org> <86o78ac6ny.fsf@mail.linkov.net> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@gmx.at> <86frtkeyzo.fsf@mail.linkov.net> <811654d9-bde2-4ba5-bbeb-15db0d7dcf00@gmx.at> <86r0d1iaxc.fsf@mail.linkov.net> <8634pfe735.fsf@mail.linkov.net> <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@gmx.at> <86frtdtlns.fsf@mail.linkov.net> <87b7ee75-7c63-42ac-8551-c0d20a46ea43@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18798"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 71386@debbugs.gnu.org To: martin rudalics , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 17 18:11:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJEwr-0004m4-UK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jun 2024 18:11:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJEwf-0004sb-Uz; Mon, 17 Jun 2024 12:11:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJEwe-0004sH-0S for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2024 12:11:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJEwd-0007ev-OH for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2024 12:10:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJEwf-0001tp-PY for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2024 12:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Al Haji-Ali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2024 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.17186406137245 (code B ref 71386); Mon, 17 Jun 2024 16:11:01 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 17 Jun 2024 16:10:13 +0000 Original-Received: from localhost ([127.0.0.1]:35191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJEvs-0001sn-Jl for submit@debbugs.gnu.org; Mon, 17 Jun 2024 12:10:12 -0400 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:43147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJEvq-0001sa-Ic for 71386@debbugs.gnu.org; Mon, 17 Jun 2024 12:10:11 -0400 Original-Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-35f2c9e23d3so3694793f8f.0 for <71386@debbugs.gnu.org>; Mon, 17 Jun 2024 09:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718640542; x=1719245342; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=L1zWDFQEX9PfNy3EPowh+QmoZr1p0+hGxbJLCDT3CbA=; b=cNs/jM6qvcKf4l1+beXdFj5bBT9PA9Pusa67BYRytzqPn4daxgM4xU37fIiD55KthC Y68FqD310U9lGsEIA3z4ugeqEKGOBj3go2Z0VrH+vYdnJtG01pliyrvZ+MF/0eWCpzwk 5k1E6VKm2pgJdEND1+i22CW+urgeXVF3kJlSiJ3uGDA2xGuDUmnmKrd2l/C3CcAZcQ2W zAhnyiIgJvVQnpS6cNCRQdhLpJ9zYYT//41X6QKzn/oiB0mjU2N9yBWSH1FkIIWftmdi 3QTiRDcYDFQsOwqJVKGhyByYAhzdg0EvoYUqQp7LIDogQjSNnL533KMOsiKaIyEJBkO6 +Eeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718640542; x=1719245342; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L1zWDFQEX9PfNy3EPowh+QmoZr1p0+hGxbJLCDT3CbA=; b=pU/3P6pWhWh74o5MTpNL0NfxNTsOv2R+VCru93RVIal8hdUu/Q83DFkFR/UxCz6WED jeuLHIfGhUxooWVvy92enrthtd1eD6ddK8QsIHUmFRuFy1rt+p7ZygXZccKNsNe9YPRt U0BFZhPpGsHx8fLQ5qYySfyMhBF7xNLqjS+qXrxRy/TuNKR5e1DqpdsYCICl5O1sQCSd 1KhckQuSFNSv3pXgJTWYMtTho+5HozlBTuM5s6pMRSGE+78O/2nuM+VCfhxxjN8W+UA9 hU9BuJw5qegWyCGLWbJUbInFk6HUldx2Vontt148xYJBFar8UNGlM79hxFiqslENunuf xbJQ== X-Forwarded-Encrypted: i=1; AJvYcCXmnpzSpjCt8boIlRjheyVTxCmCvADOYAjddMKbtxiIqcEOfuYVKGpHx2FWKJcEhjruMvsBY5UJYUTXGMrDzfmd8jKC6iw= X-Gm-Message-State: AOJu0Yx/+zvWFEAssnwgNiK7xpkxOqu20pS956/UKFh6S5A9FCfzfOqF njWVXnCn+qWYkAFyOQYvkF7f2as7Nh2rB6qEEQj+1Q0nqV+aPj7H X-Google-Smtp-Source: AGHT+IG2NV0KrYrhLWbcgCxns/3j/DP/2+MQWdTNU/NmFom3Swg7FN6NzCfJKa84TFu5Ohsp22nP7A== X-Received: by 2002:a5d:6ac2:0:b0:360:9333:c69 with SMTP id ffacd0b85a97d-3609eaa9059mr74510f8f.33.1718640542350; Mon, 17 Jun 2024 09:09:02 -0700 (PDT) Original-Received: from localhost (sgyl-45-b2-v4wan-166941-cust3717.vm6.cable.virginm.net. [82.37.190.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750acd7csm12189655f8f.52.2024.06.17.09.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 09:09:01 -0700 (PDT) In-Reply-To: <87b7ee75-7c63-42ac-8551-c0d20a46ea43@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287402 Archived-At: On 17/06/2024, martin rudalics wrote: > This means that we should do the entire fix within 'window-deletable-p', > right? That's not an internal function, so we can, in all conscience, > supply an abnormal hook as in the roughly tested patch attached. It would be great if the fix is done entirely in `window-deletable-p`, but is the idea functions in `window-deletable-functions` could have side-effects even though they are called from a predicate? For tabs, I believe an ideal fix would close the tab in lieu of deleting the frame when the buffer of a dedicated window is killed (similar to what Juri does in per patches). -- Al