From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pettersson Newsgroups: gmane.emacs.bugs Subject: bug#71763: [PATCH] Inconsistency in bitmap overlay drawing for macOS Date: Tue, 29 Oct 2024 20:59:32 +0100 Message-ID: References: <86frsy684o.fsf@gnu.org> <86ttcx92k7.fsf@gnu.org> <86o7358xz7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38837"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71763@debbugs.gnu.org, Eli Zaretskii To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 29 21:00:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t5sOM-0009vM-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Oct 2024 21:00:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5sO8-0007cK-Jr; Tue, 29 Oct 2024 16:00:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5sNn-0007aD-U3 for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2024 16:00:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5sNn-0007i1-Kv for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2024 16:00:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=TYjigiRvHMqYivMoauwSnggBPvi3pg1ptEKUrQbgDnw=; b=m9gZLZYHHHN9HPlpfKnGMIPyqlyniFQg22UsuACMqEcLZHpFnZ0SxMkyek9j+SQpxSgL+KlQoWXYOsNgc0XkOdK848MGgbIUTxwj0Ql/Fn0Sx21S5fnwQ8U09YcEbf8vxe2lx3FCq0g+J3kG4mEvLSi+E/lvQiDFPg9XyB4fsgpa+zzATAceb/fpafqLC1szaHyoe1IA6wxUeVYg98B07e/w9u/mIWKwmq8YnnAnNTM477Kd+/O2AAtFuYK3qXuf41rQGmIOId80VgqvR5e0Qk/l21LkFjHlH1VWPoUOA9AqDzJEamJZVRdjtaICuU9L6lNgeBu36BjOIEARv5dUIw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5sNn-0008V6-30 for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2024 16:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Pettersson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Oct 2024 20:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71763-submit@debbugs.gnu.org id=B71763.173023197732631 (code B ref 71763); Tue, 29 Oct 2024 20:00:03 +0000 Original-Received: (at 71763) by debbugs.gnu.org; 29 Oct 2024 19:59:37 +0000 Original-Received: from localhost ([127.0.0.1]:58453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5sNN-0008UF-25 for submit@debbugs.gnu.org; Tue, 29 Oct 2024 15:59:37 -0400 Original-Received: from mail-lf1-f50.google.com ([209.85.167.50]:57666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5sNK-0008U7-Rc for 71763@debbugs.gnu.org; Tue, 29 Oct 2024 15:59:35 -0400 Original-Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-539e8607c2aso6038398e87.3 for <71763@debbugs.gnu.org>; Tue, 29 Oct 2024 12:59:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730231974; x=1730836774; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TYjigiRvHMqYivMoauwSnggBPvi3pg1ptEKUrQbgDnw=; b=qOc6XoLA/9qgi3bLY2VyDggj/nFsY5orrgMwXuFFwXTqqELxNsYm0RMbhsSIkG/8Wr 2z/S5avKBlmlciJhcFWXzyejGUpb2Id8hpnOI/0ol8lsP2fnhXPs3+Sz6J9WCqas4lY4 vS3nkFL3Nwj75ZFaE/L3w/79NBMka0MoyKrHD0X4EY81AvWUlg77+e0WvvrfE4SNQOPh g0WaYVtvD8ZT+LOSFw78PMbAgKvSNJ2eJX3jmUhx+dZH3ptHiV56LTdQnxWuJHL9unfD d3FcrBqNesmBU3Ju58xIa206QZm1Y5UshPDxUsPv4o7skAMFVD1Z6aBGQTZj/If66puE E2cw== X-Forwarded-Encrypted: i=1; AJvYcCXvxFY7DIhikoM8KFV1NPWUGFoLKaFrFYuyN94fQd4W4BC/udIbsO9pvOkOWj1BNl26140aXA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxUCq7j5AZC3EKzVEuM2eJEJqMVxe1HEDOSeQWAxgsbsjkYBYUu R980y17BxGx4sP7scDj+mXAq+GDhjs6k2K2ZAgPFh6dT+jGSIg2JGYxqhQ== X-Google-Smtp-Source: AGHT+IERAPIUWpC25J0U01yb9Pm9QCVddGkqupBBLnlgiqogf9+7VVQg4sqZQPDhFOm7sTVK6fV48Q== X-Received: by 2002:a05:6512:3c95:b0:539:ea66:597e with SMTP id 2adb3069b0e04-53b348b7e77mr5389629e87.2.1730231973521; Tue, 29 Oct 2024 12:59:33 -0700 (PDT) Original-Received: from Daniels-Air (c-85-228-201-151.bbcust.telenor.se. [85.228.201.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53bb81a5776sm40403e87.79.2024.10.29.12.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 12:59:32 -0700 (PDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Sun, 27 Oct 2024 15:03:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294532 Archived-At: Gerd M=C3=B6llmann writes: > If I read the diff correctly, this puts the clearing under the bitmap in > an if-statement so that it is only done if we do not draw intentionally > on top something drawn before. > Right, Daniel? Yup, w/o this we clear fringe on draw when I we should keep it intact and draw over. The only example I found and the reason for this fix is that we clear fringe of overlays before drawing overlay-arrow. Such that breakpoint bitmap is removed when overlay-arrow is on the same line in gdb-mi.el.