Re: PC-do-completion weird behavior acronym expansion.

From: "Sean O'Rourke" <sorourke@cs.ucsd.edu>
To: emacs-devel@gnu.org
Cc: "Michaël Cadilhac" <michael@cadilhac.name>
Subject: Re: PC-do-completion weird behavior acronym expansion.
Date: Wed, 05 Sep 2007 21:51:22 -0700	[thread overview]
Message-ID: <m23axsv1kl.fsf@dyn128-54-220-221.ucsd.edu> (raw)
In-Reply-To: <87wsv87yqn.fsf@elegiac.orebokech.com> (Romain Francoise's message of "Mon\, 03 Sep 2007 13\:52\:00 +0200")

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

Romain Francoise <romain@orebokech.com> writes:

> michael@cadilhac.name (Michaël Cadilhac) writes:
>
>> The following change :
>
>> 2007-08-07  Sean O'Rourke  <sorourke@cs.ucsd.edu>
>
>>      * complete.el (PC-lisp-complete-symbol): Complete symbol around point.
>>      (PC-do-completion): Add "acronym completion" for symbols and
>>      filenames, so e.g. "mvbl" expands to "make-variable-buffer-local".
>
>> seems to introduce a little (but annoying) bug [...]
>
> It introduces another annoying bug: hitting TAB when the list of
> possible completions is empty signals an error.

Yeah, that does suck -- my apologies.  Please try the attached
patch.

/s

2007-09-05  Sean O'Rourke  <sorourke@cs.ucsd.edu>

	* complete.el (PC-do-completion): don't try to treat
	  empty string as an abbreviation.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 823 bytes --]

Index: complete.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/complete.el,v
retrieving revision 1.78
diff -p -u -w -r1.78 complete.el

--- complete.el	26 Aug 2007 19:20:10 -0000	1.78
+++ complete.el	6 Sep 2007 04:49:05 -0000
@@ -596,9 +596,10 @@ GOTO-END is non-nil, however, it instead
           (setq poss (all-completions (if env-on basestr str)
 				      table
 				      pred))
-          (unless poss
+          (unless (or poss (string-equal str ""))
             ;; Try completion as an abbreviation, e.g. "mvb" ->
-            ;; "m-v-b" -> "multiple-value-bind"
+            ;; "m-v-b" -> "multiple-value-bind", but only for
+            ;; non-empty strings.
             (setq origstr str
                   abbreviated t)
             (if filename

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
