From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: CHENG Gao Newsgroups: gmane.emacs.devel Subject: Bad (Wrong?) comment in src/nsterm.m Date: Wed, 02 Sep 2009 16:35:53 +0800 Organization: cyberhut.org Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1251881169 3693 80.91.229.12 (2 Sep 2009 08:46:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Sep 2009 08:46:09 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 02 10:46:02 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MilTd-0001l0-Po for ged-emacs-devel@m.gmane.org; Wed, 02 Sep 2009 10:46:02 +0200 Original-Received: from localhost ([127.0.0.1]:56735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MilTc-0001Lc-Vm for ged-emacs-devel@m.gmane.org; Wed, 02 Sep 2009 04:46:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MilTX-0001LW-1H for emacs-devel@gnu.org; Wed, 02 Sep 2009 04:45:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MilTS-0001Kv-5I for emacs-devel@gnu.org; Wed, 02 Sep 2009 04:45:54 -0400 Original-Received: from [199.232.76.173] (port=41109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MilTS-0001Kk-1B for emacs-devel@gnu.org; Wed, 02 Sep 2009 04:45:50 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:39579) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MilTR-0006iQ-1H for emacs-devel@gnu.org; Wed, 02 Sep 2009 04:45:49 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1MilTN-0001h6-UW for emacs-devel@gnu.org; Wed, 02 Sep 2009 10:45:45 +0200 Original-Received: from 117.88.78.2 ([117.88.78.2]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Sep 2009 10:45:45 +0200 Original-Received: from chenggao by 117.88.78.2 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Sep 2009 10:45:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 117.88.78.2 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (darwin) Cancel-Lock: sha1:wgJ4/RhpC8uZBsrQr7EFPhFR2mI= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114979 Archived-At: In src/nsterm.m, I found (line 1344-1351): (To be honest, clang-analyzer found it) ,---- | static int | ns_get_color (const char *name, NSColor **col) | /* -------------------------------------------------------------------------- | Parse a color name | /* -------------------------------------------------------------------------- | /* On *Step, we attempt to mimic the X11 platform here, down to installing an | X11 rgb.txt-compatible color list in Emacs.clr (see ns_term_init()). | See: http://thread.gmane.org/gmane.emacs.devel/113050/focus=113272). */ `---- I am not sure if this is wrong, but it looks bad. I guess it should be ,---- | static int | ns_get_color (const char *name, NSColor **col) | /* -------------------------------------------------------------------------- | Parse a color name | --------------------------------------------------------------------------*/ | /* On *Step, we attempt to mimic the X11 platform here, down to installing an | X11 rgb.txt-compatible color list in Emacs.clr (see ns_term_init()). | See: http://thread.gmane.org/gmane.emacs.devel/113050/focus=113272). */ `---- -- Ubi bene, ibi patria