all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Bad (Wrong?) comment in src/nsterm.m
@ 2009-09-02  8:35 CHENG Gao
  2009-09-03  6:04 ` Glenn Morris
  0 siblings, 1 reply; 2+ messages in thread
From: CHENG Gao @ 2009-09-02  8:35 UTC (permalink / raw)
  To: emacs-devel

In src/nsterm.m, I found (line 1344-1351):
(To be honest, clang-analyzer found it)

,----
| static int
| ns_get_color (const char *name, NSColor **col)
| /* --------------------------------------------------------------------------
|      Parse a color name
| /* --------------------------------------------------------------------------
| /* On *Step, we attempt to mimic the X11 platform here, down to installing an
|    X11 rgb.txt-compatible color list in Emacs.clr (see ns_term_init()).
|    See: http://thread.gmane.org/gmane.emacs.devel/113050/focus=113272). */
`----

I am not sure if this is wrong, but it looks bad. I guess it should be

,----
| static int
| ns_get_color (const char *name, NSColor **col)
| /* --------------------------------------------------------------------------
|      Parse a color name
|    --------------------------------------------------------------------------*/
| /* On *Step, we attempt to mimic the X11 platform here, down to installing an
|    X11 rgb.txt-compatible color list in Emacs.clr (see ns_term_init()).
|    See: http://thread.gmane.org/gmane.emacs.devel/113050/focus=113272). */
`----

-- 
Ubi bene, ibi patria






^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bad (Wrong?) comment in src/nsterm.m
  2009-09-02  8:35 Bad (Wrong?) comment in src/nsterm.m CHENG Gao
@ 2009-09-03  6:04 ` Glenn Morris
  0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2009-09-03  6:04 UTC (permalink / raw)
  To: CHENG Gao; +Cc: emacs-devel


Thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-03  6:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-02  8:35 Bad (Wrong?) comment in src/nsterm.m CHENG Gao
2009-09-03  6:04 ` Glenn Morris

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.