From: Andreas Schwab <schwab@linux-m68k.org>
To: Kenichi Handa <handa@gnu.org>
Cc: 12823@debbugs.gnu.org
Subject: bug#12823: Invalid font name
Date: Tue, 13 Nov 2012 20:25:01 +0100 [thread overview]
Message-ID: <m2390db90y.fsf@igel.home> (raw)
In-Reply-To: <878va5u38h.fsf@gnu.org> (Kenichi Handa's message of "Tue, 13 Nov 2012 20:55:10 +0900")
Kenichi Handa <handa@gnu.org> writes:
> === modified file 'src/font.c'
> --- src/font.c 2012-11-03 05:11:34 +0000
> +++ src/font.c 2012-11-13 11:50:50 +0000
> @@ -1185,7 +1185,7 @@
> font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes)
> {
> char *p;
> - const char *f[XLFD_REGISTRY_INDEX + 1];
> + char *f[XLFD_REGISTRY_INDEX + 1];
This will provoke warnings that are turned into errors with
--enable-gcc-warnings. There is no need for that, just use a temporary
variable (there is already one above that is perfectly suitable).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-11-13 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 15:15 bug#12823: Invalid font name Stefan Monnier
2012-11-07 16:52 ` Jan Djärv
2012-11-09 14:07 ` Kenichi Handa
2012-11-13 11:55 ` Kenichi Handa
2012-11-13 19:25 ` Andreas Schwab [this message]
2012-11-15 13:30 ` Kenichi Handa
2012-11-27 14:26 ` Kenichi Handa
2012-11-27 15:10 ` Stefan Monnier
2012-11-28 9:20 ` Kenichi Handa
2012-11-28 14:57 ` Stefan Monnier
2012-12-03 9:21 ` Kenichi Handa
2012-12-03 17:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2390db90y.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=12823@debbugs.gnu.org \
--cc=handa@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.