From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sebastian Wiesner Newsgroups: gmane.emacs.bugs Subject: bug#14967: 24.3.50; package-delete deletes by trashing? Date: Sat, 27 Jul 2013 12:30:15 +0200 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1374924971 2959 80.91.229.3 (27 Jul 2013 11:36:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Jul 2013 11:36:11 +0000 (UTC) To: 14967@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 27 13:36:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V32nE-0004N2-1A for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2013 13:36:12 +0200 Original-Received: from localhost ([::1]:55568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32nD-0000ld-LR for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2013 07:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32n7-0000lQ-TV for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:36:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V32n5-00075a-JW for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:36:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32n5-00075W-F9 for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V32n4-0000kS-Ru for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2013 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13749249422570 (code B ref -1); Sat, 27 Jul 2013 11:36:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Jul 2013 11:35:42 +0000 Original-Received: from localhost ([127.0.0.1]:52468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V32mj-0000fK-Oo for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48576) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V32mg-0000dW-RL for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V32mZ-0006y6-RC for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:33 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32mZ-0006xo-MX for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32mY-0000P5-5j for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:35:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V32mX-0006x8-4M for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:35:30 -0400 Original-Received: from mail-bk0-x230.google.com ([2a00:1450:4008:c01::230]:35752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V31lU-0000Gz-Ru for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 06:30:20 -0400 Original-Received: by mail-bk0-f48.google.com with SMTP id jf3so1421492bkc.7 for ; Sat, 27 Jul 2013 03:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Zxh4Rbwy1jYoS6xlfb/KomZpYab1CVk9RIfuKL482FM=; b=GgNU/USKY53sWSwYdvLI0suDkmMK6Lgc74ts3OO3wT66WTcqBjMudYpI//ZVLHfCzJ +QUvh4F9hSzYVWdBr58IBFdurdNhdPVxpC5sMDe85hZpx7iyko0UV9AQ9emotYn60WaX 7jDsWimBa0LQDpJo8vUMyjT2HlJY2TQT4iETFMaCJLa+D5gSi+mLotf+4fRmmi99QqH2 S8qBZDJb8jH1C/J6Mof+hhEY60PF/hcL9GJC4vFxivcQwzcios/n4WRlQ3Gbv22IaJZo zqNH9HWy/fVjkEG/2w5OK8SQkadwO7g/ipospHbcX60FDj2AsoBoB5jQKnpVJw5oVfcT bADw== X-Received: by 10.204.182.208 with SMTP id cd16mr7579744bkb.88.1374921019833; Sat, 27 Jul 2013 03:30:19 -0700 (PDT) Original-Received: from lunaryorn-air.fritz.box (p57995C19.dip0.t-ipconnect.de. [87.153.92.25]) by mx.google.com with ESMTPSA id l11sm13418062bkk.13.2013.07.27.03.30.18 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 27 Jul 2013 03:30:19 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76703 Archived-At: Currently "package-delete" from package.el is implemented as follows: (defun package-delete (pkg-desc) (let ((dir (package-desc-dir pkg-desc))) (if (not (string-prefix-p (file-name-as-directory (expand-file-name package-user-dir)) (expand-file-name dir))) ;; Don't delete "system" packages. (error "Package `%s' is a system package, not deleting" (package-desc-full-name pkg-desc)) (delete-directory dir t t) ;; Update package-alist. (let* ((name (package-desc-name pkg-desc))) (delete pkg-desc (assq name package-alist))) (message "Package `%s' deleted." (package-desc-full-name pkg-desc))))) Note that the call to "delete-directory" gives t as the 3rd argument, thus allowing for deletion by moving to trash depending on "delete-by-moving-to-trash". Is that intended behavior? If so, what is the rationale behind it?