From: Sebastian Wiesner <swiesner@lunaryorn.com>
To: 18157@debbugs.gnu.org
Subject: bug#18157: 24.4.50; battery-pmset fails to report critical battery state
Date: Thu, 31 Jul 2014 15:16:44 +0200 [thread overview]
Message-ID: <m238dhmzwj.fsf@lunaryorn.com> (raw)
`battery-pmset' fails to correctly report critical battery state: Even
if the battery charge level is below `battery-load-critical', it reports
"low" battery state only.
The culprit is the `cond' expression in the body of `battery-pmset'
which compares the reported `load-percentage' against `battery-load-low'
first, and then against `battery-load-critical'.
Since the latter is typically lower, it will never be reached, because
`cond' already returns after the former succeeded.
To fix this issue, `batter-pmset' needs to check `battery-load-critical'
*first*, and then `battery-load-low'.
next reply other threads:[~2014-07-31 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 13:16 Sebastian Wiesner [this message]
2016-02-16 14:56 ` bug#18157: 24.4.50; battery-pmset fails to report critical battery state Marcin Borkowski
2016-02-16 18:41 ` Sebastian Wiesner
2016-02-16 19:04 ` Eli Zaretskii
2016-02-20 5:51 ` John Wiegley
2016-02-16 23:43 ` Marcin Borkowski
2016-02-20 7:36 ` Lars Ingebrigtsen
2016-02-20 7:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m238dhmzwj.fsf@lunaryorn.com \
--to=swiesner@lunaryorn.com \
--cc=18157@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.