From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#27114: 25.2: fringe click echoes "Emacs-Lisp:" in emacs-lisp mode Date: Sun, 20 Aug 2017 16:14:40 +0200 Message-ID: References: <87y3te2awi.fsf@users.sourceforge.net> <838tldee8x.fsf@gnu.org> <87fud0731u.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503238516 18143 195.159.176.226 (20 Aug 2017 14:15:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 Aug 2017 14:15:16 +0000 (UTC) Cc: 27114@debbugs.gnu.org, npostavs@users.sourceforge.net To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 20 16:15:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djR0N-00049V-Jl for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Aug 2017 16:15:07 +0200 Original-Received: from localhost ([::1]:53026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djR0U-00073Z-8l for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Aug 2017 10:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djR0O-00072K-2P for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:15:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djR0J-0004RZ-4r for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:15:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djR0J-0004RT-0p for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djR0I-00064D-Ij for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2017 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27114-submit@debbugs.gnu.org id=B27114.150323849023288 (code B ref 27114); Sun, 20 Aug 2017 14:15:02 +0000 Original-Received: (at 27114) by debbugs.gnu.org; 20 Aug 2017 14:14:50 +0000 Original-Received: from localhost ([127.0.0.1]:46763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djR06-00063X-5f for submit@debbugs.gnu.org; Sun, 20 Aug 2017 10:14:50 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:38302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djR03-00063L-Uc for 27114@debbugs.gnu.org; Sun, 20 Aug 2017 10:14:48 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 4DCD9224FF for <27114@debbugs.gnu.org>; Sun, 20 Aug 2017 14:08:54 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1503238133; x=1504102134; bh=cE34uNXkeT2Xs Ro4sTXsHUHns3RC9XowM4dqn1VUFn8=; b=ZkbUZli+4WVthIaZNFVdyQ1MrRvjT 02i7UCJgatTH/H4HOC1ZPgl0zoymEJ+b3Atbn4/jTAuhjwB/j8MBWsy9u4bIOuuJ J0AZbM53TV4rna0EySv37Pjso9pzJYdZvyFZIKJMUfLWXf19yQOU2khhd3anhxOj XhPvH9pBIUVhlA= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kpqkh4NOFPnN for <27114@debbugs.gnu.org>; Sun, 20 Aug 2017 14:08:53 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id BE7BC224EA; Sun, 20 Aug 2017 14:08:52 +0000 (UTC) In-reply-to: <87fud0731u.fsf@lylat> (message from Alex on Wed, 09 Aug 2017 17:07:57 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135937 Archived-At: > From: Alex > Date: Wed, 09 Aug 2017 17:07:57 -0600 > > The following diff appears to fix this bug, but I'm not sure if it > should be applied. Hopefully it helps either way. > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index b3f452ca5b..1d90fa94f3 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -45,7 +45,7 @@ emacs-lisp-mode-syntax-table > "Syntax table used in `emacs-lisp-mode'.") > > (defvar emacs-lisp-mode-map > - (let ((map (make-sparse-keymap "Emacs-Lisp")) > + (let ((map (make-sparse-keymap)) > (menu-map (make-sparse-keymap "Emacs-Lisp")) > (lint-map (make-sparse-keymap)) > (prof-map (make-sparse-keymap)) Thanks for finding this out. The function that prints "Emacs-Lisp:" to the echo area during the click is "read_char_minibuf_menu_prompt" (keyboard.c), which calls Fkeymap_prompt (which in the scenario of this bug, returns "Emacs-Lisp"), and eventually executes these lines: /* Prompt with that and read response. */ message3_nolog (apply1 (intern ("concat"), Fnreverse (menu_strings))); Maybe it's wrong for "read_char" to call this function ("read_char_minibuf_menu_prompt") for some click events. For reference, the backtrace is here: #0 read_char_minibuf_menu_prompt (map=, commandflag=) at keyboard.c:8697 #1 read_char (commandflag=1, map=4342105123, prev_event=30432, used_mouse_menu=0x7fff5fbff40f, end_time=0x0) at keyboard.c:2550 #2 0x00000001000c0676 in read_key_sequence (keybuf=0x7fff5fbff4c0, bufsize=30, prompt=0, dont_downcase_last=false, can_return_switch_frame=true, fix_current_buffer=true, prevent_redisplay=false) at keyboard.c:9151 #3 0x00000001000c202c in command_loop_1 () at keyboard.c:1372 #4 0x000000010012ac53 in internal_condition_case (bfun=0x1000c1d30 , handlers=, hfun=0x1000ba260 ) at eval.c:1323 #5 0x00000001000b7c38 in command_loop_2 (ignore=) at keyboard.c:1114 #6 0x000000010012acd7 in internal_catch (tag=, func=0x1000b7c10 , arg=0) at eval.c:1088 #7 0x00000001000b73a8 in command_loop () at keyboard.c:1093 #8 0x00000001000b7489 in recursive_edit_1 () at keyboard.c:699 #9 0x00000001000ba551 in Frecursive_edit () at keyboard.c:770 #10 0x00000001000affe8 in main (argc=2, argv=0x7fff5fbff950) at emacs.c:1706