From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Tue, 18 Dec 2018 09:49:55 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <837eg8dpd6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545122885 11506 195.159.176.226 (18 Dec 2018 08:48:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Dec 2018 08:48:05 +0000 (UTC) Cc: ari.roponen@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 18 09:48:01 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZB2m-0002q3-2s for ged-emacs-devel@m.gmane.org; Tue, 18 Dec 2018 09:48:00 +0100 Original-Received: from localhost ([::1]:52609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZB4s-0005jr-Fl for ged-emacs-devel@m.gmane.org; Tue, 18 Dec 2018 03:50:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZB4l-0005ja-LN for emacs-devel@gnu.org; Tue, 18 Dec 2018 03:50:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZB4h-0003LS-GB for emacs-devel@gnu.org; Tue, 18 Dec 2018 03:50:03 -0500 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:40654) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZB4h-0003Kp-8y; Tue, 18 Dec 2018 03:49:59 -0500 Original-Received: by mail-wm1-x32f.google.com with SMTP id f188so1179603wmf.5; Tue, 18 Dec 2018 00:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=YPHkjkt4TTwbfKSDTtvgkLagCItbXKypm3siSInUBcw=; b=L7Cz6nGboe5lW1pnQe/qc13sPyGIH1TI47NOiiJoC4VdgdZjgaQ5Pbi2DDAJJl0jz4 WgzEzOdX96lP3M6x9qGnKICkgfLxxucHX9GDxQHMokVpFkVA0xn8exA4HQOih4v/ztAG 33lgLegvaA40XHPjKIhF95b2VqZnit5zV3d7Wm/qdRXY+l/YyzMakg1ohRzzhxJTZ6hZ mEoYaswcqJGAgKmoCBf3nHDT7QOm+CQu0JUtCjgAvK7SWyItHh6CFyw7gmH0TR6uFR4D EdOnwTPn8WCg/pUzIa0MYXYw0BUWR77oKXYS106dLHob/gHX/i7SLOfy15G8RtHwVSgn NvmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=YPHkjkt4TTwbfKSDTtvgkLagCItbXKypm3siSInUBcw=; b=MDG9E+VAkzWtgK2BqA0+CjV6XxEXBb69uaUKKG4LeW9e5nwMg+nFloaWEsGic11+vU ipd8DWOTiCMNDhLPqMCphfSQW1PKLiVgtJfyxLcDrwWP4vTZFzxQhkHn4Os1SJbwT/JL J+asWP7shAV6vtYxyXoeIcwJlnqcZwxTiTvIQEckbTZn0QKBogMlP8Y4sHz7C9mkAVDL tZv72ZSE2k7HDTIfTkudQGgR5lIKK9y4s0ty+jcNocJb12uncm0qLpKvd10aFBZLDPA4 DSiYFu/x7nvG5CRRZ/+BnhzFqKfU8lX59P6wscmXMRT/FUIngF8sE0Cy6Rr6UjASp+fR O71A== X-Gm-Message-State: AA+aEWbviJ19g9Gk9/s3rHb8HV6wR6xAun4L4fRDNOslcqvRJc7zVWEz R0x0wbUs7u42xBbTzAFJs9Co7Sk6 X-Google-Smtp-Source: AFSGD/WBbufTUKVOKndG4O/Q2wqEdC7/zxySPR1VDvP65ZSF2kzBpIyFA/xmU5uRokZEnBCG6/6uZw== X-Received: by 2002:a1c:9183:: with SMTP id t125mr2149811wmd.79.1545122997802; Tue, 18 Dec 2018 00:49:57 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id l14sm5762548wrp.55.2018.12.18.00.49.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 00:49:56 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <837eg8dpd6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 Dec 2018 19:39:33 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231901 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: emacs-devel@gnu.org, ari.roponen@gmail.com >> Date: Mon, 17 Dec 2018 13:41:11 +0100 >>=20 >> >> Aligning ftfont.c and ftcrfont.c is pretty easy. Did you want me to >> >> try to unify xftfont.c in there as well? >> > >> > If that makes sense, i.e. if the commonality seems to justify that, >> > then yes. >> > >>=20 >> I had a quick go at this. I=CA=BCve not measured the memory difference, = but >> I can do if people thinks this refactor is worth it. Apart from the >> unification of the three struct definitions, most of the patch is >> mechanical changes. > > Thanks, this LGTM, and is a significant improvement, IMO. If no one > objects in a few days, please push. > > P.S. Will this have any problems with the harfbuzz branch? Apart from having to adjust the addition to the struct in question done on the harfbuzz branch, I don=CA=BCt think so. Probably there will be a merge conflict, I can help out with that if needed. Robert