all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: master d57bb0c: Treat passed strings as raw-text when percent-escaping in epg
Date: Thu, 12 Dec 2019 17:39:24 +0100	[thread overview]
Message-ID: <m236dpwlab.fsf@gmail.com> (raw)
In-Reply-To: <mvmfthpec67.fsf@suse.de> (Andreas Schwab's message of "Thu, 12 Dec 2019 17:33:36 +0100")

>>>>> On Thu, 12 Dec 2019 17:33:36 +0100, Andreas Schwab <schwab@suse.de> said:

    Andreas> On Dez 12 2019, Robert Pluim wrote:
    >> epg--decode-percent-escape replace the escapes with the corresponding
    >> characters, so now we have
    >> 
    >> "üé"

    Andreas> That is were it went wrong.  You need to decode the sequence before
    Andreas> splicing it into the string.  Mixing encoded and decoded data is not
    Andreas> going to do the right thing.

I didnʼt write the code in question. Whoever did understandably didnʼt
want to write code for converting variable length percent-escapes into
the corresponding characters when emacs has decode-coding-string
already.

Robert



  reply	other threads:[~2019-12-12 16:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191212073737.19923.49084@vcs0.savannah.gnu.org>
     [not found] ` <20191212073738.9C7A3200E3@vcs0.savannah.gnu.org>
2019-12-12 13:58   ` master d57bb0c: Treat passed strings as raw-text when percent-escaping in epg Stefan Monnier
2019-12-12 15:19     ` Robert Pluim
2019-12-12 15:28       ` Eli Zaretskii
2019-12-12 15:33         ` Robert Pluim
2019-12-12 15:36           ` Eli Zaretskii
2019-12-12 15:30       ` Robert Pluim
2019-12-12 15:45         ` Eli Zaretskii
2019-12-12 16:17           ` Robert Pluim
2019-12-16 16:06           ` Stefan Monnier
2019-12-12 15:42       ` Andreas Schwab
2019-12-12 16:11         ` Robert Pluim
2019-12-12 16:33           ` Andreas Schwab
2019-12-12 16:39             ` Robert Pluim [this message]
2019-12-12 16:55               ` Andreas Schwab
2019-12-12 17:57           ` Eli Zaretskii
2019-12-13  9:40             ` Robert Pluim
2019-12-13 10:33               ` Eli Zaretskii
2019-12-16 16:21       ` Stefan Monnier
2019-12-16 16:38         ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m236dpwlab.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.