From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#70796: 30.0.50; bug-reference-mode leading to constant GCing Date: Sat, 25 May 2024 06:34:03 +0200 Message-ID: References: <86ttjbb1pu.fsf@gnu.org> <86msp3avh1.fsf@gnu.org> <86bk53fsq1.fsf@gnu.org> <87sey7dlq7.fsf@gnu.org> <87msoerj1b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20580"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 70796@debbugs.gnu.org, yantar92@posteo.net To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 06:36:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAj8i-00059R-Te for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 06:36:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAj8P-0005jO-99; Sat, 25 May 2024 00:35:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAj8N-0005jA-6l for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 00:35:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAj8M-0003Ya-Tx for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 00:35:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAj8T-00022e-NG for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 00:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 04:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70796 X-GNU-PR-Package: emacs Original-Received: via spool by 70796-submit@debbugs.gnu.org id=B70796.17166117217841 (code B ref 70796); Sat, 25 May 2024 04:36:01 +0000 Original-Received: (at 70796) by debbugs.gnu.org; 25 May 2024 04:35:21 +0000 Original-Received: from localhost ([127.0.0.1]:40988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAj7p-00022P-AH for submit@debbugs.gnu.org; Sat, 25 May 2024 00:35:21 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:48387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAj7m-00022H-JV for 70796@debbugs.gnu.org; Sat, 25 May 2024 00:35:19 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-57857e0f465so1398919a12.1 for <70796@debbugs.gnu.org>; Fri, 24 May 2024 21:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716611645; x=1717216445; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=JXdUYJwS4FfXjK3c9mRhjI01TVRlJAiz294glwdO7Tk=; b=kh/kxVqP7q+x260wlfw0O7vAfGM6LhO85SAioSS6zPgc/JGAH4jTJOK8QJnKUXFS8e yJFzwckOoTf0u5EZRJHXLRcGQMuyat/B2EA65e+3pBCHYPWGki+NkUk5yTdDHIQFNici ApftTJoZOMc1RBqFgCGKV/bA1kFMIHY9uBZvv2IxYzyHbg/ywstnL3a9vUYTc+kRzH1v rAa1BOc8/M+WIPcqK+Xz5Gc2sMeuYNq9dj0ZfRhGVDYsVDMn5PPXFFrxV3vTUYCAZ3PE A7XyFDo5F4+mP9S3yqQlUSge5pjcRAJmVA9X72/ome4dPCaC0Bn3h+/Nd4f2weRK1wzV VPWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716611645; x=1717216445; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JXdUYJwS4FfXjK3c9mRhjI01TVRlJAiz294glwdO7Tk=; b=S4Iumn1mukUgWmTgp+OQQmeJZWG0wcxwYL2F6ZwZlXJRrZNszIxYEGh+Eq9nA0zp7C YZj4fM9+e23z3+kaJLceuw76WVbB/duqXFDaMWscy7NciqLQR/twd7ioUgWAWLXjMMnA evLQzZHT4dp33NUMAKCM8en7v54HTUh0ezRrMo+SfVq0r2JQPcaYcmBau4A9GYi8hF17 eZLmYlcoAuIVMJZs62ua6v4I2iaxqagwVGe2ONE2wYcfSUWgFEvf/cZBY6P+ToNNH+Gd 3kWEzJ/huW2bcSfg9ocoJTCwrEpN8AQ5uvlJr7+pkmQr6TpFy/t/awUpa1NFds+dKkhY bPiQ== X-Forwarded-Encrypted: i=1; AJvYcCWzhfEFMmqiiG9s+XfxaiCrXVrdR7hyAiLdZGuD8S0HNkaOOCCKmvgKCZpJKhfeWalwCngGPA/s4QvbD42JPYu+g86Cloo= X-Gm-Message-State: AOJu0YwKHKNbQOV+fsjhPTMfkwsOKtvge/HFBd7CRL+IUfZHEWp0K2aQ +if/6M98qNFXSYYbDpQS4C7CdvquYg24JN+zSTX3v7qqD/sMsQwITbCh3g== X-Google-Smtp-Source: AGHT+IFsftg7I1GRxeR3z8oPtG4vuHqbiTol5BePZoUG4T2Qa4YHnZM2qqKMcYLDJURM7ARqqm0xSw== X-Received: by 2002:a50:8d04:0:b0:570:db4:e5cd with SMTP id 4fb4d7f45d1cf-578519a2248mr2761814a12.34.1716611644873; Fri, 24 May 2024 21:34:04 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a89b.dip0.t-ipconnect.de. [79.227.168.155]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5785233a118sm2649999a12.16.2024.05.24.21.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 21:34:04 -0700 (PDT) In-Reply-To: <87msoerj1b.fsf@gnu.org> (Tassilo Horn's message of "Fri, 24 May 2024 23:34:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285812 Archived-At: --=-=-= Content-Type: text/plain Tassilo Horn writes: > But anyhow, I don't see how bug-reference-fontify could be so costly > GC-wise... It is not by itself, AFAICT. Org fontification allocates which ich not a problem normally, but with bug-reference active, it is triggered over and over again. Interesting observation: I just built master without native compilation because that's faster. With .elcs only, I don't seem to get the constant GCs with 9ebe6aa5f1092241a98e0a16db918e3dc1062f1c which is before your fix. With native compilation I do. Just double-checked that this is indeed the case. Now it gets interesting :-/. This is on macOS 14.5, arm64, libgccjit 14.1. > FWIW, I think goto-address-mode (buttonizing URLs and email addresses) > will probably have the same effect, at least the code looks pretty > similar. Can you confirm? Yes, goto-address-mode has the same effect. > > I'll have a look at you sample file tomorrow. How do you make GCs > "visible" so that I can see when excessive GCing starts/stops? You can use the attached patch to log GC messages in *Messages* which makes it easier to see. Then load the Org file, expand all nodes (S-TAB as needed), move a bit around, and see it happening. And set garbage-collection-messages to t of course. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-On-no-branch-9ebe6aa5f10-lisp-dired.el-dired-mode-map-Bind-E-to-dired-do-open-bug-18132.patch Content-Description: gc-messages diff --git a/src/alloc.c b/src/alloc.c index 28e32554472..7911078ba59 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -6584,7 +6584,7 @@ garbage_collect (void) #endif /* MAX_SAVE_STACK > 0 */ if (garbage_collection_messages) - message1_nolog ("Garbage collecting..."); + message1 ("Garbage collecting..."); block_input (); @@ -6689,7 +6689,7 @@ garbage_collect (void) if (message_p || minibuf_level > 0) restore_message (); else - message1_nolog ("Garbage collecting...done"); + message1 ("Garbage collecting...done"); } unbind_to (count, Qnil); --=-=-=--