From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: unable to build due to assertion violation in igc_dump_check_object_starts Date: Tue, 23 Jul 2024 21:25:38 +0200 Message-ID: References: <861q3k9sfb.fsf@gnu.org> <86y15s893y.fsf@gnu.org> <86ttgg867k.fsf@gnu.org> <86ikww7zvf.fsf@gnu.org> <86h6cg7y59.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27893"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , eller.helmut@gmail.com, emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 23 21:26:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWL9h-00074A-Er for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Jul 2024 21:26:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWL8r-0006z0-JC; Tue, 23 Jul 2024 15:25:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWL8p-0006yb-Sh for emacs-devel@gnu.org; Tue, 23 Jul 2024 15:25:43 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWL8o-0006cF-9V; Tue, 23 Jul 2024 15:25:43 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-367990aaef3so3138698f8f.0; Tue, 23 Jul 2024 12:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721762740; x=1722367540; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OVV2LhyMehDs7KoTzi0RN+hosRCRuzxRk8e5FjIE59k=; b=TZ1Ma8Qj5SPezsN8SZiSCB9sc9jeTi3eQCJ6ecWXdcJKunV+qOVI33QL+ENuKvyXQT kef4jdGNszYCFcgClp2iD4XSKJkOM/aoah63cDn41FLKZJ2FsvwK5YrC1hQ4C/2AnkNA QDgKz4wcGATv6J580pgA9T1pTHPoQAE5n64UiwmiEcAqdEbobiJf7G6tSIeNPjSGG+Km SBy2TqrgztXoNKPzxvLp8y4W+drvJxuXW3/wmf4FAHAwPUkbJGUAf8xUKJQb1UpgaeNA 8pWGrsXYxYWXr1vESOac8c433BrsyTNA+biwqZ5m1MYyoaLyVS5bVYXgMa8HJFiuzspB c6oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721762740; x=1722367540; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OVV2LhyMehDs7KoTzi0RN+hosRCRuzxRk8e5FjIE59k=; b=DdE+wZMW76ySxU0MQ1gIYETDJfGh/fzCcxH0FDT5zsR3VAgEU+X8V6DnGISgHvoGCF M3gGuDIkLKkYQOE4/FXH7LXGjVTeVwje2UKTV5KtxMNoti0w6Q+PsjZYoQ+fbKn8PskV WeTdMKQgsVId2auS9sdc5TwitMcOocuL5tHXJ3SLedhNRib+86eH06KeN7i5ZrwuC7TN YCcgtsDheYoGGgFPR+LxcMKeXC/9gH+OtiYrPugQmabDeOrW1aQxeGFfZlQbVYJm8EzH wVV0zQNXsMfGbzFGq8WmvMgMY6xgAiNd8CHt/9FWT4+dwmgOLpqSQk2GHTK3L76zzar7 yhSQ== X-Forwarded-Encrypted: i=1; AJvYcCVze1AQgzn+6zp3zhFAA1fQ271H7uRh/M9rsvCtUvr4gC1C3nSKLCBXDThcWAgB4/EpoJLtBGoTq3/S1Z2P0oyVlNlp X-Gm-Message-State: AOJu0YyKfH42lFsiA5IMzTv/D12tXANQMV4DREggIF1a5ecjCnL04T5C Xei8fCNQtTMImH/6dTCqTKMSUTEX3G+gLKEWChauan9z5VWmeWiJmDXv+Q== X-Google-Smtp-Source: AGHT+IHB4XobZHjzw6lJ4g5RGQ6pTqbu5C2hsZRaxGxDQ1odY07YxEVnebINv+6G4qKgYH/5jQEI4g== X-Received: by 2002:adf:f5d1:0:b0:368:37d5:3f2e with SMTP id ffacd0b85a97d-369dec1dab0mr2732227f8f.32.1721762739865; Tue, 23 Jul 2024 12:25:39 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e3603f.dip0.t-ipconnect.de. [217.227.96.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a3c09csm213086605e9.9.2024.07.23.12.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jul 2024 12:25:39 -0700 (PDT) In-Reply-To: (Pip Cet's message of "Tue, 23 Jul 2024 19:12:49 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=gerd.moellmann@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322014 Archived-At: Pip Cet writes: > On Tuesday, July 23rd, 2024 at 18:48, Gerd M=C3=B6llmann wrote: >> Pip Cet pipcet@protonmail.com writes: >>=20 >> > On Tuesday, July 23rd, 2024 at 18:37, Eli Zaretskii eliz@gnu.org wrote: >> >=20 >> > > So this is IGC_OBJ_STRING_DATA, but why doesn't igc_dump_finish_obj = do >> > > its job in this case? What are we missing? >> >=20 >> > I'm pretty sure it's the bignum thing, currently testing a fix. I >> > underestimated the complexity of how bignums are dumped, and wrongly >> > assumed that on 64-bit systems, we would be dumping bignums; it seems >> > we don't do so anymore. (BIGNUM_DATA, unlike the bignum PVEC, doesn't >> > have a header; it should, and if I add bignums to the dump manually >> > things work now...). >> >=20 >> > Pip >>=20 >>=20 >> Ok, good to hear :-). > > Here's a patch which includes both a reproducer for the bug (defining a g= lobal bignum in loadup.el which then gets dumped) and a tentative fix. > > If bignum dumping is indeed broken on all architectures, including > just the change to loadup.el should reproduce the bug even on 64-bit > archs. I've added the bignum to loadup.el. Dumping doesn't complain, but after that ANCIENT=3Dyes gmake -C ../lisp compile-first EMACS=3D"../src/bootstrap-em= acs" ELC emacs-lisp/macroexp.elc ELC emacs-lisp/cconv.elc ELC emacs-lisp/byte-opt.elc ELC emacs-lisp/bytecomp.elc ELC emacs-lisp/loaddefs-gen.elc ELC emacs-lisp/radix-tree.elc /Users/gerd/emacs/github/mps/code/poolamc.c:1288: Emacs fatal error: asse= rtion failed: p < q /Users/gerd/emacs/github/mps/code/poolamc.c:1288: Emacs fatal error: asse= rtion failed: p < q /Users/gerd/emacs/github/mps/code/poolamc.c:1288: Emacs fatal error: asse= rtion failed: p < q /Users/gerd/emacs/github/mps/code/poolamc.c:1288: Emacs fatal error: asse= rtion failed: p < q /Users/gerd/emacs/github/mps/code/poolamc.c:1288: Emacs fatal error: asse= rtion failed: p < q /Users/gerd/emacs/github/mps/code/poolamc.c:1288: Emacs fatal error: asse= rtion failed: p < q gmake[3]: *** [Makefile:335: emacs-lisp/bytecomp.elc] Abort trap: 6 Will apply the whole patch and report back.