From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: org-review-schedule
Date: Sat, 26 Apr 2014 10:57:40 +0200 [thread overview]
Message-ID: <m21twkbh8b.fsf@polytechnique.org> (raw)
In-Reply-To: <87fvl1lx50.fsf@gmail.com> (Nicolas Goaziou's message of "Fri, 25 Apr 2014 08:51:39 +0200")
Hi Nicolas,
I've changed all of these, and I will keep testing it over the next few
days. I have one question remaining, though.
On 2014-04-25 08:51, Nicolas Goaziou <n.goaziou@gmail.com> writes:
>> (if (time-less-p nt (current-time)) nt)))))
>
> This is a matter of taste, but I find one-armed `if' a bit confusing.
> Since return value matters, I suggest to use
>
> (and (time-less-p nt (current-time)) nt)
Why not use "(when (time-less-p nt (current-time)) nt)" instead of "and"
here?
Thanks,
Alan
next prev parent reply other threads:[~2014-04-26 9:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 20:27 org-review-schedule Alan Schmitt
2014-04-19 8:14 ` org-review-schedule Bastien
2014-04-19 11:16 ` org-review-schedule Alan Schmitt
2014-04-19 11:51 ` org-review-schedule Bastien
2014-04-24 11:51 ` org-review-schedule Alan Schmitt
2014-04-25 6:51 ` org-review-schedule Nicolas Goaziou
2014-04-25 7:43 ` org-review-schedule Alan Schmitt
2014-04-25 8:02 ` org-review-schedule Nicolas Goaziou
2014-04-27 8:09 ` org-review-schedule Alan Schmitt
2014-04-28 7:20 ` org-review-schedule AW
2014-04-28 11:29 ` org-review-schedule Alan Schmitt
2014-05-06 9:27 ` org-review-schedule Bastien
2014-05-15 10:07 ` org-review-schedule Bastien
2014-05-20 12:48 ` org-review-schedule Alan Schmitt
2014-05-21 12:08 ` org-review-schedule Bastien
2014-05-21 12:58 ` org-review-schedule Alan Schmitt
2014-04-26 8:57 ` Alan Schmitt [this message]
2014-04-26 10:38 ` org-review-schedule Thorsten Jolitz
2014-04-26 12:25 ` org-review-schedule Nicolas Goaziou
2014-04-27 8:08 ` org-review-schedule Alan Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21twkbh8b.fsf@polytechnique.org \
--to=alan.schmitt@polytechnique.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.