From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.devel Subject: Re: dired: make dired-maybe-insert-subdir always skip trivial files Date: Thu, 25 Dec 2014 22:51:10 +0300 Message-ID: References: <87k31fh7nd.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1419537103 7848 80.91.229.3 (25 Dec 2014 19:51:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Dec 2014 19:51:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 25 20:51:37 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y4ERb-00078n-ST for ged-emacs-devel@m.gmane.org; Thu, 25 Dec 2014 20:51:36 +0100 Original-Received: from localhost ([::1]:51685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4ERb-0005cj-7A for ged-emacs-devel@m.gmane.org; Thu, 25 Dec 2014 14:51:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4ERN-0005cb-R5 for emacs-devel@gnu.org; Thu, 25 Dec 2014 14:51:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4ERK-0004hw-Ks for emacs-devel@gnu.org; Thu, 25 Dec 2014 14:51:21 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4ERK-0004hq-DE for emacs-devel@gnu.org; Thu, 25 Dec 2014 14:51:18 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 06BDB2095E for ; Thu, 25 Dec 2014 14:51:17 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Thu, 25 Dec 2014 14:51:18 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=iXOeXchWrC2C oSLnRZsL+fDhB+I=; b=QUqnD+eskqQAFuQauedwbVLUCzF6JOYmSvILsrj7fiQL PzEoza4mzHOTEwCJcqJKsRMBgf8iFtUsCBVRwTI/bCV9RdVE6rdqDKBnB9DFai/Z xNOFL3qP+zumXyWvYzhWxzFGhqJxH2s+cgWELwwylB1R6pVCa25OwAhBqW/M3YE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=iXOeXchWrC2CoSLnRZsL+fDhB+I=; b=CwvMEOGJVGzdrOpcEGpt ddZ0yEaCGY14uXLrsgqqwkOzywTOpL1MiwmkhHRjiycHqwRktAlPHG+rx/N/WN6C yX8M6cRuAtH1gfrI/itFRkE7kx7GxmV4U2Ir7NNPMrzPAJf5mxUIEN75W/dYR+nt uE7ih+1MSJR27V6qkvnS0z8= X-Sasl-enc: 2+EctyC00NdWMfvuVdWsFx7j8YSzuTCknrLRYwQhKwEf 1419537077 Original-Received: from fgunbin.local (unknown [178.66.149.225]) by mail.messagingengine.com (Postfix) with ESMTPA id 107AAC00281; Thu, 25 Dec 2014 14:51:15 -0500 (EST) In-Reply-To: <87k31fh7nd.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 25 Dec 2014 21:32:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (darwin) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180669 Archived-At: On 25/12/2014 21:32 +0200, Juri Linkov wrote: >> - (dired-goto-subdir dirname)) >> + (when (dired-goto-subdir dirname) >> + (unless (dired-subdir-hidden-p dirname) >> + (dired-initial-position dirname)) >> + t)) > > Why do you always return t? Wouldn't it be better to use something like > (prog1 (dired-goto-subdir dirname) (unless ...)) This way, (unless ...) will be evaluated even if `dired-goto-subdir' returned nil. Filipp