From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 28936@debbugs.gnu.org
Subject: bug#28936: move_it_in_display_line_to returns MOVE_POS_MATCH_OR_ZV before ZV
Date: Sun, 22 Oct 2017 22:20:32 -0700 [thread overview]
Message-ID: <m21slufnj3.wl%esq@lawlist.com> (raw)
In-Reply-To: <m260b73mvx.wl%esq@lawlist.com>
I was able to verify this evening that it.current_x is indeed 0 immediately following a call to `move_it_by_lines (&it, 0)` when the issue is present.
It may be that move_it_in_display_line_to is reaching the correct X, but is merely throwing the wrong label/result in this situation -- i.e., it is not really reaching a POS or ZV. Since my loop was relying on the label/result, the loop exited too early. To test the correct X and wrong label/result theory, would take some time for me to work on because I would like to find the precise location inside move_it_in_display_line_to where the label/result is being returned. I will continue to think about this and tinker ...
Keith
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
DATE: [10-22-2017 12:53:47] <22 Oct 2017 22:53:47 +0300>
FROM: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Sun, 22 Oct 2017 11:05:45 -0700
> > From: Keith David Bershatsky <esq@lawlist.com>
> > Cc: 28936@debbugs.gnu.org
> >
> > SET_TEXT_POS_FROM_MARKER (start_text_position, w->start);
> > start_display (&it, w, start_text_position);
> > move_it_to (&it, PT, it.last_visible_x, it.last_visible_y - 1, -1, MOVE_TO_POS | MOVE_TO_X | MOVE_TO_Y);
> > target_x = it.current_x;
> > move_it_by_lines (&it, 0);
>
> Did you verify that it.current_x is zero after this line? If not, you
> will not get to the right X coordnate here:
>
> > rc = move_it_in_display_line_to_x (w, &it, target_x);
next prev parent reply other threads:[~2017-10-23 5:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 3:02 bug#28936: move_it_in_display_line_to returns MOVE_POS_MATCH_OR_ZV before ZV Keith David Bershatsky
2017-10-22 5:14 ` Keith David Bershatsky
2017-10-22 14:12 ` Eli Zaretskii
2017-10-22 14:10 ` Eli Zaretskii
2017-10-22 18:05 ` Keith David Bershatsky
2017-10-22 18:30 ` Eli Zaretskii
2017-10-22 19:53 ` Eli Zaretskii
2017-10-22 19:22 ` bug#28936: nRe: " Keith David Bershatsky
2017-10-22 19:41 ` Eli Zaretskii
2017-10-23 5:20 ` Keith David Bershatsky [this message]
2017-10-23 13:55 ` Eli Zaretskii
2017-10-25 3:46 ` bug#28936: enhancement request: remove vertical scroll bar automatically when not needed Keith David Bershatsky
2017-10-25 5:30 ` Keith David Bershatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21slufnj3.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=28936@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.