From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.devel Subject: Re: tiny pdumper fix Date: Sat, 29 Sep 2018 13:30:59 +0200 Message-ID: References: Reply-To: charles@aurox.ch NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1538220365 11710 195.159.176.226 (29 Sep 2018 11:26:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Sep 2018 11:26:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 29 13:26:01 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6DNl-0002ry-UH for ged-emacs-devel@m.gmane.org; Sat, 29 Sep 2018 13:25:58 +0200 Original-Received: from localhost ([::1]:50417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6DPs-0008HQ-GI for ged-emacs-devel@m.gmane.org; Sat, 29 Sep 2018 07:28:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6DPm-0008HA-70 for emacs-devel@gnu.org; Sat, 29 Sep 2018 07:28:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6DPj-0003l5-RV for emacs-devel@gnu.org; Sat, 29 Sep 2018 07:28:01 -0400 Original-Received: from sinyavsky.aurox.ch ([2a03:2040:2:1b::1]:39322) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g6DPh-0003kD-RE for emacs-devel@gnu.org; Sat, 29 Sep 2018 07:27:59 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 5F88F22879 for ; Sat, 29 Sep 2018 11:31:51 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1538220709; x=1539084710; bh=Xl y5QE+QpljwEWy6v+8usxoR2N2s3/HtaVJnr+Q9VzI=; b=KPGGAqH12AZDkxGP5Q ytsg9Ho+c/dQedpWf6xUu4GsUDTuVAdO1NXtjpv1pb8Q+lOwjgCpzomU1+VGno5f avkD8F+9KLFuEA8LzpShPk0r1eR+O03blv1ofPPXnsZnjOmm3/7prUGdCuVvag5p m94b3R79dQyhTE9QK2kGdnmvA= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id N2ito85V3BWS for ; Sat, 29 Sep 2018 11:31:49 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 77425226F4; Sat, 29 Sep 2018 11:31:45 +0000 (UTC) In-reply-to: (message from Stefan Monnier on Fri, 28 Sep 2018 16:34:03 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a03:2040:2:1b::1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230133 Archived-At: > From: Stefan Monnier > Date: Fri, 28 Sep 2018 16:34:03 -0400 > > > I'd like to push this change to the pdumper branch to allow building > > on older macOS (less than 10.11, I think), where only MAP_ANON is > > defined: > > Hmm... looks like none of those people who know about pdumper or macOS > was available. Sorry. > I just installed you patch as is. > > > Is it well placed here, or does it belong in the header file instead? > > It probably belongs elsewhere, but I pushed it as-is, ACK, thanks. From the autoconf documentation, it looks like AC_CHECK_DECL may be useful here.