From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#32990: 26.1.50; isearch-forward + t-m-m/mark-active doc Date: Tue, 20 Nov 2018 20:49:39 +0100 Message-ID: References: <83muroyzfk.fsf@gnu.org> <83woqrx9pt.fsf@gnu.org> <835zy3tfrb.fsf@gnu.org> <83bm7pueej.fsf@gnu.org> <834ld6m5jk.fsf@gnu.org> <831s7tauzy.fsf@gnu.org> <87sgzzwisx.fsf@mail.linkov.net> <87o9ak4ttv.fsf@mail.linkov.net> Reply-To: charles@aurox.ch NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1542743200 4001 195.159.176.226 (20 Nov 2018 19:46:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Nov 2018 19:46:40 +0000 (UTC) Cc: 32990@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 20 20:46:36 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPByl-0000vB-Ch for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Nov 2018 20:46:35 +0100 Original-Received: from localhost ([::1]:35632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPC0s-0000AW-2G for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Nov 2018 14:48:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPC0H-0008FA-BH for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 14:48:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPC0B-0000Mo-Er for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 14:48:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPC0A-0000Le-7N for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 14:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPC0A-0006kr-4P for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 14:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Nov 2018 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32990-submit@debbugs.gnu.org id=B32990.154274326025105 (code B ref 32990); Tue, 20 Nov 2018 19:48:02 +0000 Original-Received: (at 32990) by debbugs.gnu.org; 20 Nov 2018 19:47:40 +0000 Original-Received: from localhost ([127.0.0.1]:37408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPBzo-0006Wb-A8 for submit@debbugs.gnu.org; Tue, 20 Nov 2018 14:47:40 -0500 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:36691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPBzl-0006Qm-KO for 32990@debbugs.gnu.org; Tue, 20 Nov 2018 14:47:38 -0500 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 96D4C229A4 for <32990@debbugs.gnu.org>; Tue, 20 Nov 2018 19:52:17 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1542743536; x=1543607537; bh=1u /7GHCc7cTAqYHYRZPeEV+0NnnsLCLxEmsjSrQEZ9w=; b=b80PqCNpkZr/Ag4fyQ AegnuYvfK8jsMWHgZ9oKSPQQsRnpk41QiniOH4b63tMlPR6yR7CQh28CLY/04wcv I1asBr0qojrU8HYOyW4ET/dNfcmPJiqdpHpDz32W3ItepHCtiZZ7E6OVadS125WQ GQEmEEBUWR4Az6zHvTB6VrEWc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z5oPO1RvX83e for <32990@debbugs.gnu.org>; Tue, 20 Nov 2018 19:52:16 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1205:34ff:bc50:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id AF18F228C2; Tue, 20 Nov 2018 19:52:15 +0000 (UTC) In-reply-to: <87o9ak4ttv.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 19 Nov 2018 23:44:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152587 Archived-At: > From: Juri Linkov > Date: Mon, 19 Nov 2018 23:44:04 +0200 > > Thanks, I tried, and have one suggestion: due to the long menu it > doesn't fit into the frame's height, so to click an item at the end of > the menu requires scrolling that takes time to scroll. I suggest to > create more submenus, for example, a Yank submenu for all yank commands. Thanks for testing. I made a Yank submenu as you suggest, which makes the menu height more reasonable. > I tried clicking Isearch items in the mode-line indicator such as > "Repeat search forward", but it cancels Isearch (and leaves Isearch > highlighting). Should be fixed in the next version of the change. (`isearch-mouse-leave-buffer' needed to allow command `mouse-minor-mode-menu'.) > > tmm-menubar (M-`)/TTY menus (F10 from TTYs) should now work as > > expected (no need to set `isearch-allow-scroll' to t). > > >From tmm I tried "C==>Cancel last input item DEL", but it does nothing. > Do you see the same? Yes. This may be `with-isearch-suspended's doing (as used in `isearch-tmm-menubar'): it pushes a new state of Isearch after running its arg BODY, so we will have to compensate for that somehow. > > (or (assq 'isearch-mode minor-mode-alist) > > (nconc minor-mode-alist > > - (list '(isearch-mode isearch-mode)))) > > + (list '(isearch-mode " Isearch")))) > > This duplicates the constant string " Isearch" in two places. > Why this change was necessary? It's no longer necessary and will be gone from the next version of the change. It was necessary because clicking the Isearch mode-line indicator was actually quitting Isearch. Fixed by the above change to `isearch-mouse-leave-buffer'. > > @@ -2564,7 +2788,8 @@ isearch-post-command-hook > > (when isearch-forward > > (goto-char isearch-pre-move-point)) > > (isearch-search-and-update))) > > - (setq isearch-pre-move-point nil)))) > > + (setq isearch-pre-move-point nil))) > > + (force-mode-line-update)) > > What problems caused adding force-mode-line-update? The menu- and tool-bars are not always updated after typing a character during Isearch, so some of the items in those keymaps may be wrongly displayed if we do not always force their recalculation.