From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 50c5d56: --with-cairo is no longer experimental Date: Tue, 12 Nov 2019 08:51:25 +0100 Message-ID: References: <20190619070851.22726.77187@vcs0.savannah.gnu.org> <20190619070853.E841E208EC@vcs0.savannah.gnu.org> <83imnygoyd.fsf@gnu.org> <83d0e5he3w.fsf@gnu.org> <837e4dgf30.fsf@gnu.org> <838sorg3ll.fsf@gnu.org> <83k18beh1b.fsf@gnu.org> <83tv7da6qf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="41753"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 12 08:51:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iUQxd-000AjB-Je for ged-emacs-devel@m.gmane.org; Tue, 12 Nov 2019 08:51:37 +0100 Original-Received: from localhost ([::1]:59898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUQxc-0002cX-Ao for ged-emacs-devel@m.gmane.org; Tue, 12 Nov 2019 02:51:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36112) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUQxV-0002cO-PP for emacs-devel@gnu.org; Tue, 12 Nov 2019 02:51:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUQxU-0007uk-H5 for emacs-devel@gnu.org; Tue, 12 Nov 2019 02:51:29 -0500 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:39407) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUQxU-0007sb-BJ; Tue, 12 Nov 2019 02:51:28 -0500 Original-Received: by mail-wm1-x333.google.com with SMTP id t26so1811684wmi.4; Mon, 11 Nov 2019 23:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=gjfIvRRsDGl+e6Ip6O6DhgCWq+6HKwzb1wpZnhHi+MI=; b=V39ygzXJn4d5muRk5XpQ7wJUf4JHE8YIpK7dNGF7b12WE6qS3e3kwKy60LECtUa32b uzF5LmFWrknC9xWLBGLHxrwtNDCarRkYK3ssWErCBgqklhcxDs47JHJsu/9XjJp3S4sA 3dew84KmJMKuS9WUF+DaQG9vzaACQd9pUUVHrs3HNxiKh8TngjfsdNFt2ZUhPQraQ/QI mnx77nDDITsUP3Q+/+QzQdIrHF9Pku47At+8nyEQ/FPE8w7tDip+g8a385XR1Fa+M1H6 GaAyxQUfZE9AApUWSLAZn3zBo8jysi2t/qolI0SkgVc8kPyb2VvB7kY+JL4S1xK5Fsrs O8nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=gjfIvRRsDGl+e6Ip6O6DhgCWq+6HKwzb1wpZnhHi+MI=; b=IJqapQ8R0ra/mxPfQnfYFPIi3u8Sm1OwuLAw7/gVuFr/6mOvZfKPO8wO2tnezOLH/V bb6OXz9Qr6WXEFMX1dbFIWCDdRT+cebdSeOb/Gw1PemlPaVsTt9csKEX/KxqTs2+Cn9a CE+hOLyRImdZmjKFVQD5U5CYOzmlJmWrREkp/DK1Up91r1SyJTi6XbN6rTqXMLZBloWL Ap11pvmykf1GPaK2agm1Xt2PGos8p923S1MxhK/qKCsybZHktaR1X8+pdXT4SuBCNi9t XkQnWjhch+I7Bo1+Rmm+JdLU67Lp2Dj1TbYHwdHCkSIGb33FZ09afxutTgxBB7wTDLDj Lq9A== X-Gm-Message-State: APjAAAVzKNJfbIF3uuaLJwg1xtYpW2p9fSjQBSJ3CTJBG8YBL46OntAx aM0XtfVGYvD48DrzpNWY1h9sJzMq X-Google-Smtp-Source: APXvYqwPIW7MtwHitBhVVozTH3drjqXf5fKhuVEINKvrt/hqW1ZoygVg3dfXK+RRrRthmkp9me0zvA== X-Received: by 2002:a1c:7e91:: with SMTP id z139mr2620880wmc.15.1573545086456; Mon, 11 Nov 2019 23:51:26 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id 205sm4038837wmb.3.2019.11.11.23.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 23:51:25 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <83tv7da6qf.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Nov 2019 08:44:56 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::333 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242106 Archived-At: >>>>> On Sat, 09 Nov 2019 08:44:56 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: emacs-devel@gnu.org >> Date: Fri, 08 Nov 2019 22:40:52 +0100 >>=20 >> The following works for me: Eli> LGTM, thanks. I would just change the name of the new function to Eli> something like font_is_ignored, which is slightly more general, an= d so Eli> will still fit if we later modify that function to do something Eli> instead of in addition to matching against face-ignored-fonts. But Eli> that's admittedly splitting hair. Naming is difficult, and I=CA=BCm bad at it. Strictly speaking you could say it should be 'font_font_is_ignored', since the first 'font_' is the subsystem prefix, but 'font_is_ignored' works for me. Eli> Another thing that I miss in the patch is the actual setting of Eli> face-ignored-fonts for GTK builds. We want to do that by default, Eli> yes? We do, but that=CA=BCs a separate and independent patch (I should probably put something in PROBLEMS as well). diff --git i/src/xfaces.c w/src/xfaces.c index 3806fa90e2..35feca7e4e 100644 --- i/src/xfaces.c +++ w/src/xfaces.c @@ -6770,12 +6770,15 @@ syms_of_xfaces (void) doc: /* List of ignored fonts. Each element is a regular expression that matches names of fonts to ignore. */); -#ifdef HAVE_OTF_KANNADA_BUG - /* https://debbugs.gnu.org/30193 */ - Vface_ignored_fonts =3D list1 (build_string ("Noto Serif Kannada")); +#ifdef HAVE_XFT + Vface_ignored_fonts =3D list1 (build_string ("Noto Color Emoji")); #else Vface_ignored_fonts =3D Qnil; #endif +#ifdef HAVE_OTF_KANNADA_BUG + /* https://debbugs.gnu.org/30193 */ + Vface_ignored_fonts =3D Fcons (build_string ("Noto Serif Kannada"), Vfac= e_ignored_fonts); +#endif DEFVAR_LISP ("face-remapping-alist", Vface_remapping_alist, doc: /* Alist of face remappings.