From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#56623: memory leak introduced by new nonrecursive lisp reader Date: Mon, 29 Aug 2022 10:44:46 +0200 Message-ID: References: <7DC3EB6A-097E-46F1-806E-33C02F01EA47@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3852"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: Tom Gillespie , 56623@debbugs.gnu.org, greghendershott@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 29 10:46:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSaPn-0000qA-Uf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Aug 2022 10:46:39 +0200 Original-Received: from localhost ([::1]:38072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSaPm-0003u7-Kn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Aug 2022 04:46:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSaOE-0003tl-5Y for bug-gnu-emacs@gnu.org; Mon, 29 Aug 2022 04:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oSaOD-00008w-RW for bug-gnu-emacs@gnu.org; Mon, 29 Aug 2022 04:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oSaOD-00056Q-M1 for bug-gnu-emacs@gnu.org; Mon, 29 Aug 2022 04:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Aug 2022 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 56623-submit@debbugs.gnu.org id=B56623.166176269719593 (code B ref 56623); Mon, 29 Aug 2022 08:45:01 +0000 Original-Received: (at 56623) by debbugs.gnu.org; 29 Aug 2022 08:44:57 +0000 Original-Received: from localhost ([127.0.0.1]:60066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSaO9-00055x-4I for submit@debbugs.gnu.org; Mon, 29 Aug 2022 04:44:57 -0400 Original-Received: from mail-ed1-f54.google.com ([209.85.208.54]:37381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSaO7-00055j-8T for 56623@debbugs.gnu.org; Mon, 29 Aug 2022 04:44:55 -0400 Original-Received: by mail-ed1-f54.google.com with SMTP id b16so9203427edd.4 for <56623@debbugs.gnu.org>; Mon, 29 Aug 2022 01:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc; bh=7/aCz4QfFFmOxfTSthIxNHppmsoBUL3uSK7zpfMUbDc=; b=Og/geio2wFs8esDTYcTDZwNL43kKwS2sGG0lVBgT75X+7cNDljBcS3UaPGROwCzyQW w0IQQYaRr6WL0tiIxfuAnd9AuGWjs/93JwMuX6OsbWnLvDHFjTI1wV9MIfm6rIT4ANFi sU3Ee79/MrB3FXAGB+84kWpZhw/JgV2Az7v4WNP97wZl+etssc1mvthg4oDURN1QsVJx yZ41rJM5dlzlRpDZMu5Mwng3LShox8fCdBhazwGeqnZb6we7kl2oIciaeBdSjfTkEwV+ uoHnQ6XHVG7e5m9CRDsels+wzSRhrS8fzwfXPYx2AQg1PBi8fQZFDnbP+1tFevuuzIqE Ny+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc; bh=7/aCz4QfFFmOxfTSthIxNHppmsoBUL3uSK7zpfMUbDc=; b=hEdP29xq55r8Z6UmgCj4Sr05ZTuf67BI80tvpTr0S45kzp2IvFLtS1h/s+zf8emLEq 7dYcOBNi7yOltqoHB99M6s8KZwI/5F7Qrb3fpoPneHZhwBUgW5wGbbQp2Kp+HGWeXZWY hj0h3NV3AyL3sWY4R4yCAILHa0ZvhoCubRTD6curJfASZ6jwT+mwudTyt/KjXN371Aee 0vGPnmk+oHI9ifBFefecW29SP1zhC4hWyW2yJebhhNXiBvonB6XvxmrmRWjNYJX0+AbU gy2MzYG6FoJmMH3v88ju+IY0POoBCvic1lagkul/yZfEi8KTOu+YmTjZhXZB2AXGyZa3 Pa1w== X-Gm-Message-State: ACgBeo1LvVaFRSrmTUKXiaDehNtcAKcF/1eL7C2vxqGwFg84IGtD5jRX Bo+O952pAFfigjkfNksy+B4IQZFHzZSEKg== X-Google-Smtp-Source: AA6agR5Jnc7PHcDkcQ7oOyRXmxVVEpEKixMqWxATfkcfInDlJ3FMNc952dctA8vw9D4Pv/lCT4Ok/g== X-Received: by 2002:a05:6402:882:b0:447:e6b9:89db with SMTP id e2-20020a056402088200b00447e6b989dbmr11602489edy.346.1661762688877; Mon, 29 Aug 2022 01:44:48 -0700 (PDT) Original-Received: from Mini.fritz.box (pd9e36666.dip0.t-ipconnect.de. [217.227.102.102]) by smtp.gmail.com with ESMTPSA id e16-20020a056402089000b0043cab10f702sm5326083edy.90.2022.08.29.01.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 01:44:48 -0700 (PDT) In-Reply-To: <7DC3EB6A-097E-46F1-806E-33C02F01EA47@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Wed, 27 Jul 2022 11:20:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241006 Archived-At: Mattias Engdeg=C3=A5rd writes: > If either makes things better, maybe we can come up with a solution > that doesn't hurt performance. This might be completely off, but anyway: lread.c uses free_cons. Is it certain that the cons cell is never marked at that point? Not that I see it happening, or could explain how exactly GC would run while that code executes. Maybe it's worth adding a check in free_cons?