all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#70262: 30.0.50; [PATCH] align.el: Delete unnecessary :group keywords
@ 2024-04-07 19:18 Arash Esbati
  2024-04-08 11:10 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Arash Esbati @ 2024-04-07 19:18 UTC (permalink / raw)
  To: 70262

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

Hi all,

this is a trivial patch removing all ":group 'align" entries from the
custom forms.

Best, Arash

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-align.el-Remove-unnecessary-group-keywords.patch --]
[-- Type: text/x-patch, Size: 6087 bytes --]

From 61c8e73551b39cf768ab3b8866f0ac932ed2b9c8 Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Sun, 7 Apr 2024 21:12:05 +0200
Subject: [PATCH] ; * lisp/align.el: Remove unnecessary :group keywords.

---
 lisp/align.el | 62 +++++++++++++++++----------------------------------
 1 file changed, 21 insertions(+), 41 deletions(-)

diff --git a/lisp/align.el b/lisp/align.el
index 0e77a857585..6c393f7ee26 100644
--- a/lisp/align.el
+++ b/lisp/align.el
@@ -126,15 +126,13 @@ align
 
 (defcustom align-load-hook nil
   "Hook that gets run after the aligner has been loaded."
-  :type 'hook
-  :group 'align)
+  :type 'hook)
 (make-obsolete-variable 'align-load-hook
                         "use `with-eval-after-load' instead." "28.1")
 
 (defcustom align-indent-before-aligning nil
   "If non-nil, indent the marked region before aligning it."
-  :type 'boolean
-  :group 'align)
+  :type 'boolean)
 
 (defcustom align-default-spacing 1
   "An integer that represents the default amount of padding to use.
@@ -142,14 +140,12 @@ align-default-spacing
 tab stops to use for alignment, rather than the number of spaces.
 Each alignment rule can optionally override both this variable and
 `align-to-tab-stop'.  See `align-rules-list'."
-  :type 'integer
-  :group 'align)
+  :type 'integer)
 
 (defcustom align-to-tab-stop 'indent-tabs-mode
   "If non-nil, alignments will always fall on a tab boundary.
 It may also be a symbol, whose value will be taken."
-  :type '(choice (const nil) symbol)
-  :group 'align)
+  :type '(choice (const nil) symbol))
 
 (defcustom align-region-heuristic 500
   "If non-nil, used as a heuristic by `align-current'.
@@ -160,66 +156,55 @@ align-region-heuristic
 values can mean slower performance in large files, although smaller
 values may cause unexpected behavior at times."
   :type '(choice (const :tag "Don't use heuristic when aligning a region" nil)
-                 integer)
-  :group 'align)
+                 integer))
 
 (defcustom align-highlight-change-face 'highlight
   "The face to highlight with if changes are necessary.
 Used by the `align-highlight-rule' command."
-  :type 'face
-  :group 'align)
+  :type 'face)
 
 (defcustom align-highlight-nochange-face 'secondary-selection
   "The face to highlight with if no changes are necessary.
 Used by the `align-highlight-rule' command."
-  :type 'face
-  :group 'align)
+  :type 'face)
 
 (defcustom align-large-region 10000
   "If an integer, defines what constitutes a \"large\" region.
 If nil, then no messages will ever be printed to the minibuffer."
-  :type '(choice (const :tag "Align a large region silently" nil) integer)
-  :group 'align)
+  :type '(choice (const :tag "Align a large region silently" nil) integer))
 
 (defcustom align-c++-modes '( c++-mode c-mode java-mode)
   "A list of modes whose syntax resembles C/C++."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-perl-modes '(perl-mode)
   "A list of modes where Perl syntax is to be seen."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-lisp-modes
   '(emacs-lisp-mode lisp-interaction-mode lisp-mode scheme-mode)
   "A list of modes whose syntax resembles Lisp."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-tex-modes
   '(tex-mode plain-tex-mode latex-mode slitex-mode)
   "A list of modes whose syntax resembles TeX (and family)."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-text-modes '(text-mode outline-mode)
   "A list of modes whose content is plain text."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-dq-string-modes
   (append align-lisp-modes align-c++-modes align-perl-modes
           '(python-base-mode vhdl-mode))
   "A list of modes where double quoted strings should be excluded."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-sq-string-modes
   (append align-perl-modes '(python-base-mode))
   "A list of modes where single quoted strings should be excluded."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-open-comment-modes
   (append align-lisp-modes align-c++-modes align-perl-modes
@@ -227,8 +212,7 @@ align-open-comment-modes
   "A list of modes with a single-line comment syntax.
 These are comments as in Lisp, which have a beginning, but end with
 the line (i.e., `comment-end' is an empty string)."
-  :type '(repeat symbol)
-  :group 'align)
+  :type '(repeat symbol))
 
 (defcustom align-region-separate "^\\s-*[{}]?\\s-*$"
   "Select the method by which alignment sections will be separated.
@@ -317,11 +301,10 @@ align-region-separate
   :type '(choice
 	  (const :tag "Entire region is one section" entire)
 	  (const :tag "Align by contiguous groups" group)
-;         (const largest)
+          ;; (const largest)
 	  (regexp :tag "Regexp defines section boundaries")
 	  (function :tag "Function defines section boundaries"))
-  :risky t
-  :group 'align)
+  :risky t)
 
 (defvar align-rules-list-type
   '(repeat
@@ -714,8 +697,7 @@ align-rules-list
 	    (see the documentation of that variable for possible
 	    values), and any separation argument passed to `align'."
   :type align-rules-list-type
-  :risky t
-  :group 'align)
+  :risky t)
 
 (defvar align-exclude-rules-list-type
   '(repeat
@@ -784,8 +766,7 @@ align-exclude-rules-list
   "A list describing text that should be excluded from alignment.
 See the documentation for `align-rules-list' for more info."
   :type align-exclude-rules-list-type
-  :risky t
-  :group 'align)
+  :risky t)
 
 ;;; Internal Variables:
 
@@ -836,8 +817,7 @@ align-vhdl-rules-list
      (regexp   . "\\(\\s-+\\)use\\s-+entity")))
   "Alignment rules for `vhdl-mode'.  See `align-rules-list' for more info."
   :type align-rules-list-type
-  :risky t
-  :group 'align)
+  :risky t)
 (make-obsolete-variable 'align-vhdl-rules-list "no longer used." "27.1")
 
 (defun align-set-vhdl-rules ()
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#70262: 30.0.50; [PATCH] align.el: Delete unnecessary :group keywords
  2024-04-07 19:18 bug#70262: 30.0.50; [PATCH] align.el: Delete unnecessary :group keywords Arash Esbati
@ 2024-04-08 11:10 ` Eli Zaretskii
  2024-04-08 12:32   ` Arash Esbati
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2024-04-08 11:10 UTC (permalink / raw)
  To: Arash Esbati; +Cc: 70262

> From: Arash Esbati <arash@gnu.org>
> Date: Sun, 07 Apr 2024 21:18:48 +0200
> 
> this is a trivial patch removing all ":group 'align" entries from the
> custom forms.

Thanks, feel free to install on the master branch.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#70262: 30.0.50; [PATCH] align.el: Delete unnecessary :group keywords
  2024-04-08 11:10 ` Eli Zaretskii
@ 2024-04-08 12:32   ` Arash Esbati
  0 siblings, 0 replies; 3+ messages in thread
From: Arash Esbati @ 2024-04-08 12:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 70262-done

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, feel free to install on the master branch.

Thanks, pushed and closing.

Best, Arash





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-08 12:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-07 19:18 bug#70262: 30.0.50; [PATCH] align.el: Delete unnecessary :group keywords Arash Esbati
2024-04-08 11:10 ` Eli Zaretskii
2024-04-08 12:32   ` Arash Esbati

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.