all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Bochannek <alex@bochannek.com>
To: "Jakub Ječmínek" <kuba@kubajecminek.cz>
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>,
	"70134@debbugs.gnu.org" <70134@debbugs.gnu.org>,
	Eli Zaretskii <eliz@gnu.org>, "larsi@gnus.org" <larsi@gnus.org>,
	Richard Stallman <rms@gnu.org>
Subject: bug#70134: [PATCH] Show all date options when adding Gnus scores interactively
Date: Wed, 22 May 2024 16:30:07 -0700	[thread overview]
Message-ID: <m21q5t2znk.fsf@bochannek.com> (raw)
In-Reply-To: <87v835edkg.fsf@kubajecminek.cz> ("Jakub Ječmínek"'s message of "Wed, 22 May 2024 21:34:10 +0000")

Jakub,

Jakub Ječmínek <kuba@kubajecminek.cz> writes:

> Ping :).  Is there anything else that needs to be resolved before this is
> installed?  We can create different subtask for the bug that Alex pointed
> out.

I did some testing again and the functionality you describe works
perfectly fine. I still would prefer the bug I pointed out to be fixed
before merging.

My concern is that with the change applied, adding a new date-header
scoring rule interactively will rewrite some existing date rules in the
SCORE file. Expectedly not just entries created interactively, but any
entries in the list regardless of how they were created. In my testing,
I found this to be the case for all entries that are not using the new
match types for dates (i.e, for `before', `after', and `at', not for
`r', `<', or `>'.)

I am perfectly happy to be overruled, I just think it will be confusing
to the users. If however a patch for this is forthcoming quickly, I am
OK with merging it.

-- 
Alex.





  reply	other threads:[~2024-05-22 23:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 21:44 bug#70134: [PATCH] Show all date options when adding Gnus scores interactively Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13  7:58 ` Eli Zaretskii
2024-04-22  3:33   ` Eric Abrahamsen
2024-04-24 22:52     ` Richard Stallman
2024-04-24 23:08       ` Alex Bochannek
2024-05-01 19:27         ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-07  2:53           ` Alex Bochannek
2024-05-09 19:15             ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 23:59               ` Eric Abrahamsen
2024-05-10 20:04                 ` Eric Abrahamsen
2024-05-10 20:38                   ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-10 21:27                     ` Eric Abrahamsen
2024-05-14  2:00                     ` Alex Bochannek
2024-05-14 14:52                       ` Eric Abrahamsen
2024-05-14 18:43                         ` Alex Bochannek
2024-05-14 19:57                           ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 14:15                             ` Eric Abrahamsen
2024-05-16 19:40                               ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 21:34 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 23:30   ` Alex Bochannek [this message]
2024-05-23  2:50     ` Eric Abrahamsen
2024-05-26 14:22       ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-26 22:09 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 21:23 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30  0:16   ` Alex Bochannek
2024-05-30  9:01     ` Andrea Corallo
2024-05-30 16:30       ` Alex Bochannek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21q5t2znk.fsf@bochannek.com \
    --to=alex@bochannek.com \
    --cc=70134@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=kuba@kubajecminek.cz \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.