From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Sun, 30 Jun 2024 17:32:07 +0200 Message-ID: References: <87v81u85hv.fsf@localhost> <87cyo180y2.fsf@localhost> <874j9d7zqe.fsf@localhost> <87sewvg6lw.fsf@localhost> <87sewuk4l6.fsf@localhost> <87r0celi67.fsf@localhost> <871q4e4fsv.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , emacs-devel@gnu.org, Eli Zaretskii , eller.helmut@gmail.com To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 30 17:33:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNwYI-0003KN-31 for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jun 2024 17:33:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNwXQ-0004NP-Ec; Sun, 30 Jun 2024 11:32:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNwXG-0004My-PV for emacs-devel@gnu.org; Sun, 30 Jun 2024 11:32:16 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNwXD-0004T0-8j; Sun, 30 Jun 2024 11:32:13 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-424ad289912so16075135e9.2; Sun, 30 Jun 2024 08:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719761529; x=1720366329; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ISWjLgmCMX5n0tvSd4tSv9VbsoP+7dDAIqQmJCOPyWU=; b=jsALM25QgW9+r8ZrSTYQ+go+wG8w4iPJplQ/Pcc7DAjFn+m2xuFhzRK4IDHcF09MTM kX6iBgRsSn6qcnUHwxlDBpR+//WSPrKtieq3yHJYwp3vyrhMBCzRWtrytyZMpiTDKvI/ Cg2uZDeSMz+1EVY0D5lBckBh4XKgJWzSUiyBLddJ+asKfOtsOy8EBp+IK2sn6D5CJ1it qJmvSF5dkm32WGoe7koBmvN8gBg+/uC9w82bu4SOhysEbFw1RbhbZGz99bGjNLtVLWZG KCrhnLWr0yxU3gNJq5Pms3niIujSDJ5U1rOUqJhqviJCT4+zqnDyiYJxf1drHu0Y2nxo xBgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719761529; x=1720366329; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ISWjLgmCMX5n0tvSd4tSv9VbsoP+7dDAIqQmJCOPyWU=; b=OHcW47YbDbl4Cc4U4BcrOxaa05+rsJOh/smt68V1VjcRwKNI4pqSJfZYxqrdLMIEJl MiWgpZjVDncWxO6jf8LxosL51/Z/+pdk/pPuJSe5AAmm1Br2uUjX+a7DeYOg1D09kHP2 +QtR8ExjuIV8Np2CUpjH/ytGNmE4oD03z/rclh/NRjlA80VheXMtQA+ZYWMu7sEeP7R2 Z2RZ3XHYeo5Z1CdDuDbd/GjgqkbubelEimM0OjZh42TixtVZ6RRmWkD05ak91Td6tnX1 YqIj7Rjla2zmjbCwjHHV7MetOQGDwbQwRHFLJKbTJx4jP7+KF4CD8Ui6IFqI06mdYOjf 4WSA== X-Forwarded-Encrypted: i=1; AJvYcCWXDd73zt3pn6wZyB9gmJwXS4x9MYfY+74k2W1EVYq4ZbYz2xf4wMnOWrPoXNwNe+7mBsxNs6Zq7q2wFY02eqQS6LQr8VDCpn9TSylqFS8KM04= X-Gm-Message-State: AOJu0Yy3IuBgYuetm44EYko871wUrdgyi0ZDdMZ9GFzNIZPaL/Gqv7St Bx/zUunClX5qs+6KUdxV5zn6Qij2Mrljps/DP5bHZ5JBABmxIeLF X-Google-Smtp-Source: AGHT+IGPsJ4jRkiIHV0Eun4T8gBdIGowQTSH0mB++b48emlcrdje5iGOleTWxxk7FQoxna84THQ2hg== X-Received: by 2002:adf:f5c4:0:b0:365:ebb6:35e4 with SMTP id ffacd0b85a97d-367756a836amr2461986f8f.23.1719761528742; Sun, 30 Jun 2024 08:32:08 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a45.dip0.t-ipconnect.de. [217.227.106.69]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0e0661sm7646191f8f.47.2024.06.30.08.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 08:32:08 -0700 (PDT) In-Reply-To: <871q4e4fsv.fsf@localhost> (Ihor Radchenko's message of "Sun, 30 Jun 2024 15:21:36 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320970 Archived-At: Ihor Radchenko writes: > Gerd M=C3=B6llmann writes: > >> Ihor Radchenko writes: >> >>> Gerd M=C3=B6llmann writes: >>> >>>> Thanks, Ihor, that looks promising. I've now also pushed a quick and >>>> dirty add_marker in O(1), that's why I reverted. to get that on top. >>>> Works for me... > > I no longer see markers in the perf stats. Very good. Thanks for testing, Ihor! >>>> A comparison of how it feels compared to master would also be interest= ing. > > Still crashing :) (mostly because of child process signal - it > constantly triggers when running background compilation via staight.el) > > Otherwise, things are snappy. At least on par with master (to open my > agenda, in terms of CPU samples recorded by perf), if not faster. (but I > had to remove all the debug info from the build and not run gdb to get > that "on par") Thanks, that sounds good. I guess I'll consider the marker stuff done for now. The code could need some clean up though.