From: tsd@tsdye.com (Thomas S. Dye)
To: Andreas Leha <andreas.leha@med.uni-goettingen.de>
Cc: emacs-orgmode@gnu.org
Subject: [PATCH] Re: [BUG] [babel] R graphics header arg :units
Date: Mon, 18 Jun 2012 17:36:02 -1000 [thread overview]
Message-ID: <m1zk80gehp.fsf@tsdye.com> (raw)
In-Reply-To: <871uldd738.fsf@med.uni-goettingen.de> (Andreas Leha's message of "Sun, 17 Jun 2012 22:19:39 +0200")
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
Andreas Leha <andreas.leha@med.uni-goettingen.de> writes:
> Hi all,
>
> I am having troubles in using the header argument :units which is
> implemented for R source blocks. Example:
>
> #+begin_src R :results graphics :file wideplot.png :width 14 :height 7 :units "cm"
> plot(1:10, 1:10)
> #+end_src
>
>
> This expands to
>
> : png(filename="wideplot.png",height=7,units=cm,width=14)
> : plot(1:10, 1:10)
> : dev.off()
>
> and leads -- when evaluated -- to the error
>
> : Fehler in match.arg(units, c("in", "px", "cm", "mm")) :
> : 'arg' must be NULL or a character vector
>
> I guess this is a bug, correct? Otherwise, how do I correctly use
> this header argument?
>
> Regards,
> Andreas
>
>
>
Aloha all,
The attached patch handles quoted string values for R device header
arguments. With the patch the following works as expected:
#+header: :width 100 :height 100 :units "mm" :res 120
#+BEGIN_SRC R :results graphics :file "test.png"
x <- c(1,2,3,4,5)
y <- x
plot(x,y)
#+END_SRC
All the best,
Tom
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch for ob-R.el --]
[-- Type: text/x-patch, Size: 705 bytes --]
From b8aa7b26f56300faadd1a40433208ef18db8ae73 Mon Sep 17 00:00:00 2001
From: Thomas Dye <tsd@tsdye.com>
Date: Mon, 18 Jun 2012 17:26:09 -1000
Subject: [PATCH] * lisp/ob-R.el: Handle quoted string values to device header
arguments
---
lisp/ob-R.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index d23f269..0802736 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -260,7 +260,7 @@ current code buffer."
(setq args (mapconcat
(lambda (pair)
(if (member (car pair) allowed-args)
- (format ",%s=%s"
+ (format ",%s=%S"
(substring (symbol-name (car pair)) 1)
(cdr pair)) ""))
params ""))
--
1.7.5.4
[-- Attachment #3: Type: text/plain, Size: 40 bytes --]
--
Thomas S. Dye
http://www.tsdye.com
next prev parent reply other threads:[~2012-06-19 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 20:19 [BUG] [babel] R graphics header arg :units Andreas Leha
2012-06-17 22:06 ` Thomas S. Dye
2012-06-17 23:05 ` Myles English
2012-06-18 6:48 ` Andreas Leha
2012-06-19 3:36 ` Thomas S. Dye [this message]
2012-06-19 7:05 ` [PATCH] " Andreas Leha
2012-06-19 13:26 ` Eric Schulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1zk80gehp.fsf@tsdye.com \
--to=tsd@tsdye.com \
--cc=andreas.leha@med.uni-goettingen.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.