From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Daniel_Mart=C3=ADn?= Newsgroups: gmane.emacs.devel Subject: Re: Fwd: 13 Test Failures Date: Tue, 08 Sep 2020 14:35:18 +0200 Message-ID: References: <87blih907u.fsf@gnus.org> <877dt5905t.fsf@gnus.org> <875z8p7eqf.fsf@gnus.org> <87wo155zg3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28557"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: Stefan Kangas , Vin Shelton , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 08 14:38:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFcsy-0007KF-4k for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Sep 2020 14:38:08 +0200 Original-Received: from localhost ([::1]:45684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFcsx-00055F-4U for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Sep 2020 08:38:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFcqR-0000s7-Vt for emacs-devel@gnu.org; Tue, 08 Sep 2020 08:35:32 -0400 Original-Received: from sonic304-22.consmr.mail.ir2.yahoo.com ([77.238.179.147]:37481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFcqO-0008Rv-Kx for emacs-devel@gnu.org; Tue, 08 Sep 2020 08:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1599568525; bh=1UnVCvDRC7QS3D04q7/CWd+P2jZAn3OjxkVBFdNwitk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=A3uT2FqsF3MsOLxIdF/JEIBmwibClL5IIEl5W6kHI5l7aoV5tzGsp8woh4/ZHngsGCWq+9HA6/U4LMF0fFb5D/3Zu4iCbLAKksN624zaMV6FNRdgcTvMcWS/IP0/SjlVrPDh4l7mdNqdcV1JmL+mKKwLhlxqNxCPHg8d7AvnazIjodm16y5jMMJkk1KaZU3jW13S26NrqS13g8wz2ZEPk3XrTG/WjP9ThkG8bZkOJ0PHKkt94nSmNGWYejQiV4yiBTfV4XLZQ9pzhysyx6KRBc6eq9oyceMrmsmp+fFXNkayS+5IUyFFSlTlc8u6ZkLnHbORN5yjtrAk9utBB9fggQ== X-YMail-OSG: x8EJpnoVM1lJXoxpEJ51vGop3sw71.S2w4htYgGBiocr6ypCQuVRKlpDKgs1C_X v9iBqtkTtDQ9.JSm83NRhvWchhbxQ7CLTzJAXLVWzVQwEp2zL8za3O48yuzz6u_VO7bMGBDn9dw. 9a5Zc8irr_5IQtDEMkPKvvfbA5p6YHMTMwRzB2PIkErBv1ZCFnMYuFZvJU95wNXkJWv2TrmaMV3S utMFeALVlORLNzkEGP91HCQ8BpUJ5QxoFcPWHMsSlioLxnNeb_mlgWPX8JyZE74Pnrr.kl.uQMNO 8TZBzx5783Ib679zxOmm5VEoTDRps.JBWX5EYlLcMLhuHtyimSYrDnrDK6TxhPPsileWN8GBEPuK jmjVbgKwTrnJB3v9De0JxhdhSssSGsR4Ox1PlS8n5LLkcx3Z0hvm_SOJBsiWYvjw799Qtlc3gzjo TpHjCCN0deoAdo2cRhl167ifz3poDHA2nLFaYLY4shZVd4swGXDfxKVk7MM2lJQ4d7m_TixgMfEv A1pL20RUjbjsDrTNwtbVtew5o64OlC5Yq3L6XUWMV06XfcUu3aADRfdG6rDKfGJiiyXX58.Srf2S 6nkyw1dzqrRRNMXBhkkCdkq46EpoFJ7pUYsXWLqvW3Dq6VqclhcxYBbuD39JqdP0oz.9r61_4tVo XoFFGJcd6_07TILQRQvlBXCXjnv1AqdnjAVaq0zspYtTwFhqcgRJl6cjqoEyktY.a4IV_nMFk2YG EyI9l_xc2BuLz0JRrSor7jlTsRHlHFOY3lQsNI_652vgM4Oo0Y9qOZchOwDsnJyqyMyNHMyfW0sG zbD1j9uNx8CE1dGO7dv4fuQjPA1j8ZmE9XnQBMdf7q Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Tue, 8 Sep 2020 12:35:25 +0000 Original-Received: by smtp407.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 92f872d37f3bd004d2238604c10beff3; Tue, 08 Sep 2020 12:35:21 +0000 (UTC) In-Reply-To: <87wo155zg3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 07 Sep 2020 18:22:36 +0200") X-Mailer: WebService/1.1.16565 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=77.238.179.147; envelope-from=mardani29@yahoo.es; helo=sonic304-22.consmr.mail.ir2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 08:35:25 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254724 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > I've now fixed both the test failures so that "make check" in the main > directory now has now unexpected results (on Debian bullseye). One of the tests in mwheel-tests.el fails on macOS (and possibly other platforms). I've attached a patch to fix the problem. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-mouse-wheel-up-event-in-mwheel-tests.el.patch >From 883c892436affce26726bdd2f91b6ed9e24c9e6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Tue, 8 Sep 2020 14:18:17 +0200 Subject: [PATCH] Use mouse-wheel-up-event in mwheel-tests.el Enabling mouse-wheel-mode binds two different mouse events, depending on the operating system. The correct way to check for those events is by checking mouse-wheel-up-event, as explained in the ELisp manual. * test/lisp/mwheel-tests.el (mwheel-test-enable/disable): Check mouse-wheel-up-event instead of mouse-4 to make the test work irrespective of the platform it's running. --- test/lisp/mwheel-tests.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/lisp/mwheel-tests.el b/test/lisp/mwheel-tests.el index fd998fd4f0..315f25edae 100644 --- a/test/lisp/mwheel-tests.el +++ b/test/lisp/mwheel-tests.el @@ -24,9 +24,9 @@ (ert-deftest mwheel-test-enable/disable () (mouse-wheel-mode 1) - (should (eq (lookup-key (current-global-map) '[mouse-4]) 'mwheel-scroll)) + (should (eq (lookup-key (current-global-map) `[,mouse-wheel-up-event]) 'mwheel-scroll)) (mouse-wheel-mode -1) - (should (eq (lookup-key (current-global-map) '[mouse-4]) nil))) + (should (eq (lookup-key (current-global-map) `[,mouse-wheel-up-event]) nil))) (ert-deftest mwheel-test--create-scroll-keys () (should (equal (mouse-wheel--create-scroll-keys 10 'mouse-4) -- 2.28.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable -- Daniel Mart=C3=ADn --=-=-=--