Re: Fwd: 13 Test Failures

["Daniel Martín" <mardani29@yahoo.es>]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now fixed both the test failures so that "make check" in the main
> directory now has now unexpected results (on Debian bullseye).

One of the tests in mwheel-tests.el fails on macOS (and possibly other
platforms). I've attached a patch to fix the problem.

Thanks.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-mouse-wheel-up-event-in-mwheel-tests.el.patch --]
[-- Type: text/x-patch, Size: 1421 bytes --]

From 883c892436affce26726bdd2f91b6ed9e24c9e6f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= <mardani29@yahoo.es>
Date: Tue, 8 Sep 2020 14:18:17 +0200
Subject: [PATCH] Use mouse-wheel-up-event in mwheel-tests.el

Enabling mouse-wheel-mode binds two different mouse events, depending
on the operating system. The correct way to check for those events is
by checking mouse-wheel-up-event, as explained in the ELisp manual.

* test/lisp/mwheel-tests.el (mwheel-test-enable/disable): Check
mouse-wheel-up-event instead of mouse-4 to make the test work
irrespective of the platform it's running.
---
 test/lisp/mwheel-tests.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/lisp/mwheel-tests.el b/test/lisp/mwheel-tests.el
index fd998fd4f0..315f25edae 100644
--- a/test/lisp/mwheel-tests.el
+++ b/test/lisp/mwheel-tests.el
@@ -24,9 +24,9 @@
 
 (ert-deftest mwheel-test-enable/disable ()
   (mouse-wheel-mode 1)
-  (should (eq (lookup-key (current-global-map) '[mouse-4]) 'mwheel-scroll))
+  (should (eq (lookup-key (current-global-map) `[,mouse-wheel-up-event]) 'mwheel-scroll))
   (mouse-wheel-mode -1)
-  (should (eq (lookup-key (current-global-map) '[mouse-4]) nil)))
+  (should (eq (lookup-key (current-global-map) `[,mouse-wheel-up-event]) nil)))
 
 (ert-deftest mwheel-test--create-scroll-keys ()
   (should (equal (mouse-wheel--create-scroll-keys 10 'mouse-4)
-- 
2.28.0


[-- Attachment #3: Type: text/plain, Size: 22 bytes --]


--
Daniel Martín